You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/08/02 12:17:53 UTC
Review Request 68166: Moved around some functions definitions between
files.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68166/
-----------------------------------------------------------
Review request for mesos and Alexander Rukletsov.
Repository: mesos
Description
-------
This commit contains some fixups to the movement of the Framework
implementation code to a separate file in the previous commit.
* Changed Framework::send() to use an out-of-class definition.
* Moved back trivial functions back to the header file.
* Moved private constructor to the top of the file in `framework.cpp`.
Diffs
-----
src/master/framework.cpp PRE-CREATION
src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116
Diff: https://reviews.apache.org/r/68166/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 68166: Moved around some functions definitions
between files.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68166/#review206801
-----------------------------------------------------------
PASS: Mesos patch 68166 was successfully built and tested.
Reviews applied: `['68141', '68166']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2031/mesos-review-68166
- Mesos Reviewbot Windows
On Aug. 2, 2018, 6:23 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68166/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2018, 6:23 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit contains some fixups to the movement of the Framework
> implementation code to a separate file in the previous commit.
>
> * Changed Framework::send() to use an out-of-class definition.
> * Moved back trivial functions back to the header file.
> * Moved private constructor to the top of the file in `framework.cpp`.
>
>
> Diffs
> -----
>
> src/master/framework.cpp PRE-CREATION
> src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116
>
>
> Diff: https://reviews.apache.org/r/68166/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68166: Moved around some functions definitions
between files.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68166/
-----------------------------------------------------------
(Updated Aug. 2, 2018, 1:23 p.m.)
Review request for mesos and Alexander Rukletsov.
Repository: mesos
Description
-------
This commit contains some fixups to the movement of the Framework
implementation code to a separate file in the previous commit.
* Changed Framework::send() to use an out-of-class definition.
* Moved back trivial functions back to the header file.
* Moved private constructor to the top of the file in `framework.cpp`.
Diffs (updated)
-----
src/master/framework.cpp PRE-CREATION
src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116
Diff: https://reviews.apache.org/r/68166/diff/2/
Changes: https://reviews.apache.org/r/68166/diff/1-2/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 68166: Moved around some functions definitions
between files.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68166/#review206796
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Aug. 2, 2018, 12:17 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68166/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2018, 12:17 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit contains some fixups to the movement of the Framework
> implementation code to a separate file in the previous commit.
>
> * Changed Framework::send() to use an out-of-class definition.
> * Moved back trivial functions back to the header file.
> * Moved private constructor to the top of the file in `framework.cpp`.
>
>
> Diffs
> -----
>
> src/master/framework.cpp PRE-CREATION
> src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116
>
>
> Diff: https://reviews.apache.org/r/68166/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>