You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "janhoy (via GitHub)" <gi...@apache.org> on 2023/02/15 23:08:06 UTC
[GitHub] [solr] janhoy opened a new pull request, #1361: SOLR-16660 Deprecate analytics component
janhoy opened a new pull request, #1361:
URL: https://github.com/apache/solr/pull/1361
https://issues.apache.org/jira/browse/SOLR-16660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a diff in pull request #1361: SOLR-16660 Deprecate analytics component
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on code in PR #1361:
URL: https://github.com/apache/solr/pull/1361#discussion_r1113185851
##########
solr/solr-ref-guide/modules/query-guide/pages/analytics-mapping-functions.adoc:
##########
@@ -18,6 +18,8 @@
Mapping functions map values for each Solr Document or Reduction.
+WARNING: The analytics component is deprecated. We recommend looking into similar functionality found in xref:json-facet-api.adoc[JSON Facet API].
Review Comment:
See suggestion below @HoustonPutman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy merged pull request #1361: SOLR-16660 Deprecate analytics component
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy merged PR #1361:
URL: https://github.com/apache/solr/pull/1361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a diff in pull request #1361: SOLR-16660 Deprecate analytics component
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on code in PR #1361:
URL: https://github.com/apache/solr/pull/1361#discussion_r1108816697
##########
solr/solr-ref-guide/modules/query-guide/pages/analytics-mapping-functions.adoc:
##########
@@ -18,6 +18,8 @@
Mapping functions map values for each Solr Document or Reduction.
+WARNING: The analytics component is deprecated. We recommend looking into similar functionality found in xref:json-facet-api.adoc[JSON Facet API].
Review Comment:
Yea, or ask them to write to users list, where we can qualify that there is in fact a need? Jira is invite-only so not a good experience for users to end up there and be able to do nothing 😕.
Feel free to suggest some text and I’ll incorporate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on a diff in pull request #1361: SOLR-16660 Deprecate analytics component
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on code in PR #1361:
URL: https://github.com/apache/solr/pull/1361#discussion_r1114042387
##########
solr/solr-ref-guide/modules/query-guide/pages/analytics-mapping-functions.adoc:
##########
@@ -18,6 +18,8 @@
Mapping functions map values for each Solr Document or Reduction.
+WARNING: The analytics component is deprecated. We recommend looking into similar functionality found in xref:json-facet-api.adoc[JSON Facet API].
Review Comment:
Looks good to me, thanks for doing it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a diff in pull request #1361: SOLR-16660 Deprecate analytics component
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on code in PR #1361:
URL: https://github.com/apache/solr/pull/1361#discussion_r1113185276
##########
solr/solr-ref-guide/modules/query-guide/pages/analytics-mapping-functions.adoc:
##########
@@ -18,6 +18,8 @@
Mapping functions map values for each Solr Document or Reduction.
+WARNING: The analytics component is deprecated. We recommend looking into similar functionality found in xref:json-facet-api.adoc[JSON Facet API].
Review Comment:
```suggestion
WARNING: The analytics component is deprecated. We recommend looking into similar functionality found in xref:json-facet-api.adoc[JSON Facet API]. Please notify the project if there's functionality you need that isn't currently covered by JSON facets.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on a diff in pull request #1361: SOLR-16660 Deprecate analytics component
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on code in PR #1361:
URL: https://github.com/apache/solr/pull/1361#discussion_r1108747250
##########
solr/solr-ref-guide/modules/query-guide/pages/analytics-mapping-functions.adoc:
##########
@@ -18,6 +18,8 @@
Mapping functions map values for each Solr Document or Reduction.
+WARNING: The analytics component is deprecated. We recommend looking into similar functionality found in xref:json-facet-api.adoc[JSON Facet API].
Review Comment:
Maybe we should link to JIRA and say create a ticket if there's functionality you need that isn't covered by JSON facets?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org