[GitHub] spark pull request #13941: [SPARK-16249][ML] Change visibility of Object ml....

[MLnick <gi...@git.apache.org>]

Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13941#discussion_r69618174
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
    @@ -880,11 +880,13 @@ class LDA @Since("1.6.0") (
       }
     }
     
    -
    -private[clustering] object LDA extends DefaultParamsReadable[LDA] {
    +@Since("2.0.0")
    +object LDA extends DefaultParamsReadable[LDA] {
    --- End diff --
    
    yeah, seems we have generally had `load` be since the version that model loading was actually added for that model? e.g. I see that is the case for tree models etc


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org