You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ilya Pronin <ip...@twopensource.com> on 2017/08/29 12:51:44 UTC

Review Request 61965: Moved `--zk_session_timeout` flag docs to the common flags section.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61965/
-----------------------------------------------------------

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-7895
    https://issues.apache.org/jira/browse/MESOS-7895


Repository: mesos


Description
-------

Mesos agents now accept this flag.


Diffs
-----

  docs/configuration.md 9cadf0f7559a3aeba3f35477e8f7eac67d3fa5cf 


Diff: https://reviews.apache.org/r/61965/diff/1/


Testing
-------

N/A


Thanks,

Ilya Pronin

Re: Review Request 61965: Moved `--zk_session_timeout` flag docs to the common flags section.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61965/#review184127
-----------------------------------------------------------


Ship it!




Ship It!

- Jiang Yan Xu


On Aug. 29, 2017, 5:51 a.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61965/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2017, 5:51 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7895
>     https://issues.apache.org/jira/browse/MESOS-7895
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Mesos agents now accept this flag.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 9cadf0f7559a3aeba3f35477e8f7eac67d3fa5cf 
> 
> 
> Diff: https://reviews.apache.org/r/61965/diff/1/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>

Re: Review Request 61965: Moved `--zk_session_timeout` flag docs to the common flags section.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.

> On Aug. 29, 2017, 7:14 a.m., Mesos Reviewbot Windows wrote:
> > Bad patch!
> > 
> > Reviews applied: [61689, 61690, 61965]
> > 
> > Logs available here: http://104.210.40.105/logs/master/61965
> 
> Ilya Pronin wrote:
>     No space left on the build host:
>     ```
>     (ClCompile target) ->
>       C:\mesos\build\master\61965\mesos\src\master\master.cpp(9865): fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp\2_CL_cc2c1dd7gl': No space left on device [C:\mesos\build\master\61965\build\src\mesos-1.5.0.vcxproj]
>       C:\mesos\build\master\61965\mesos\src\scheduler\scheduler.cpp(878): fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp\2_CL_c70ddc2fgl': No space left on device [C:\mesos\build\master\61965\build\src\mesos-1.5.0.vcxproj]
>       C:\mesos\build\master\61965\mesos\src\uri\fetchers\curl.cpp(177): fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp\2_CL_de54a61agl': No space left on device [C:\mesos\build\master\61965\build\src\mesos-1.5.0.vcxproj]
>       C:\mesos\build\master\61965\mesos\src\slave\containerizer\mesos\isolators\filesystem\posix.cpp(290): error C2471: cannot update program database 'C:\mesos\build\master\61965\build\src\mesos-1.5.0.dir\Debug\mesos-1.5.0.pdb' [C:\mesos\build\master\61965\build\src\mesos-1.5.0.vcxproj]
>       C:\mesos\build\master\61965\mesos\src\slave\containerizer\mesos\isolators\environment_secret.cpp(139): fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp\2_CL_886abca7sy': No space left on device [C:\mesos\build\master\61965\build\src\mesos-1.5.0.vcxproj]
>       C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\include\tuple(423): fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp\2_CL_838792afex': No space left on device (compiling source file C:\mesos\build\master\61965\mesos\src\zookeeper\group.cpp) [C:\mesos\build\master\61965\build\src\mesos-1.5.0.vcxproj]
>     
>         193 Warning(s)
>         6 Error(s)
>     ```

Ah, interesting. I've emailed Mihai about it.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61965/#review184049
-----------------------------------------------------------


On Aug. 29, 2017, 5:51 a.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61965/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2017, 5:51 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7895
>     https://issues.apache.org/jira/browse/MESOS-7895
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Mesos agents now accept this flag.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 9cadf0f7559a3aeba3f35477e8f7eac67d3fa5cf 
> 
> 
> Diff: https://reviews.apache.org/r/61965/diff/1/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>

Re: Review Request 61965: Moved `--zk_session_timeout` flag docs to the common flags section.

Posted by Ilya Pronin <ip...@twopensource.com>.

> On Aug. 29, 2017, 3:14 p.m., Mesos Reviewbot Windows wrote:
> > Bad patch!
> > 
> > Reviews applied: [61689, 61690, 61965]
> > 
> > Logs available here: http://104.210.40.105/logs/master/61965

No space left on the build host:
```
(ClCompile target) ->
  C:\mesos\build\master\61965\mesos\src\master\master.cpp(9865): fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp\2_CL_cc2c1dd7gl': No space left on device [C:\mesos\build\master\61965\build\src\mesos-1.5.0.vcxproj]
  C:\mesos\build\master\61965\mesos\src\scheduler\scheduler.cpp(878): fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp\2_CL_c70ddc2fgl': No space left on device [C:\mesos\build\master\61965\build\src\mesos-1.5.0.vcxproj]
  C:\mesos\build\master\61965\mesos\src\uri\fetchers\curl.cpp(177): fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp\2_CL_de54a61agl': No space left on device [C:\mesos\build\master\61965\build\src\mesos-1.5.0.vcxproj]
  C:\mesos\build\master\61965\mesos\src\slave\containerizer\mesos\isolators\filesystem\posix.cpp(290): error C2471: cannot update program database 'C:\mesos\build\master\61965\build\src\mesos-1.5.0.dir\Debug\mesos-1.5.0.pdb' [C:\mesos\build\master\61965\build\src\mesos-1.5.0.vcxproj]
  C:\mesos\build\master\61965\mesos\src\slave\containerizer\mesos\isolators\environment_secret.cpp(139): fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp\2_CL_886abca7sy': No space left on device [C:\mesos\build\master\61965\build\src\mesos-1.5.0.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\include\tuple(423): fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\mesos\AppData\Local\Temp\2_CL_838792afex': No space left on device (compiling source file C:\mesos\build\master\61965\mesos\src\zookeeper\group.cpp) [C:\mesos\build\master\61965\build\src\mesos-1.5.0.vcxproj]

    193 Warning(s)
    6 Error(s)
```


- Ilya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61965/#review184049
-----------------------------------------------------------


On Aug. 29, 2017, 1:51 p.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61965/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2017, 1:51 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7895
>     https://issues.apache.org/jira/browse/MESOS-7895
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Mesos agents now accept this flag.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 9cadf0f7559a3aeba3f35477e8f7eac67d3fa5cf 
> 
> 
> Diff: https://reviews.apache.org/r/61965/diff/1/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>

Re: Review Request 61965: Moved `--zk_session_timeout` flag docs to the common flags section.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61965/#review184049
-----------------------------------------------------------



Bad patch!

Reviews applied: [61689, 61690, 61965]

Logs available here: http://104.210.40.105/logs/master/61965

- Mesos Reviewbot Windows


On Aug. 29, 2017, 5:51 a.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61965/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2017, 5:51 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7895
>     https://issues.apache.org/jira/browse/MESOS-7895
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Mesos agents now accept this flag.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 9cadf0f7559a3aeba3f35477e8f7eac67d3fa5cf 
> 
> 
> Diff: https://reviews.apache.org/r/61965/diff/1/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>