You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Hongze Zhang (JIRA)" <ji...@apache.org> on 2019/02/25 15:09:00 UTC
[jira] [Assigned] (CALCITE-2838) Simplification: Remove redundant
IS TRUE checks
[ https://issues.apache.org/jira/browse/CALCITE-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hongze Zhang reassigned CALCITE-2838:
-------------------------------------
Assignee: Hongze Zhang (was: Zoltan Haindrich)
> Simplification: Remove redundant IS TRUE checks
> -----------------------------------------------
>
> Key: CALCITE-2838
> URL: https://issues.apache.org/jira/browse/CALCITE-2838
> Project: Calcite
> Issue Type: Improvement
> Reporter: Zoltan Haindrich
> Assignee: Hongze Zhang
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.19.0
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> In case simplifcation is already processing in unknownAsFalse mode, {{expr IS TRUE}} is redundant - and may just prevent further optimizations from happening:
> {code}
> @Test public void testRedundantIsTrue() {
> // in case of unknownAsFalse
> // x is TRUE <=> x
> checkSimplify3(isTrue(vBool(1)),
> "IS TRUE(?0.bool1)",
> "?0.bool1",
> "IS TRUE(?0.bool1)");
> }
> {code}
> there are some further possibilities
> {code}
> (unknownAsTrue) x is NOT FALSE <=> x
> (unknownAsTrue) x is FALSE <=> not x
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: [jira] [Assigned] (CALCITE-2838) Simplification: Remove redundant
IS TRUE checks
Posted by Zoltan Haindrich <ki...@rxd.hu>.
No worries; I sometimes also do it by mistake.
Jira even have a hotkey(i) for "assign to me" which is very annoying
cheers,
Zoltan
On 2/25/19 4:15 PM, Hongze Zhang wrote:
> Sorry for making the wrong operation, Zoltan. I’ve reassigned the issue to you.
>
>
> Hongze
>
>> On Feb 25, 2019, at 23:09, Hongze Zhang (JIRA) <ji...@apache.org> wrote:
>>
>>
>> [ https://issues.apache.org/jira/browse/CALCITE-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> Hongze Zhang reassigned CALCITE-2838:
>> -------------------------------------
>>
>> Assignee: Hongze Zhang (was: Zoltan Haindrich)
>>
>>> Simplification: Remove redundant IS TRUE checks
>>> -----------------------------------------------
>>>
>>> Key: CALCITE-2838
>>> URL: https://issues.apache.org/jira/browse/CALCITE-2838
>>> Project: Calcite
>>> Issue Type: Improvement
>>> Reporter: Zoltan Haindrich
>>> Assignee: Hongze Zhang
>>> Priority: Blocker
>>> Labels: pull-request-available
>>> Fix For: 1.19.0
>>>
>>> Time Spent: 2h 50m
>>> Remaining Estimate: 0h
>>>
>>> In case simplifcation is already processing in unknownAsFalse mode, {{expr IS TRUE}} is redundant - and may just prevent further optimizations from happening:
>>> {code}
>>> @Test public void testRedundantIsTrue() {
>>> // in case of unknownAsFalse
>>> // x is TRUE <=> x
>>> checkSimplify3(isTrue(vBool(1)),
>>> "IS TRUE(?0.bool1)",
>>> "?0.bool1",
>>> "IS TRUE(?0.bool1)");
>>> }
>>> {code}
>>> there are some further possibilities
>>> {code}
>>> (unknownAsTrue) x is NOT FALSE <=> x
>>> (unknownAsTrue) x is FALSE <=> not x
>>> {code}
>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v7.6.3#76005)
>
Re: [jira] [Assigned] (CALCITE-2838) Simplification: Remove redundant
IS TRUE checks
Posted by Hongze Zhang <no...@126.com>.
Sorry for making the wrong operation, Zoltan. I’ve reassigned the issue to you.
Hongze
> On Feb 25, 2019, at 23:09, Hongze Zhang (JIRA) <ji...@apache.org> wrote:
>
>
> [ https://issues.apache.org/jira/browse/CALCITE-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Hongze Zhang reassigned CALCITE-2838:
> -------------------------------------
>
> Assignee: Hongze Zhang (was: Zoltan Haindrich)
>
>> Simplification: Remove redundant IS TRUE checks
>> -----------------------------------------------
>>
>> Key: CALCITE-2838
>> URL: https://issues.apache.org/jira/browse/CALCITE-2838
>> Project: Calcite
>> Issue Type: Improvement
>> Reporter: Zoltan Haindrich
>> Assignee: Hongze Zhang
>> Priority: Blocker
>> Labels: pull-request-available
>> Fix For: 1.19.0
>>
>> Time Spent: 2h 50m
>> Remaining Estimate: 0h
>>
>> In case simplifcation is already processing in unknownAsFalse mode, {{expr IS TRUE}} is redundant - and may just prevent further optimizations from happening:
>> {code}
>> @Test public void testRedundantIsTrue() {
>> // in case of unknownAsFalse
>> // x is TRUE <=> x
>> checkSimplify3(isTrue(vBool(1)),
>> "IS TRUE(?0.bool1)",
>> "?0.bool1",
>> "IS TRUE(?0.bool1)");
>> }
>> {code}
>> there are some further possibilities
>> {code}
>> (unknownAsTrue) x is NOT FALSE <=> x
>> (unknownAsTrue) x is FALSE <=> not x
>> {code}
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)