You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Reuben Kuhnert <si...@gmail.com> on 2015/05/04 21:05:15 UTC
Review Request 33816: HIVE-10597: Relative path doesn't work with
CREATE TABLE LOCATION 'relative/path'
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33816/
-----------------------------------------------------------
Review request for hive and Sergio Pena.
Bugs: HIVE-10597
https://issues.apache.org/jira/browse/HIVE-10597
Repository: hive-git
Description
-------
Allow warehouse to work with relative locations.
Diffs
-----
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 25119abf97382df7c0615edbaff29ba20624a137
Diff: https://reviews.apache.org/r/33816/diff/
Testing
-------
Tested locally
Thanks,
Reuben Kuhnert
Re: Review Request 33816: HIVE-10597: Relative path doesn't work with
CREATE TABLE LOCATION 'relative/path'
Posted by Reuben Kuhnert <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33816/#review82818
-----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java
<https://reviews.apache.org/r/33816/#comment133647>
Originally I used the warehouse home directory as the base for relative paths. However, per Lenni's comment, it sounds like it's best to throw an exception if the user tries to use a anything other than an absolute path.
- Reuben Kuhnert
On May 5, 2015, 3:14 p.m., Reuben Kuhnert wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33816/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 3:14 p.m.)
>
>
> Review request for hive and Sergio Pena.
>
>
> Bugs: HIVE-10597
> https://issues.apache.org/jira/browse/HIVE-10597
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Allow warehouse to work with relative locations.
>
>
> Diffs
> -----
>
> metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 25119abf97382df7c0615edbaff29ba20624a137
> metastore/src/test/org/apache/hadoop/hive/metastore/TestWarehouse.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33816/diff/
>
>
> Testing
> -------
>
> Tested locally
>
>
> Thanks,
>
> Reuben Kuhnert
>
>
Re: Review Request 33816: HIVE-10597: Relative path doesn't work with
CREATE TABLE LOCATION 'relative/path'
Posted by Sergio Pena <se...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33816/#review82749
-----------------------------------------------------------
Can you add a q-test file where you test this scenario?
- Sergio Pena
On May 5, 2015, 3:14 p.m., Reuben Kuhnert wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33816/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 3:14 p.m.)
>
>
> Review request for hive and Sergio Pena.
>
>
> Bugs: HIVE-10597
> https://issues.apache.org/jira/browse/HIVE-10597
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Allow warehouse to work with relative locations.
>
>
> Diffs
> -----
>
> metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 25119abf97382df7c0615edbaff29ba20624a137
> metastore/src/test/org/apache/hadoop/hive/metastore/TestWarehouse.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33816/diff/
>
>
> Testing
> -------
>
> Tested locally
>
>
> Thanks,
>
> Reuben Kuhnert
>
>
Re: Review Request 33816: HIVE-10597: Relative path doesn't work with
CREATE TABLE LOCATION 'relative/path'
Posted by Reuben Kuhnert <si...@gmail.com>.
> On May 7, 2015, 1:03 a.m., cheng xu wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java, line 143
> > <https://reviews.apache.org/r/33816/diff/2/?file=950357#file950357line143>
> >
> > Will this patch work with relative path? Seems only a check added.
Originally I used the warehouse home directory as the base for relative paths. However, per Lenni's comment, it sounds like it's best to throw an exception if the user tries to use a anything other than an absolute path.
- Reuben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33816/#review82781
-----------------------------------------------------------
On May 5, 2015, 3:14 p.m., Reuben Kuhnert wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33816/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 3:14 p.m.)
>
>
> Review request for hive and Sergio Pena.
>
>
> Bugs: HIVE-10597
> https://issues.apache.org/jira/browse/HIVE-10597
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Allow warehouse to work with relative locations.
>
>
> Diffs
> -----
>
> metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 25119abf97382df7c0615edbaff29ba20624a137
> metastore/src/test/org/apache/hadoop/hive/metastore/TestWarehouse.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33816/diff/
>
>
> Testing
> -------
>
> Tested locally
>
>
> Thanks,
>
> Reuben Kuhnert
>
>
Re: Review Request 33816: HIVE-10597: Relative path doesn't work with
CREATE TABLE LOCATION 'relative/path'
Posted by cheng xu <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33816/#review82781
-----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java
<https://reviews.apache.org/r/33816/#comment133598>
Will this patch work with relative path? Seems only a check added.
- cheng xu
On May 5, 2015, 3:14 p.m., Reuben Kuhnert wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33816/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 3:14 p.m.)
>
>
> Review request for hive and Sergio Pena.
>
>
> Bugs: HIVE-10597
> https://issues.apache.org/jira/browse/HIVE-10597
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Allow warehouse to work with relative locations.
>
>
> Diffs
> -----
>
> metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 25119abf97382df7c0615edbaff29ba20624a137
> metastore/src/test/org/apache/hadoop/hive/metastore/TestWarehouse.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33816/diff/
>
>
> Testing
> -------
>
> Tested locally
>
>
> Thanks,
>
> Reuben Kuhnert
>
>
Re: Review Request 33816: HIVE-10597: Relative path doesn't work with
CREATE TABLE LOCATION 'relative/path'
Posted by Reuben Kuhnert <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33816/
-----------------------------------------------------------
(Updated 5 5, 2015, 3:14 오후)
Review request for hive and Sergio Pena.
Changes
-------
Updated diff to throw exceptions on relative path, also updated comments and added unit tests.
Bugs: HIVE-10597
https://issues.apache.org/jira/browse/HIVE-10597
Repository: hive-git
Description
-------
Allow warehouse to work with relative locations.
Diffs (updated)
-----
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 25119abf97382df7c0615edbaff29ba20624a137
metastore/src/test/org/apache/hadoop/hive/metastore/TestWarehouse.java PRE-CREATION
Diff: https://reviews.apache.org/r/33816/diff/
Testing
-------
Tested locally
Thanks,
Reuben Kuhnert
Re: Review Request 33816: HIVE-10597: Relative path doesn't work with
CREATE TABLE LOCATION 'relative/path'
Posted by Reuben Kuhnert <si...@gmail.com>.
> On May 4, 2015, 9:03 p.m., Sergio Pena wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java, line 141
> > <https://reviews.apache.org/r/33816/diff/1/?file=949031#file949031line141>
> >
> > does this line handle the relative path correctly?
This code works correctly.
- Reuben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33816/#review82440
-----------------------------------------------------------
On May 5, 2015, 3:14 p.m., Reuben Kuhnert wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33816/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 3:14 p.m.)
>
>
> Review request for hive and Sergio Pena.
>
>
> Bugs: HIVE-10597
> https://issues.apache.org/jira/browse/HIVE-10597
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Allow warehouse to work with relative locations.
>
>
> Diffs
> -----
>
> metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 25119abf97382df7c0615edbaff29ba20624a137
> metastore/src/test/org/apache/hadoop/hive/metastore/TestWarehouse.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33816/diff/
>
>
> Testing
> -------
>
> Tested locally
>
>
> Thanks,
>
> Reuben Kuhnert
>
>
Re: Review Request 33816: HIVE-10597: Relative path doesn't work with
CREATE TABLE LOCATION 'relative/path'
Posted by Sergio Pena <se...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33816/#review82440
-----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java
<https://reviews.apache.org/r/33816/#comment133179>
does this line handle the relative path correctly?
- Sergio Pena
On May 4, 2015, 7:05 p.m., Reuben Kuhnert wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33816/
> -----------------------------------------------------------
>
> (Updated May 4, 2015, 7:05 p.m.)
>
>
> Review request for hive and Sergio Pena.
>
>
> Bugs: HIVE-10597
> https://issues.apache.org/jira/browse/HIVE-10597
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Allow warehouse to work with relative locations.
>
>
> Diffs
> -----
>
> metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 25119abf97382df7c0615edbaff29ba20624a137
>
> Diff: https://reviews.apache.org/r/33816/diff/
>
>
> Testing
> -------
>
> Tested locally
>
>
> Thanks,
>
> Reuben Kuhnert
>
>
Re: Review Request 33816: HIVE-10597: Relative path doesn't work with
CREATE TABLE LOCATION 'relative/path'
Posted by Lenni Kuff <ls...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33816/#review82466
-----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java
<https://reviews.apache.org/r/33816/#comment133201>
Update comment to explain behavior of absolute vs relative paths.
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java
<https://reviews.apache.org/r/33816/#comment133204>
I don't think we want to handle relative paths for this particular bug - instead throw an error. Since this function is called in multiple places, be sure nothing else is expected to work with relative paths.
Please add test case(s) as well
- Lenni Kuff
On May 4, 2015, 7:05 p.m., Reuben Kuhnert wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33816/
> -----------------------------------------------------------
>
> (Updated May 4, 2015, 7:05 p.m.)
>
>
> Review request for hive and Sergio Pena.
>
>
> Bugs: HIVE-10597
> https://issues.apache.org/jira/browse/HIVE-10597
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Allow warehouse to work with relative locations.
>
>
> Diffs
> -----
>
> metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 25119abf97382df7c0615edbaff29ba20624a137
>
> Diff: https://reviews.apache.org/r/33816/diff/
>
>
> Testing
> -------
>
> Tested locally
>
>
> Thanks,
>
> Reuben Kuhnert
>
>