You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm-commits@maven.apache.org by ev...@apache.org on 2007/04/24 18:09:23 UTC

svn commit: r531994 - /maven/scm/trunk/maven-scm-providers/maven-scm-providers-cvs/maven-scm-provider-cvsjava/src/main/java/org/apache/maven/scm/provider/cvslib/cvsjava/util/CvsConnection.java

Author: evenisse
Date: Tue Apr 24 09:09:22 2007
New Revision: 531994

URL: http://svn.apache.org/viewvc?view=rev&rev=531994
Log:
[SCM-300] Close connection at the end of the command execution

Modified:
    maven/scm/trunk/maven-scm-providers/maven-scm-providers-cvs/maven-scm-provider-cvsjava/src/main/java/org/apache/maven/scm/provider/cvslib/cvsjava/util/CvsConnection.java

Modified: maven/scm/trunk/maven-scm-providers/maven-scm-providers-cvs/maven-scm-provider-cvsjava/src/main/java/org/apache/maven/scm/provider/cvslib/cvsjava/util/CvsConnection.java
URL: http://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-providers/maven-scm-providers-cvs/maven-scm-provider-cvsjava/src/main/java/org/apache/maven/scm/provider/cvslib/cvsjava/util/CvsConnection.java?view=diff&rev=531994&r1=531993&r2=531994
==============================================================================
--- maven/scm/trunk/maven-scm-providers/maven-scm-providers-cvs/maven-scm-provider-cvsjava/src/main/java/org/apache/maven/scm/provider/cvslib/cvsjava/util/CvsConnection.java (original)
+++ maven/scm/trunk/maven-scm-providers/maven-scm-providers-cvs/maven-scm-provider-cvsjava/src/main/java/org/apache/maven/scm/provider/cvslib/cvsjava/util/CvsConnection.java Tue Apr 24 09:09:22 2007
@@ -167,6 +167,21 @@
         client.setLocalPath( localPath );
     }
 
+    private void disconnect()
+    {
+        if ( connection != null && connection.isOpen() )
+        {
+            try
+            {
+                connection.close();
+            }
+            catch ( IOException e )
+            {
+                //ignore
+            }
+        }
+    }
+
     private void addListener( CVSListener listener )
     {
         if ( client != null )
@@ -460,6 +475,8 @@
         cvsCommand.connect( root, password );
         cvsCommand.addListener( listener );
         logger.debug( "Executing CVS command: " + c.getCVSCommand() );
-        return cvsCommand.executeCommand( c );
+        boolean result = cvsCommand.executeCommand( c );
+        cvsCommand.disconnect();
+        return result;
     }
 }