[GitHub] [flink] hequn8128 commented on a change in pull request #13066: [FLINK-18765][python] Support map() and flat_map() for Python DataStream API.

[GitBox <gi...@apache.org>]

hequn8128 commented on a change in pull request #13066:
URL: https://github.com/apache/flink/pull/13066#discussion_r465607850



##########
File path: flink-python/pyflink/proto/flink-fn-execution.proto
##########
@@ -147,3 +163,50 @@ message Schema {
 
   repeated Field fields = 1;
 }
+
+// A representation of the data type information of a data stream.
+message TypeInfo {

Review comment:
       Please remove the useless type, e.g., VOID, LOCAL_DATE, etc.

##########
File path: flink-python/pyflink/fn_execution/operation_utils.py
##########
@@ -20,11 +20,13 @@
 import cloudpickle
 from typing import Any, Tuple, Dict, List
 
+from pyflink.fn_execution import flink_fn_execution_pb2
 from pyflink.serializers import PickleSerializer
 from pyflink.table.udf import DelegationTableFunction, DelegatingScalarFunction
 
 SCALAR_FUNCTION_URN = "flink:transform:scalar_function:v1"
 TABLE_FUNCTION_URN = "flink:transform:table_function:v1"
+DATA_STREAM_FUNCTION_URN = "flink:transform:datastream_stateless_function:v1"

Review comment:
       DATA_STREAM_STATELESS_FUNCTION_URN?

##########
File path: flink-python/pyflink/proto/flink-fn-execution.proto
##########
@@ -52,6 +52,22 @@ message UserDefinedFunctions {
   bool metric_enabled = 2;
 }
 
+// User defined data stream function definition.

Review comment:
       data stream => DataStream. And for other places. 

##########
File path: flink-python/pyflink/fn_execution/coders.py
##########
@@ -271,6 +309,21 @@ def __init__(self, precision, scale):
     def get_impl(self):
         return coder_impl.DecimalCoderImpl(self.precision, self.scale)
 
+    def get_slow_impl(self):
+        return coder_impl_slow.DecimalCoderImpl(self.precision, self.scale)
+
+
+class BasicDecimalCoder(FieldCoder):

Review comment:
       Rename to `BigDecimalCoder`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org