You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Stefan Bodewig <bo...@apache.org> on 2004/03/23 08:40:03 UTC

[GUMP][PATCH] Add avalon-framework impl classes

Hi,

I currently don't understand why Gump on LSD thinks Cocoon would
depend on avalon-fortress-container, but the Gump instance on
covalent.net tries to build it[1].

The build fails since Cocoon only states a dependency on the
avalon-framework API but uses implementation classes as well[2].

The appended patch should fix that.

Cheers

        Stefan


Footnotes: 
[1]  http://gump.covalent.net/log/cocoon.html

[2]  http://marc.theaimsgroup.com/?l=avalon-dev&m=107961713821764&w=2

-- 
http://stefanbodewig.blogger.de/

Index: gump.xml
===================================================================
RCS file: /home/cvspublic/cocoon-2.1/gump.xml,v
retrieving revision 1.127
diff -u -r1.127 gump.xml
--- gump.xml	20 Mar 2004 01:50:59 -0000	1.127
+++ gump.xml	23 Mar 2004 07:27:44 -0000
@@ -38,7 +38,7 @@
     <ant target="gump-core">
       <property name="version" value="@@DATE@@"/>
       <depend property="logkit.jar" project="dist-avalon-logkit"/>
-      <depend property="avalonapi.jar" project="avalon"/>
+      <depend property="avalonapi.jar" project="avalon-framework" id="api"/>
     </ant>
 
     <depend project="ant" inherit="runtime"/>
@@ -47,6 +47,7 @@
     <depend project="xml-xalan2"/>
     <depend project="xml-commons-resolver"/>
 
+    <depend project="avalon-framework" ids="impl"/>
     <depend project="excalibur-compatibility"/>
     <depend project="excalibur-instrument"/>
     <depend project="excalibur-instrument-manager"/>

Re: [GUMP][PATCH] Add avalon-framework impl classes

Posted by Stefan Bodewig <bo...@apache.org>.
On Tue, 23 Mar 2004, Adam Jack <aj...@trysybase.com> wrote:

> I wonder if we need to present 'dependency paths' (at least from
> cause to project, if not between all projects) either as lists or
> (help willing) visual graphs.

That would help a lot.  Many people will probably be very surprised
what their project indirectly depends on.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org


Re: [GUMP][PATCH] Add avalon-framework impl classes

Posted by Adam Jack <aj...@TrySybase.com>.
> On Tue, 23 Mar 2004, Adam Jack <aj...@trysybase.com> wrote:
>
> > It seems to me that cocoon depends upon xmlutil:
>
> The dependency is there - see later that thread - I just didn't see it
> since I missed that xmlutils depended on meta-sourceresolve and not on
> sourceresolve (which has no fortress dependency).
>
> Sorry about the confusion

Don't be. If a Gumpmeastro like yourself misses something, with your
view/knowledge/interpretation of Gump metadata, then what changes do mere
mortal Gumpmeisters have? I wonder if we need to present 'dependency paths'
(at least from cause to project, if not between all projects) either as
lists or (help willing) visual graphs. [Perhaps the latter is something that
Stefano had in mind when he commented he felt Gump ought no longer be a
static webapp, or perhaps is something we should have in mind.]

regards,

Adam


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org


Re: [GUMP][PATCH] Add avalon-framework impl classes

Posted by Stefan Bodewig <bo...@apache.org>.
On Tue, 23 Mar 2004, Adam Jack <aj...@trysybase.com> wrote:

> It seems to me that cocoon depends upon xmlutil:

The dependency is there - see later that thread - I just didn't see it
since I missed that xmlutils depended on meta-sourceresolve and not on
sourceresolve (which has no fortress dependency).

Sorry about the confusion

      Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org


Re: [GUMP][PATCH] Add avalon-framework impl classes

Posted by Adam Jack <aj...@TrySybase.com>.
> I currently don't understand why Gump on LSD thinks Cocoon would
> depend on avalon-fortress-container, but the Gump instance on
> covalent.net tries to build it[1].

I wonder if the removal of the 'full dependencies' and 'full dependees'
tables (on 'working projects') is a good thing or not. It might be nice in
this case.

It seems to me that cocoon depends upon xmlutil:

http://lsd.student.utwente.nl/gump/cocoon-2.1/cocoon.html#Project+Dependenci
es

and excalibur-xmlutil depends upon avalon-fortress-container:

http://lsd.student.utwente.nl/gump/avalon-excalibur/excalibur-xmlutil.html

... however (unfortunately) without the full depends information the trail
goes somewhat cold.

Luckily we can follow the pre-req fails:

    excalibur-meta-sourceresolve
    avalon-fortress-tools
    avalon-fortress-container

We need a nicer way to determine this path.

Looking at this list I see the dependency is runtime, not compile time. I'm
not awake enough to determine if it is misguided (or not) to set this as
pre-requisite failed or not. Thoughts?

regards,

Adam


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org


Re: [GUMP][PATCH] Add avalon-framework impl classes

Posted by Stefan Bodewig <bo...@apache.org>.
On Tue, 23 Mar 2004, Stefan Bodewig <bo...@apache.org> wrote:

> and then add meta-sourceresolve as a deprecated alternative name.

Turns out that it wasn't necessary at all since only two other
excalibur packages depended on meta-sourceresolve.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org


Re: [GUMP][PATCH] Add avalon-framework impl classes

Posted by Stefan Bodewig <bo...@apache.org>.
On Tue, 23 Mar 2004, Stefan Bodewig <bo...@apache.org> wrote:

> and then add meta-sourceresolve as a deprecated alternative name.

Turns out that it wasn't necessary at all since only two other
excalibur packages depended on meta-sourceresolve.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org


Re: [GUMP][PATCH] Add avalon-framework impl classes

Posted by Stefan Bodewig <bo...@apache.org>.
On Tue, 23 Mar 2004, Stephen McConnell <mc...@apache.org> wrote:

> Stefan Bodewig wrote:
>> Right now I'd probably replace excalibur-meta-sourceresolve with
>> excalibur-sourceresolve all over the place.
> 
> +1
> 
> We were thinking the same thing.
> I'm cc'ing dev@avalon just for reference.

Cool, I'll just go ahead and modify all descriptors I can touch - and
then add meta-sourceresolve as a deprecated alternative name.

Stefan

-- 
http://stefanbodewig.blogger.de/

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org


Re: [GUMP][PATCH] Add avalon-framework impl classes

Posted by Stefan Bodewig <bo...@apache.org>.
On Tue, 23 Mar 2004, Stephen McConnell <mc...@apache.org> wrote:

> Stefan Bodewig wrote:
>> Right now I'd probably replace excalibur-meta-sourceresolve with
>> excalibur-sourceresolve all over the place.
> 
> +1
> 
> We were thinking the same thing.
> I'm cc'ing dev@avalon just for reference.

Cool, I'll just go ahead and modify all descriptors I can touch - and
then add meta-sourceresolve as a deprecated alternative name.

Stefan

-- 
http://stefanbodewig.blogger.de/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org


Re: [GUMP][PATCH] Add avalon-framework impl classes

Posted by Stephen McConnell <mc...@apache.org>.
Stefan Bodewig wrote:

> On Tue, 23 Mar 2004, Stefan Bodewig <bo...@apache.org> wrote:
> 
> 
>>I'll simply try whether meta-sourceresolve builds without
>>fortress-tools to see whether it is unneeded here as well.
> 
> 
> I think I need your help here, Stephen.
> 
> excalibur-sourceresolve and excalibur-meta-sourceresolve compile the
> same classes using the same build file and target and claim to produce
> exactly the same jars.  They only differ in their stated dependencies.
> 
> Are they the same project?  If so, we should probably drop
> meta-sourceresolve.
> 
> In "traditional" Gump, excalibur-xmlutils builds since Gump finds the
> jar produced by excalibur-sourceresolve.  Python Gump on the other
> hand "knows" that excalibur-meta-sourceresolve hasn't been built and
> this causes the pre-req failures upstream.
> 
> It turns out that xmlutils compiles just fine against the jar created
> by excalibur-sourceresolve - and so would Cocoon.  I'm puzzled.
> 
> Right now I'd probably replace excalibur-meta-sourceresolve with
> excalibur-sourceresolve all over the place.

+1

We were thinking the same thing.
I'm cc'ing dev@avalon just for reference.

Cheers, Stephen.



-- 

|------------------------------------------------|
| Magic by Merlin                                |
| Production by Avalon                           |
|                                                |
| http://avalon.apache.org/merlin                |
| http://dpml.net/merlin/distributions/latest    |
|------------------------------------------------|

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org


Re: [GUMP][PATCH] Add avalon-framework impl classes

Posted by Stephen McConnell <mc...@apache.org>.
Stefan Bodewig wrote:

> On Tue, 23 Mar 2004, Stefan Bodewig <bo...@apache.org> wrote:
> 
> 
>>I'll simply try whether meta-sourceresolve builds without
>>fortress-tools to see whether it is unneeded here as well.
> 
> 
> I think I need your help here, Stephen.
> 
> excalibur-sourceresolve and excalibur-meta-sourceresolve compile the
> same classes using the same build file and target and claim to produce
> exactly the same jars.  They only differ in their stated dependencies.
> 
> Are they the same project?  If so, we should probably drop
> meta-sourceresolve.
> 
> In "traditional" Gump, excalibur-xmlutils builds since Gump finds the
> jar produced by excalibur-sourceresolve.  Python Gump on the other
> hand "knows" that excalibur-meta-sourceresolve hasn't been built and
> this causes the pre-req failures upstream.
> 
> It turns out that xmlutils compiles just fine against the jar created
> by excalibur-sourceresolve - and so would Cocoon.  I'm puzzled.
> 
> Right now I'd probably replace excalibur-meta-sourceresolve with
> excalibur-sourceresolve all over the place.

+1

We were thinking the same thing.
I'm cc'ing dev@avalon just for reference.

Cheers, Stephen.



-- 

|------------------------------------------------|
| Magic by Merlin                                |
| Production by Avalon                           |
|                                                |
| http://avalon.apache.org/merlin                |
| http://dpml.net/merlin/distributions/latest    |
|------------------------------------------------|

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org


Re: [GUMP][PATCH] Add avalon-framework impl classes

Posted by Stefan Bodewig <bo...@apache.org>.
On Tue, 23 Mar 2004, Stefan Bodewig <bo...@apache.org> wrote:

> I'll simply try whether meta-sourceresolve builds without
> fortress-tools to see whether it is unneeded here as well.

I think I need your help here, Stephen.

excalibur-sourceresolve and excalibur-meta-sourceresolve compile the
same classes using the same build file and target and claim to produce
exactly the same jars.  They only differ in their stated dependencies.

Are they the same project?  If so, we should probably drop
meta-sourceresolve.

In "traditional" Gump, excalibur-xmlutils builds since Gump finds the
jar produced by excalibur-sourceresolve.  Python Gump on the other
hand "knows" that excalibur-meta-sourceresolve hasn't been built and
this causes the pre-req failures upstream.

It turns out that xmlutils compiles just fine against the jar created
by excalibur-sourceresolve - and so would Cocoon.  I'm puzzled.

Right now I'd probably replace excalibur-meta-sourceresolve with
excalibur-sourceresolve all over the place.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org


Re: [GUMP][PATCH] Add avalon-framework impl classes

Posted by Stefan Bodewig <bo...@apache.org>.
On Tue, 23 Mar 2004, Stephen McConnell <mc...@apache.org> wrote:

> I'm guessing its related to the following:
> 
>     cocoon --> excalibur-xmlutil -->
>        excalibur-meta-sourceresolve --> fortress (tools and
>        container)

Yes, I didn't see the "meta" when I looked at it.  See my other mail
on why it works for "traditional" Gump.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org


Re: [GUMP][PATCH] Add avalon-framework impl classes

Posted by Stephen McConnell <mc...@apache.org>.
Stefan Bodewig wrote:

> On Tue, 23 Mar 2004, Stephen McConnell <mc...@apache.org> wrote:
> 
> 
>>I'll be digging into the remaining cocoon/avalon dependencies this
>>week
> 
> 
> Thanks a lot.
> 
> 
>>That should get the coocoon depedencies green across the board.
> 
> 
> For the "old, traditional" Gump builds, they already are.  I can't see
> why there should be any dependency on fortress in Cocoon.  Cocoon
> doesn't state one and I don't see a path that would make it an
> inherited dependency.


I'm guessing its related to the following:

    cocoon --> excalibur-xmlutil -->
       excalibur-meta-sourceresolve --> fortress (tools and container)

And I figure that excalibur-xmlutil can probably be linked to the 
excalibur-sourceresolve thereby eliminating the fortress dependency.

Stephen.


-- 

|------------------------------------------------|
| Magic by Merlin                                |
| Production by Avalon                           |
|                                                |
| http://avalon.apache.org/merlin                |
| http://dpml.net/merlin/distributions/latest    |
|------------------------------------------------|

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org


Re: [GUMP][PATCH] Add avalon-framework impl classes

Posted by Stefan Bodewig <bo...@apache.org>.
On Tue, 23 Mar 2004, Stephen McConnell <mc...@apache.org> wrote:

> I'll be digging into the remaining cocoon/avalon dependencies this
> week

Thanks a lot.

> That should get the coocoon depedencies green across the board.

For the "old, traditional" Gump builds, they already are.  I can't see
why there should be any dependency on fortress in Cocoon.  Cocoon
doesn't state one and I don't see a path that would make it an
inherited dependency.

There is probably a piece in the dependency inference logic in the
Python rewrite that needs some more thought.

One thing I've noticed is that some projects stated dependencies on
fortress-tools but built without any problems if I removed this
dependency.  I'll simply try whether meta-sourceresolve builds without
fortress-tools to see whether it is unneeded here as well.

Cheers

        Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org


Re: [GUMP][PATCH] Add avalon-framework impl classes

Posted by Stephen McConnell <mc...@apache.org>.
Stefan Bodewig wrote:

> Hi,
> 
> I currently don't understand why Gump on LSD thinks Cocoon would
> depend on avalon-fortress-container, but the Gump instance on
> covalent.net tries to build it[1].
> 
> The build fails since Cocoon only states a dependency on the
> avalon-framework API but uses implementation classes as well[2].
> 
> The appended patch should fix that.

Steffan:

I'll be digging into the remaining cocoon/avalon dependencies this week 
- focussing on seperating fortress from some of the excalibur utilities. 
  That should get the coocoon depedencies green across the board.

Cheers, Stephen.

> Cheers
> 
>         Stefan
> 
> 
> Footnotes: 
> [1]  http://gump.covalent.net/log/cocoon.html
> 
> [2]  http://marc.theaimsgroup.com/?l=avalon-dev&m=107961713821764&w=2
> 


-- 

|------------------------------------------------|
| Magic by Merlin                                |
| Production by Avalon                           |
|                                                |
| http://avalon.apache.org/merlin                |
| http://dpml.net/merlin/distributions/latest    |
|------------------------------------------------|

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org