[GitHub] [superset] cemremengu commented on a diff in pull request #19810: feat(reports): xlsx attachments

["cemremengu (via GitHub)" <gi...@apache.org>]

cemremengu commented on code in PR #19810:
URL: https://github.com/apache/superset/pull/19810#discussion_r1089736889


##########
superset/reports/commands/execute.py:
##########
@@ -330,13 +332,25 @@ def _get_log_data(self) -> HeaderDataType:
         }
         return log_data
 
+    def _get_xlsx_data(self) -> bytes:
+        csv_data = self._get_csv_data()
+
+        df = pd.read_csv(BytesIO(csv_data))

Review Comment:
   I am a bit confused about this part. We are getting df in order to convert it to excel. 
   
   I mean if we already have df we can just convert to excel so what would the common method achieve? Could you provide more details?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org