You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/13 13:16:34 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #9520:
[api] refactor, remove unnecessary code, using command pattern now
dpgaspar opened a new pull request #9520: [api] refactor, remove unnecessary code, using command pattern now
URL: https://github.com/apache/incubator-superset/pull/9520
### CATEGORY
- [ ] Bug Fix
- [ ] Enhancement (new features, refinement)
- [X] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
All class API's that were using this already got migrated to use the new command pattern (SIP-35). This code is longer used and will not be necessary
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@willbarrett
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #9520: [api]
refactor, remove unnecessary code, using command pattern now
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #9520: [api] refactor, remove unnecessary code, using command pattern now
URL: https://github.com/apache/incubator-superset/pull/9520
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9520: [api]
refactor, remove unnecessary code, using command pattern now
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9520: [api] refactor, remove unnecessary code, using command pattern now
URL: https://github.com/apache/incubator-superset/pull/9520#issuecomment-612905711
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9520?src=pr&el=h1) Report
> Merging [#9520](https://codecov.io/gh/apache/incubator-superset/pull/9520?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/622561f7568a209327f6f16f93ac8b40f6bc1937&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9520?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9520 +/- ##
=======================================
Coverage 58.57% 58.57%
=======================================
Files 386 386
Lines 12287 12287
Branches 3025 3025
=======================================
Hits 7197 7197
Misses 4906 4906
Partials 184 184
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9520?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9520?src=pr&el=footer). Last update [622561f...7299f4a](https://codecov.io/gh/apache/incubator-superset/pull/9520?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org