You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/06/14 23:34:44 UTC

[GitHub] [gobblin] Will-Lo commented on a change in pull request #3311: [GOBBLIN-1472] toggle to control compaction MR output dir

Will-Lo commented on a change in pull request #3311:
URL: https://github.com/apache/gobblin/pull/3311#discussion_r651344799



##########
File path: gobblin-compaction/src/main/java/org/apache/gobblin/compaction/mapreduce/CompactionJobConfigurator.java
##########
@@ -249,6 +250,11 @@ protected boolean configureInputAndOutputPaths(Job job, FileSystemDataset datase
     CompactionPathParser.CompactionParserResult rst = parser.parse(dataset);
     this.mrOutputPath = concatPaths(mrOutputBase, rst.getDatasetName(), rst.getDstSubDir(), rst.getTimeString());
 
+    if(this.state.contains(ConfigurationKeys.USE_DATASET_LOCAL_WORK_DIR)) {
+      mrOutputBase = this.state.getProp(MRCompactor.COMPACTION_DEST_DIR);
+      String tmpDir = ".temp";

Review comment:
       Can we put this on ConfigurationKeys as a default, and possibly use this with the other configurations `STAGING_DIR_DEFAULT_SUFFIX`, `OUTPUT_DIR_DEFAULT_SUFFIX` 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org