You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dependabot[bot] (via GitHub)" <gi...@apache.org> on 2026/06/15 23:39:35 UTC
[PR] chore(deps-dev): update cx-oracle requirement from <8.4,>8.0.0 to >=8.3.0,<8.4 [superset]
dependabot[bot] opened a new pull request, #41088:
URL: https://github.com/apache/superset/pull/41088
Updates the requirements on [cx-oracle](https://github.com/oracle/python-cx_Oracle) to permit the latest version.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/oracle/python-cx_Oracle/releases">cx-oracle's releases</a>.</em></p>
<blockquote>
<h2>v8.3.0</h2>
<p>cx_Oracle 8.3 is now released. This release introduced official support for Python 3.10 and addressed a few small issues. See the <a href="https://cx-oracle.readthedocs.io/en/latest/release_notes.html#version-8-3-november-2021">full release notes</a> for all of the details.</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/oracle/python-cx_Oracle/commit/5728cf534e24319640b52ea0e93c5042fe210f22"><code>5728cf5</code></a> Try newer version of Sphinx.</li>
<li><a href="https://github.com/oracle/python-cx_Oracle/commit/3a40eeacaa1b469e11668fd3f4d121b232eb0fc6"><code>3a40eea</code></a> ReadTheDocs only supports up to Python 3.8.</li>
<li><a href="https://github.com/oracle/python-cx_Oracle/commit/fde9ec78fcd5ac2806c7a957bb3fd258d8fc34f7"><code>fde9ec7</code></a> ReadTheDocs requires configuration so make it happy.</li>
<li><a href="https://github.com/oracle/python-cx_Oracle/commit/45118e0c31397c7b475c22aa3156f361f8608419"><code>45118e0</code></a> Preparing to release cx_Oracle 8.3.</li>
<li><a href="https://github.com/oracle/python-cx_Oracle/commit/29ca919445eaa892826cdb95efe3ea8722890653"><code>29ca919</code></a> Add official support for Python 3.10.</li>
<li><a href="https://github.com/oracle/python-cx_Oracle/commit/ae687ce7361bd4029c1206607a4bfdfaa248b2f6"><code>ae687ce</code></a> Improve documentation for WHERE IN clauses.</li>
<li><a href="https://github.com/oracle/python-cx_Oracle/commit/2d33fec37a21ca191f27f212df9847c81098a6da"><code>2d33fec</code></a> Test suite improvements.</li>
<li><a href="https://github.com/oracle/python-cx_Oracle/commit/9db9d6907a1205a2df48e8d2243f7a12828aae10"><code>9db9d69</code></a> Batch loading documentation improvements.</li>
<li><a href="https://github.com/oracle/python-cx_Oracle/commit/00dc44eade49bb5268121dc9f8d1803bf87c552e"><code>00dc44e</code></a> Update ODPI-C.</li>
<li><a href="https://github.com/oracle/python-cx_Oracle/commit/76157dd28a722376fe9eed87872f74be1e4017dc"><code>76157dd</code></a> Add note that change to MessageProperties.msgid marked the attribute</li>
<li>Additional commits viewable in <a href="https://github.com/oracle/python-cx_Oracle/compare/8.0.1...8.3.0">compare view</a></li>
</ul>
</details>
<br />
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps-dev): update cx-oracle requirement from <8.4,>8.0.0 to >=8.3.0,<8.4 [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #41088:
URL: https://github.com/apache/superset/pull/41088#discussion_r3417227982
##########
pyproject.toml:
##########
@@ -177,7 +177,7 @@ ocient = [
"shapely",
"geojson",
]
-oracle = ["cx-Oracle>8.0.0, <8.4"]
+oracle = ["cx-Oracle>=8.3.0, <8.4"]
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Deprecated cx-Oracle vs oracledb mismatch</b></div>
<div id="fix">
The `oracle` extra specifies `cx-Oracle>=8.3.0,<8.4` but the codebase already migrated to `oracledb` (see `superset/db_engine_specs/oracle.py` line 38: `"pypi_packages": ["oracledb"]`). `cx_Oracle` was deprecated by Oracle in 2022, only supports Python ≤3.10, and has known build failures on Python 3.11+. This dependency is incompatible with Superset's `requires-python = ">=3.10"` and will fail to install or build on supported Python versions.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- pyproject.toml (line 180) ---
180:-oracle = ["cx-Oracle>=8.3.0, <8.4"]
180:+oracle = ["oracledb>=2.0.0,<3"]
```
</div>
</details>
</div>
<small><i>Code Review Run #ec356a</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps-dev): update cx-oracle requirement from <8.4,>8.0.0 to >=8.3.0,<8.4 [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #41088:
URL: https://github.com/apache/superset/pull/41088#issuecomment-4713475863
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/41088?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 63.47%. Comparing base ([`f56524b`](https://app.codecov.io/gh/apache/superset/commit/f56524bb7100d919e30c9ff20797977fcb762e33?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b0570df`](https://app.codecov.io/gh/apache/superset/commit/b0570dfcb53214385c8d211c6bf995f2a4972457?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #41088 +/- ##
==========================================
- Coverage 64.31% 63.47% -0.84%
==========================================
Files 2651 2660 +9
Lines 144677 144795 +118
Branches 33350 33384 +34
==========================================
- Hits 93054 91914 -1140
- Misses 49972 51224 +1252
- Partials 1651 1657 +6
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/41088/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/41088/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.35% <ø> (ø)` | |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/41088/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/41088/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/41088/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.92% <ø> (ø)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/41088/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.92% <ø> (-1.67%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/41088/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.76% <ø> (ø)` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/41088/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/41088?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps-dev): update cx-oracle requirement from <8.4,>8.0.0 to >=8.3.0,<8.4 [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41088:
URL: https://github.com/apache/superset/pull/41088#issuecomment-4713413346
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps-dev): update cx-oracle requirement from <8.4,>8.0.0 to >=8.3.0,<8.4 [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #41088:
URL: https://github.com/apache/superset/pull/41088#issuecomment-4721938769
Closing in favor of #41122 - rather than bump cx-Oracle, we're dropping it for `oracledb` (which is what the engine spec already points at). Thanks anyway, dependabot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps-dev): update cx-oracle requirement from <8.4,>8.0.0 to >=8.3.0,<8.4 [superset]
Posted by "dependabot[bot] (via GitHub)" <gi...@apache.org>.
dependabot[bot] commented on PR #41088:
URL: https://github.com/apache/superset/pull/41088#issuecomment-4721939491
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file.
If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps-dev): update cx-oracle requirement from <8.4,>8.0.0 to >=8.3.0,<8.4 [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #41088: chore(deps-dev): update cx-oracle requirement from <8.4,>8.0.0 to >=8.3.0,<8.4
URL: https://github.com/apache/superset/pull/41088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org