[jira] [Comment Edited] (JCLOUDS-1225) Guava 21 compatibility

["Ian Springer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCLOUDS-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822675#comment-15822675 ] 

Ian Springer edited comment on JCLOUDS-1225 at 1/14/17 3:38 PM:
----------------------------------------------------------------

In addition to Objects.ToStringHelper, there is the method MoreExecutors.sameThreadExecutor, which similarly was deprecated in Guava 18 and removed in Guava 21. Its replacement is MoreExecutors.directExecutor or MoreExecutors.newDirectExecutorService (if a ListeningExecutorService is required), both of which are only available in Guava 18 or later.

MoreExecutors.sameThreadExecutor is used by 4 prod classes:

* org.jclouds.ContextBuilder
* org.jclouds.lifecycle.config.LifeCycleModule
* org.jclouds.blobstore.options.PutOptions
* org.jclouds.gae.config.GoogleAppEngineConfigurationModule

as well by a bunch of test classes.



was (Author: ian.springer):
In addition to Objects.ToStringHelper, there is the method MoreExecutors.sameThreadExecutor, which similarly was deprecated in Guava 18 and removed in Guava 21. Its replacement is MoreExecutors.newDirectExecutorService and again is only available in Guava 18 or later.

MoreExecutors.sameThreadExecutor is used by two classes:

* org/jclouds/ContextBuilder.java
* org/jclouds/lifecycle/config/LifeCycleModule.java


> Guava 21 compatibility
> ----------------------
>
>                 Key: JCLOUDS-1225
>                 URL: https://issues.apache.org/jira/browse/JCLOUDS-1225
>             Project: jclouds
>          Issue Type: Bug
>          Components: jclouds-core
>    Affects Versions: 2.0.0
>            Reporter: Ian Springer
>              Labels: guava
>
> The below classes use com.google.common.base.Objects.ToStringHelper, which has been deprecated since Guava 18, and has been removed in Guava 21. This makes it impossible to use jclouds in a project using Guava 21. Please either upgrade to Guava 18+ and switch to using com.google.common.base.MoreObjects.ToStringHelper, or drop the usage of ToStringHelper altogether. This will allow my project to upgrade to Guava 21 without having to use a fork of jclouds.
> * org/jclouds/apis/internal/BaseApiMetadata.java
> * org/jclouds/domain/internal/LocationImpl.java
> * org/jclouds/domain/internal/MutableResourceMetadataImpl.java
> * org/jclouds/domain/internal/ResourceMetadataImpl.java
> * org/jclouds/http/HttpMessage.java
> * org/jclouds/http/HttpRequest.java
> * org/jclouds/http/HttpResponse.java
> * org/jclouds/internal/BaseView.java
> * org/jclouds/providers/internal/BaseProviderMetadata.java
> * org/jclouds/reflect/InvocationSuccess.java
> * org/jclouds/rest/internal/BaseHttpApiMetadata.java
> * org/jclouds/rest/suppliers/URIFromStringSupplier.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)