You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/27 16:02:45 UTC

[GitHub] [arrow-rs] atefsawaed commented on a diff in pull request #1621: Fix decimals min max statistics

atefsawaed commented on code in PR #1621:
URL: https://github.com/apache/arrow-rs/pull/1621#discussion_r859977870


##########
parquet/src/column/writer.rs:
##########
@@ -998,6 +998,57 @@ impl<T: DataType> ColumnWriterImpl<T> {
         }
     }
 
+    fn compare_greater_byte_array_decimals(&self, a: &[u8], b: &[u8]) -> bool {

Review Comment:
   Can you please advise on how to add a test for a private function in this module? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org