You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@airavata.apache.org by ajain13 <gi...@git.apache.org> on 2016/06/26 15:39:15 UTC
[GitHub] airavata pull request #41: Made design changes
GitHub user ajain13 opened a pull request:
https://github.com/apache/airavata/pull/41
Made design changes
I made some design changes to the AuroraJobScheduler.java and added utilities package.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajain13/airavata develop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/airavata/pull/41.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #41
----
commit 9dd54367afe724241bccfb818bc5dba90b97c255
Author: ajain13 <aj...@binghamton.edu>
Date: 2016-06-26T15:34:07Z
Made design changes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] airavata issue #41: Made design changes
Posted by shamrath <gi...@git.apache.org>.
Github user shamrath commented on the issue:
https://github.com/apache/airavata/pull/41
Your local changes preserve with git pull, sometimes you will get conflicts with remote code changes, which you need to fix and commit again. Anyway as a best practice and avoid a lot of merge conflicts it is always good to keep you code sink with the remote repository.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] airavata issue #41: Made design changes
Posted by shamrath <gi...@git.apache.org>.
Github user shamrath commented on the issue:
https://github.com/apache/airavata/pull/41
could you explain the use of modules/cloud/AuroraMarathonIntegration/src/README.md ?
and also 0.16 is released and you should change your cloud module version to 0.17-SNAPSHOT
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] airavata issue #41: Made design changes
Posted by ajain13 <gi...@git.apache.org>.
Github user ajain13 commented on the issue:
https://github.com/apache/airavata/pull/41
@shamrath I am using Maven to build my code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] airavata issue #41: Made design changes
Posted by ajain13 <gi...@git.apache.org>.
Github user ajain13 commented on the issue:
https://github.com/apache/airavata/pull/41
@shamrath So when I change the parent module version, I also have to change the pom.xml of the parent directory and so on right ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] airavata issue #41: Made design changes
Posted by ajain13 <gi...@git.apache.org>.
Github user ajain13 commented on the issue:
https://github.com/apache/airavata/pull/41
@shamrath modules/cloud/AuroraMarathonIntegration/src/README.md file is an old README file which I will get rid off.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] airavata issue #41: Made design changes
Posted by shamrath <gi...@git.apache.org>.
Github user shamrath commented on the issue:
https://github.com/apache/airavata/pull/41
Which build tool are you using to build your code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] airavata issue #41: Made design changes
Posted by shamrath <gi...@git.apache.org>.
Github user shamrath commented on the issue:
https://github.com/apache/airavata/pull/41
could you also run git merge airavata:develop and make sure there are no any conflicts? BTW hope your git branch code is sync with airavata git develop branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] airavata issue #41: Made design changes
Posted by smarru <gi...@git.apache.org>.
Github user smarru commented on the issue:
https://github.com/apache/airavata/pull/41
@ajain13 can you change the file structure to follow the standard maven and make sure the maven build works before we can merge this PR. You can use this as a reference or other Airavata modules - https://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] airavata pull request #41: Made design changes
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/airavata/pull/41
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] airavata issue #41: Made design changes
Posted by ajain13 <gi...@git.apache.org>.
Github user ajain13 commented on the issue:
https://github.com/apache/airavata/pull/41
@shamrath I have made some design changes in orchestrator. Should I make those changes again after the git pull as none of my changes have been merged yet.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] airavata issue #41: Made design changes
Posted by shamrath <gi...@git.apache.org>.
Github user shamrath commented on the issue:
https://github.com/apache/airavata/pull/41
get a git pull now and it will have 0.17-SNAPSHOT.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] airavata issue #41: Made design changes
Posted by ajain13 <gi...@git.apache.org>.
Github user ajain13 commented on the issue:
https://github.com/apache/airavata/pull/41
@smarru I added the file structure to follow standard maven and maven build works.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] airavata issue #41: Made design changes
Posted by ajain13 <gi...@git.apache.org>.
Github user ajain13 commented on the issue:
https://github.com/apache/airavata/pull/41
@shamrath I just did a rebase. I think Travis CI should work now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] airavata issue #41: Made design changes
Posted by ajain13 <gi...@git.apache.org>.
Github user ajain13 commented on the issue:
https://github.com/apache/airavata/pull/41
@shamrath Can you tell me what other pom.xml files require the change ? Do I have to make changes in all the pom.xml files all the way till the root folder i.e airavata/pom.xml , airavata/modules/cloud/pom.xml ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] airavata issue #41: Made design changes
Posted by ajain13 <gi...@git.apache.org>.
Github user ajain13 commented on the issue:
https://github.com/apache/airavata/pull/41
@smarru I used ANT for initial check. I will look at the link right away and also look at other Airavata modules and incorporate it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] airavata issue #41: Made design changes
Posted by shamrath <gi...@git.apache.org>.
Github user shamrath commented on the issue:
https://github.com/apache/airavata/pull/41
Change airavata-cloud parent module version too in your pom.xml, I am just here try to make travis-ci works fine with your code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] airavata issue #41: Made design changes
Posted by ajain13 <gi...@git.apache.org>.
Github user ajain13 commented on the issue:
https://github.com/apache/airavata/pull/41
@shamrath Yes, My branch is in sync with airavata git develop branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] airavata issue #41: Made design changes
Posted by shamrath <gi...@git.apache.org>.
Github user shamrath commented on the issue:
https://github.com/apache/airavata/pull/41
let me change cloud module version for you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---