You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "jayceslesar (via GitHub)" <gi...@apache.org> on 2023/12/07 20:34:19 UTC
[PR] feat(docs): example of multiple catalogs defined in .pyiceberg.yaml [iceberg-python]
jayceslesar opened a new pull request, #194:
URL: https://github.com/apache/iceberg-python/pull/194
Spawned from #156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat(docs): example of multiple catalogs defined in .pyiceberg.yaml [iceberg-python]
Posted by "HonahX (via GitHub)" <gi...@apache.org>.
HonahX commented on code in PR #194:
URL: https://github.com/apache/iceberg-python/pull/194#discussion_r1421197076
##########
mkdocs/docs/api.md:
##########
@@ -33,6 +33,20 @@ catalog:
credential: t-1234:secret
```
+Note that multiple catalogs can be defined in the same `.pyiceberg.yaml`:
+```yaml
+catalog:
+ hive:
+ uri: thrift://127.0.0.1:9083
+ s3.endpoint: http://127.0.0.1:9000
+ s3.access-key-id: admin
+ s3.secret-access-key: password
+ rest:
+ uri: https://rest-server:8181/
+ warehouse: my-warehouse
+```
+and loaded in python by calling `load_catalog`. See below for an example.
Review Comment:
I think the example primarily illustrates how to load a catalog that is not defined in `.pyiceberg.yaml`. For catalogs that are defined in the yaml file, we might say
```
and loaded in python by calling `load_catalog(name="hive")` and `load_catalog(name="rest")`
```
Does this sound right to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat(docs): example of multiple catalogs defined in .pyiceberg.yaml [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #194:
URL: https://github.com/apache/iceberg-python/pull/194#issuecomment-1848672326
> my org has a manual job that can be run as part of a PR/MR that can run the lint and commit the changes? Is it worth looking at adding something similar?
Ha, I'm aware of those systems, and I like them! I haven't looked into that much, but this would require committing on someone's behalf?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat(docs): example of multiple catalogs defined in .pyiceberg.yaml [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #194:
URL: https://github.com/apache/iceberg-python/pull/194#issuecomment-1848655988
@jayceslesar The Markdown linter has an improvement, can you run `make lint`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat(docs): example of multiple catalogs defined in .pyiceberg.yaml [iceberg-python]
Posted by "jayceslesar (via GitHub)" <gi...@apache.org>.
jayceslesar commented on PR #194:
URL: https://github.com/apache/iceberg-python/pull/194#issuecomment-1848667046
@Fokko my org has a manual job that can be run as part of a PR/MR that can run the lint and commit the changes? Is it worth looking at adding something similar? Or stick with the pre-commit? (which I just need to get used to haha)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat(docs): example of multiple catalogs defined in .pyiceberg.yaml [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #194:
URL: https://github.com/apache/iceberg-python/pull/194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat(docs): example of multiple catalogs defined in .pyiceberg.yaml [iceberg-python]
Posted by "jayceslesar (via GitHub)" <gi...@apache.org>.
jayceslesar commented on code in PR #194:
URL: https://github.com/apache/iceberg-python/pull/194#discussion_r1421424492
##########
mkdocs/docs/api.md:
##########
@@ -33,6 +33,20 @@ catalog:
credential: t-1234:secret
```
+Note that multiple catalogs can be defined in the same `.pyiceberg.yaml`:
+```yaml
+catalog:
+ hive:
+ uri: thrift://127.0.0.1:9083
+ s3.endpoint: http://127.0.0.1:9000
+ s3.access-key-id: admin
+ s3.secret-access-key: password
+ rest:
+ uri: https://rest-server:8181/
+ warehouse: my-warehouse
+```
+and loaded in python by calling `load_catalog`. See below for an example.
Review Comment:
Yeah I think that is more explicit -- will add
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org