You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/07/29 06:00:32 UTC
[GitHub] [trafficserver] maskit opened a new pull request, #8988: Change H2 frame handlers to member functions
maskit opened a new pull request, #8988:
URL: https://github.com/apache/trafficserver/pull/8988
This closes #8183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 commented on pull request #8988: Change H2 frame handlers to member functions
Posted by GitBox <gi...@apache.org>.
brbzull0 commented on PR #8988:
URL: https://github.com/apache/trafficserver/pull/8988#issuecomment-1199331512
Nice change. To follow the same goal of this change I am wondering if most of the public members of `Http2ConnectionState` can now be also private as we aren't passing the state object around free functions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #8988: Change H2 frame handlers to member functions
Posted by GitBox <gi...@apache.org>.
maskit commented on PR #8988:
URL: https://github.com/apache/trafficserver/pull/8988#issuecomment-1199467876
Yes, we should be able to make some of the members private, but not all of them. `Http2ConnectionState` is still used by `Http2Session` and `Http2Stream`.
I'm +1 on making those members private, but I'd like to make changes around H2 slowly step by step so the PR for H2-to-Orign can catch up changes on master easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit merged pull request #8988: Change H2 frame handlers to member functions
Posted by GitBox <gi...@apache.org>.
maskit merged PR #8988:
URL: https://github.com/apache/trafficserver/pull/8988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org