You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by allengeorge <gi...@git.apache.org> on 2017/04/07 10:48:11 UTC
[GitHub] thrift pull request #1246: THRIFT-4099: Derive Hash trait for Rust structs
GitHub user allengeorge opened a pull request:
https://github.com/apache/thrift/pull/1246
THRIFT-4099: Derive Hash trait for Rust structs
Auto-derive `Hash` trait for all generated types. Verified that all checks listed [in the JIRA](https://issues.apache.org/jira/browse/THRIFT-4099) worked.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/allengeorge/thrift thrift-4099
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1246.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1246
----
commit b8279f5b23c3da771be70d20f48b3a14cdad83e8
Author: Allen George <al...@gmail.com>
Date: 2017-04-06T12:28:22Z
THRIFT-4099: Derive Hash trait for Rust structs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1246: THRIFT-4099: Derive Hash trait for Rust structs
Posted by allengeorge <gi...@git.apache.org>.
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1246
Hmm. Don't know who should review this, considering that I'm the one who implemented Rust support. But, FWIW, ran the standard cross-tests, checked clippy output, etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1246: THRIFT-4099: Derive Hash trait for Rust structs
Posted by allengeorge <gi...@git.apache.org>.
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1246
@jeking3 I did, though unfortunately the communication was all on [the original Rust Thrift](https://issues.apache.org/jira/browse/THRIFT-2945). I suggested that Tony - the submitter - split up his changes into separate PRs to simplify review and testing. I also created [individual JIRAs](https://issues.apache.org/jira/browse/THRIFT-2945?focusedCommentId=15878212&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15878212) for each of the pieces we agreed to. Unfortunately it looks like he went AWOL after that :/
I'm now attacking those PRs one by one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1246: THRIFT-4099: Derive Hash trait for Rust structs
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1246
@allengeorge could you code review #1187 perhaps?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1246: THRIFT-4099: Derive Hash trait for Rust structs
Posted by przygienda <gi...@git.apache.org>.
Github user przygienda commented on the issue:
https://github.com/apache/thrift/pull/1246
Nah, I'm not AWOL but just completely under water with stuff here and my version here works ;-) ... I agree that we should split the stuff up. I hope to find cycles in new year. Tell me what you want to attack first and we can work together ...
---
[GitHub] thrift pull request #1246: THRIFT-4099: Derive Hash trait for Rust structs
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1246
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---