[jira] [Commented] (SOLR-5594) Enable using extended field types with prefix queries for non-default encoded strings

["Hoss Man (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864579#comment-13864579 ] 

Hoss Man commented on SOLR-5594:
--------------------------------

* Aren't there other parsers classes that will need similar changes? (PrefixQParserPlugin, SimplerQParserPlugin at a minimum i think)
* I think your new FieldType.getPrefixQuery method has a back compat break for any existing FieldTypes that people might be using because it now calls readableToIndexed ... that smells like it could break things for some FieldTypes ... but maybe i'm missing something?
* FieldType.getPrefixQuery has lots of bogus cut/pasted javadocs from getRangeQuery
* Can't your MyIndexedBinaryField just subclass BinaryField to reduce some code?  for that matter: is there any reason why we shouldn't just make BinaryField implement prefix queries in the way your MyIndexedBinaryField does?
* i'm not sure i understand why you need BinaryTokenStream for the test (see previous comment about just extending/improving BinaryField) but if so perhaps it should be moved from lucene/core to lucene/test-framework?

> Enable using extended field types with prefix queries for non-default encoded strings
> -------------------------------------------------------------------------------------
>
>                 Key: SOLR-5594
>                 URL: https://issues.apache.org/jira/browse/SOLR-5594
>             Project: Solr
>          Issue Type: Improvement
>          Components: query parsers, Schema and Analysis
>    Affects Versions: 4.6
>            Reporter: Anshum Gupta
>            Assignee: Anshum Gupta
>            Priority: Minor
>         Attachments: SOLR-5594-branch_4x.patch, SOLR-5594.patch
>
>
> Enable users to be able to use prefix query with custom field types with non-default encoding/decoding for queries more easily. e.g. having a custom field work with base64 encoded query strings.
> Currently, the workaround for it is to have the override at getRewriteMethod level. Perhaps having the prefixQuery also use the calling FieldType's readableToIndexed method would work better.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org