You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/28 11:15:02 UTC
[GitHub] [spark] LuciferYang opened a new pull request #35679: [SPARK-38348][BUILD] Upgrade `tink` to 1.6.1
LuciferYang opened a new pull request #35679:
URL: https://github.com/apache/spark/pull/35679
### What changes were proposed in this pull request?
This pr aims upgrade `com.google.crypto.tink:tink` from 1.6.0 to 1.6.1
### Why are the changes needed?
The release notes as follows:
- https://github.com/google/tink/releases/tag/v1.6.1
There is a performance optimization related to `AesGcmJce.encrypt` method in version 1.6.1 and this method used by `o.a.s.network.crypto.AuthEngine#challenge` and `o.a.s.network.crypto.AuthEngine#response` methods in Spark:
- [Java: isAndroid() shouldn't cause Exceptions to be created](https://github.com/google/tink/issues/497)
This optimization reduces the delay of `AesGcmJce.encrypt` method by 70%.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
- Pass GA
- Manual test:
Verify the performance improvement of `AesGcmJce.encrypt` method as follows:
```scala
val valuesPerIteration = 100000
val derivedKeyEncryptingKey: Array[Byte] =
Array(119, -25, -98, 34, -61, 102, 101, -97, 86, -27, 25, 88, 94, -55, 40, -103)
val ephemeralX25519PublicKey: Array[Byte] =
Array(-94, 121, -27, 40, -42, -6, 114, 17, -11, 107, 58, -69, -69, -58,
56, -121, 28, -18, 10, 25, 41, -66, 77, 17, 19, -99, -54, 54, 97, -111, -13, 77)
val aadState: Array[Byte] =
Array(97, 112, 112, 73, 100, -19, 84, 88, -18, -105, 104, 105, 29, -84,
94, -110, 84, 38, -109, -85, -55)
val benchmark = new Benchmark(
s"Test AesGcmJceEncrypt",
valuesPerIteration,
output = output)
benchmark.addCase("Test AesGcmJce encrypt") { _: Int =>
for (_ <- 0L until valuesPerIteration) {
new AesGcmJce(derivedKeyEncryptingKey).encrypt(ephemeralX25519PublicKey, aadState)
}
}
benchmark.run()
```
Before: 5423.0 ns/ per row
After: 1538.3 ns /per row
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35679: [SPARK-38348][BUILD] Upgrade `tink` to 1.6.1
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35679:
URL: https://github.com/apache/spark/pull/35679#issuecomment-1055104245
@dongjoon-hyun @HyukjinKwon GA passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #35679: [SPARK-38348][BUILD] Upgrade `tink` to 1.6.1
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #35679:
URL: https://github.com/apache/spark/pull/35679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35679: [SPARK-38348][BUILD] Upgrade `tink` to 1.6.1
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35679:
URL: https://github.com/apache/spark/pull/35679#issuecomment-1055690589
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35679: [SPARK-38348][BUILD] Upgrade `tink` to 1.6.1
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35679:
URL: https://github.com/apache/spark/pull/35679#issuecomment-1055504516
thanks all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35679: [SPARK-38348][BUILD] Upgrade `tink` to 1.6.1
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35679:
URL: https://github.com/apache/spark/pull/35679#issuecomment-1054965189
> +1, LGTM. Could you trigger GitHub Action CI once more, @LuciferYang ?
Has been restarted, waiting for the GA results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #35679: [SPARK-38348][BUILD] Upgrade `tink` to 1.6.1
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #35679:
URL: https://github.com/apache/spark/pull/35679#issuecomment-1055502182
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org