You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2018/08/26 22:20:36 UTC
Review Request 68511: ATLAS-2836: Remove redundant encoding of vertex
property keys; ATLAS-2838: Replace GraphHelper.encodeProperty() with
AtlasGraphUtilsV1.encodeProperty()
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68511/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Sarath Subramanian.
Bugs: ATLAS-2836 and ATLAS-2838
https://issues.apache.org/jira/browse/ATLAS-2836
https://issues.apache.org/jira/browse/ATLAS-2838
Repository: atlas
Description
-------
backport of ATLAS-2836, ATLAS-2838 from master to branch-0.8
Diffs
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 56f341d72
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 32cf08b4c
repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java 9b0aa4c02
repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java aed8659c3
repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java f5cbec905
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 74886b56c
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 6eee24b1a
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 0cdbc5798
repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 78ea1c969
repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java b37fe7580
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 1fb4ee990
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java 2b07ae6a2
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java d1fd16fef
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java e59c3890f
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java d9fa2c561
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 47960f3f7
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java f99b4a964
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java 49c9e0ca5
repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 1525d7b8e
repository/src/main/java/org/apache/atlas/repository/typestore/TypePersistenceVisitor.java bfb1bfc75
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 0834601f7
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java eb779ff88
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java 8c86235e8
repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperTest.java e64c2c80d
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java 575bb9ec5
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java 3f1ed0312
Diff: https://reviews.apache.org/r/68511/diff/1/
Testing
-------
Successful pre-commit test run - https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/613/
Thanks,
Madhan Neethiraj
Re: Review Request 68511: ATLAS-2836: Remove redundant encoding of
vertex
property keys; ATLAS-2838: Replace GraphHelper.encodeProperty() with
AtlasGraphUtilsV1.encodeProperty()
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68511/#review207946
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Aug. 26, 2018, 3:20 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68511/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2018, 3:20 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2836 and ATLAS-2838
> https://issues.apache.org/jira/browse/ATLAS-2836
> https://issues.apache.org/jira/browse/ATLAS-2838
>
>
> Repository: atlas
>
>
> Description
> -------
>
> backport of ATLAS-2836, ATLAS-2838 from master to branch-0.8
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 56f341d72
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 32cf08b4c
> repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java 9b0aa4c02
> repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java aed8659c3
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java f5cbec905
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 74886b56c
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 6eee24b1a
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 0cdbc5798
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 78ea1c969
> repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java b37fe7580
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 1fb4ee990
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java 2b07ae6a2
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java d1fd16fef
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java e59c3890f
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java d9fa2c561
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 47960f3f7
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java f99b4a964
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java 49c9e0ca5
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 1525d7b8e
> repository/src/main/java/org/apache/atlas/repository/typestore/TypePersistenceVisitor.java bfb1bfc75
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 0834601f7
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java eb779ff88
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java 8c86235e8
> repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperTest.java e64c2c80d
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java 575bb9ec5
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java 3f1ed0312
>
>
> Diff: https://reviews.apache.org/r/68511/diff/1/
>
>
> Testing
> -------
>
> Successful pre-commit test run - https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/613/
>
>
> Thanks,
>
> Madhan Neethiraj
>
>