You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@royale.apache.org by Maria Jose Esteve <mj...@iest.com> on 2022/02/20 02:20:53 UTC
Jewel TextAlign bead does not have priority
Hi, quiero pedir vuestra opinión sobre una pequeña modificación que creo que se debería realizar. Tal vez no sea la opción correcta, vosotros me diréis...
Tal y como yo lo entiendo, cuando añadimos un bead es porque queremos establecer un determinado comportamiento y no dejarlo al azar.
Actualmente el estilo asignado por el bead TextAlign [1] no tiene prioridad sobre el propio estilo del componente [2], ¿No debería prevalecer?
[1] (_text.sass)
.alignTextLeft
text-align: left
.alignTextRight
text-align: right
.alignTextCenter
text-align: center
[2]
[cid:image001.png@01D82608.DD356ED0]
La modificación sería muy simple, añadir "!important":
.alignTextLeft
text-align: left !important
.alignTextRight
text-align: right !important
.alignTextCenter
text-align: center !important
¿Cómo lo veis? ¿alguna otra opción más conveniente?
Thx.
Hiedra
RE: Jewel TextAlign bead does not have priority
Posted by Maria Jose Esteve <mj...@iest.com>.
Hi, I understand what you are saying. I will do some tests and come back here with the results.
Thx
Hiedra
-----Mensaje original-----
De: Alex Harui <ah...@adobe.com.INVALID>
Enviado el: miércoles, 23 de febrero de 2022 18:13
Para: dev@royale.apache.org
Asunto: Re: Jewel TextAlign bead does not have priority
IMO, using !important is kind of like using a global variable. It breaks CSS order of precedence similar to how using a global breaks encapsulation. Yes, it works, until someone else starts using !important.
The default value for text-align is "left" for ltr and "right" for rtl, so maybe a better solution is to remove the text-align rule from the ".jewel.textInput input" declarations.
HTH,
-Alex
On 2/23/22, 4:22 AM, "Yishay Weiss" <yi...@hotmail.com> wrote:
Sounds like the current behavior is buggy, so as long as your solution improves the situation I would approve. I started thinking about what would happen if there was another bead added that needed to change the same style attribute – what would happen and what should happen? This relates IMO to questions about bead order and precedence. I don’t think we have consensus about expected behavior in that regard. I think you can add a comment with your concerns about this change so they don’t go unnoticed, but as I said, if it solves a real problem and does not have immediate regression effects I would just commit it.
From: Maria Jose Esteve<ma...@iest.com>
Sent: Tuesday, February 22, 2022 8:27 PM
To: dev@royale.apache.org<ma...@royale.apache.org>
Subject: RE: Jewel TextAlign bead does not have priority
Hi,
If no one has a problem, I will make the change. I will wait for tomorrow.
Hiedra
-----Mensaje original-----
De: Maria Jose Esteve <mj...@iest.com>
Enviado el: domingo, 20 de febrero de 2022 3:29
Para: dev@royale.apache.org
Asunto: RV: Jewel TextAlign bead does not have priority
Hi, I would like to ask your opinion about a small modification that I think should be done. Maybe it is not the right choice, you tell me....
As I understand it, when we add a bead is because we want to establish a certain behavior and not leave it to chance.
Currently the style assigned by the TextAlign bead [1] does not take precedence over the component's own style [2], shouldn't it prevail?
[1] (_text.sass)
.alignTextLeft
text-align: left
.alignTextRight
text-align: right
.alignTextCenter
text-align: center
[2] https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdrive.google.com%2Ffile%2Fd%2F1n7XbXj_bBEDWWZBOOVmRAFvWb4fHhvaL%2Fview%3Fusp%3Dsharing&data=04%7C01%7Caharui%40adobe.com%7Ca3d614bf52c64de8a10b08d9f6c6f31e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637812157547347665%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=4zSAFTVEGP6JcreCQeCubdOvVrTJeV6bwj0guurfzwA%3D&reserved=0
The modification would be very simple, add "!important":
.alignTextLeft
text-align: left !important
.alignTextRight
text-align: right !important
.alignTextCenter
text-align: center !important
How do you see it? Any other more convenient option?
Thx
Hiedra
De: Maria Jose Esteve <mj...@iest.com> Enviado el: domingo, 20 de febrero de 2022 3:21
Para: dev@royale.apache.org
Asunto: Jewel TextAlign bead does not have priority
Hi, quiero pedir vuestra opinión sobre una pequeña modificación que creo que se debería realizar. Tal vez no sea la opción correcta, vosotros me diréis...
Tal y como yo lo entiendo, cuando añadimos un bead es porque queremos establecer un determinado comportamiento y no dejarlo al azar.
Actualmente el estilo asignado por el bead TextAlign [1] no tiene prioridad sobre el propio estilo del componente [2], ¿No debería prevalecer?
[1] (_text.sass)
.alignTextLeft
text-align: left
.alignTextRight
text-align: right
.alignTextCenter
text-align: center
[2]
[cid:image001.png@01D82608.DD356ED0]
La modificación sería muy simple, añadir "!important":
.alignTextLeft
text-align: left !important
.alignTextRight
text-align: right !important
.alignTextCenter
text-align: center !important
¿Cómo lo veis? ¿alguna otra opción más conveniente?
Thx.
Hiedra
Re: Jewel TextAlign bead does not have priority
Posted by Alex Harui <ah...@adobe.com.INVALID>.
IMO, using !important is kind of like using a global variable. It breaks CSS order of precedence similar to how using a global breaks encapsulation. Yes, it works, until someone else starts using !important.
The default value for text-align is "left" for ltr and "right" for rtl, so maybe a better solution is to remove the text-align rule from the ".jewel.textInput input" declarations.
HTH,
-Alex
On 2/23/22, 4:22 AM, "Yishay Weiss" <yi...@hotmail.com> wrote:
Sounds like the current behavior is buggy, so as long as your solution improves the situation I would approve. I started thinking about what would happen if there was another bead added that needed to change the same style attribute – what would happen and what should happen? This relates IMO to questions about bead order and precedence. I don’t think we have consensus about expected behavior in that regard. I think you can add a comment with your concerns about this change so they don’t go unnoticed, but as I said, if it solves a real problem and does not have immediate regression effects I would just commit it.
From: Maria Jose Esteve<ma...@iest.com>
Sent: Tuesday, February 22, 2022 8:27 PM
To: dev@royale.apache.org<ma...@royale.apache.org>
Subject: RE: Jewel TextAlign bead does not have priority
Hi,
If no one has a problem, I will make the change. I will wait for tomorrow.
Hiedra
-----Mensaje original-----
De: Maria Jose Esteve <mj...@iest.com>
Enviado el: domingo, 20 de febrero de 2022 3:29
Para: dev@royale.apache.org
Asunto: RV: Jewel TextAlign bead does not have priority
Hi, I would like to ask your opinion about a small modification that I think should be done. Maybe it is not the right choice, you tell me....
As I understand it, when we add a bead is because we want to establish a certain behavior and not leave it to chance.
Currently the style assigned by the TextAlign bead [1] does not take precedence over the component's own style [2], shouldn't it prevail?
[1] (_text.sass)
.alignTextLeft
text-align: left
.alignTextRight
text-align: right
.alignTextCenter
text-align: center
[2] https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdrive.google.com%2Ffile%2Fd%2F1n7XbXj_bBEDWWZBOOVmRAFvWb4fHhvaL%2Fview%3Fusp%3Dsharing&data=04%7C01%7Caharui%40adobe.com%7Ca3d614bf52c64de8a10b08d9f6c6f31e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637812157547347665%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=4zSAFTVEGP6JcreCQeCubdOvVrTJeV6bwj0guurfzwA%3D&reserved=0
The modification would be very simple, add "!important":
.alignTextLeft
text-align: left !important
.alignTextRight
text-align: right !important
.alignTextCenter
text-align: center !important
How do you see it? Any other more convenient option?
Thx
Hiedra
De: Maria Jose Esteve <mj...@iest.com> Enviado el: domingo, 20 de febrero de 2022 3:21
Para: dev@royale.apache.org
Asunto: Jewel TextAlign bead does not have priority
Hi, quiero pedir vuestra opinión sobre una pequeña modificación que creo que se debería realizar. Tal vez no sea la opción correcta, vosotros me diréis...
Tal y como yo lo entiendo, cuando añadimos un bead es porque queremos establecer un determinado comportamiento y no dejarlo al azar.
Actualmente el estilo asignado por el bead TextAlign [1] no tiene prioridad sobre el propio estilo del componente [2], ¿No debería prevalecer?
[1] (_text.sass)
.alignTextLeft
text-align: left
.alignTextRight
text-align: right
.alignTextCenter
text-align: center
[2]
[cid:image001.png@01D82608.DD356ED0]
La modificación sería muy simple, añadir "!important":
.alignTextLeft
text-align: left !important
.alignTextRight
text-align: right !important
.alignTextCenter
text-align: center !important
¿Cómo lo veis? ¿alguna otra opción más conveniente?
Thx.
Hiedra
RE: Jewel TextAlign bead does not have priority
Posted by Yishay Weiss <yi...@hotmail.com>.
Sounds like the current behavior is buggy, so as long as your solution improves the situation I would approve. I started thinking about what would happen if there was another bead added that needed to change the same style attribute – what would happen and what should happen? This relates IMO to questions about bead order and precedence. I don’t think we have consensus about expected behavior in that regard. I think you can add a comment with your concerns about this change so they don’t go unnoticed, but as I said, if it solves a real problem and does not have immediate regression effects I would just commit it.
From: Maria Jose Esteve<ma...@iest.com>
Sent: Tuesday, February 22, 2022 8:27 PM
To: dev@royale.apache.org<ma...@royale.apache.org>
Subject: RE: Jewel TextAlign bead does not have priority
Hi,
If no one has a problem, I will make the change. I will wait for tomorrow.
Hiedra
-----Mensaje original-----
De: Maria Jose Esteve <mj...@iest.com>
Enviado el: domingo, 20 de febrero de 2022 3:29
Para: dev@royale.apache.org
Asunto: RV: Jewel TextAlign bead does not have priority
Hi, I would like to ask your opinion about a small modification that I think should be done. Maybe it is not the right choice, you tell me....
As I understand it, when we add a bead is because we want to establish a certain behavior and not leave it to chance.
Currently the style assigned by the TextAlign bead [1] does not take precedence over the component's own style [2], shouldn't it prevail?
[1] (_text.sass)
.alignTextLeft
text-align: left
.alignTextRight
text-align: right
.alignTextCenter
text-align: center
[2] https://drive.google.com/file/d/1n7XbXj_bBEDWWZBOOVmRAFvWb4fHhvaL/view?usp=sharing
The modification would be very simple, add "!important":
.alignTextLeft
text-align: left !important
.alignTextRight
text-align: right !important
.alignTextCenter
text-align: center !important
How do you see it? Any other more convenient option?
Thx
Hiedra
De: Maria Jose Esteve <mj...@iest.com> Enviado el: domingo, 20 de febrero de 2022 3:21
Para: dev@royale.apache.org
Asunto: Jewel TextAlign bead does not have priority
Hi, quiero pedir vuestra opinión sobre una pequeña modificación que creo que se debería realizar. Tal vez no sea la opción correcta, vosotros me diréis...
Tal y como yo lo entiendo, cuando añadimos un bead es porque queremos establecer un determinado comportamiento y no dejarlo al azar.
Actualmente el estilo asignado por el bead TextAlign [1] no tiene prioridad sobre el propio estilo del componente [2], ¿No debería prevalecer?
[1] (_text.sass)
.alignTextLeft
text-align: left
.alignTextRight
text-align: right
.alignTextCenter
text-align: center
[2]
[cid:image001.png@01D82608.DD356ED0]
La modificación sería muy simple, añadir "!important":
.alignTextLeft
text-align: left !important
.alignTextRight
text-align: right !important
.alignTextCenter
text-align: center !important
¿Cómo lo veis? ¿alguna otra opción más conveniente?
Thx.
Hiedra
RE: Jewel TextAlign bead does not have priority
Posted by Maria Jose Esteve <mj...@iest.com>.
Hi,
If no one has a problem, I will make the change. I will wait for tomorrow.
Hiedra
-----Mensaje original-----
De: Maria Jose Esteve <mj...@iest.com>
Enviado el: domingo, 20 de febrero de 2022 3:29
Para: dev@royale.apache.org
Asunto: RV: Jewel TextAlign bead does not have priority
Hi, I would like to ask your opinion about a small modification that I think should be done. Maybe it is not the right choice, you tell me....
As I understand it, when we add a bead is because we want to establish a certain behavior and not leave it to chance.
Currently the style assigned by the TextAlign bead [1] does not take precedence over the component's own style [2], shouldn't it prevail?
[1] (_text.sass)
.alignTextLeft
text-align: left
.alignTextRight
text-align: right
.alignTextCenter
text-align: center
[2] https://drive.google.com/file/d/1n7XbXj_bBEDWWZBOOVmRAFvWb4fHhvaL/view?usp=sharing
The modification would be very simple, add "!important":
.alignTextLeft
text-align: left !important
.alignTextRight
text-align: right !important
.alignTextCenter
text-align: center !important
How do you see it? Any other more convenient option?
Thx
Hiedra
De: Maria Jose Esteve <mj...@iest.com> Enviado el: domingo, 20 de febrero de 2022 3:21
Para: dev@royale.apache.org
Asunto: Jewel TextAlign bead does not have priority
Hi, quiero pedir vuestra opinión sobre una pequeña modificación que creo que se debería realizar. Tal vez no sea la opción correcta, vosotros me diréis...
Tal y como yo lo entiendo, cuando añadimos un bead es porque queremos establecer un determinado comportamiento y no dejarlo al azar.
Actualmente el estilo asignado por el bead TextAlign [1] no tiene prioridad sobre el propio estilo del componente [2], ¿No debería prevalecer?
[1] (_text.sass)
.alignTextLeft
text-align: left
.alignTextRight
text-align: right
.alignTextCenter
text-align: center
[2]
[cid:image001.png@01D82608.DD356ED0]
La modificación sería muy simple, añadir "!important":
.alignTextLeft
text-align: left !important
.alignTextRight
text-align: right !important
.alignTextCenter
text-align: center !important
¿Cómo lo veis? ¿alguna otra opción más conveniente?
Thx.
Hiedra
RV: Jewel TextAlign bead does not have priority
Posted by Maria Jose Esteve <mj...@iest.com>.
Hi, I would like to ask your opinion about a small modification that I think should be done. Maybe it is not the right choice, you tell me....
As I understand it, when we add a bead is because we want to establish a certain behavior and not leave it to chance.
Currently the style assigned by the TextAlign bead [1] does not take precedence over the component's own style [2], shouldn't it prevail?
[1] (_text.sass)
.alignTextLeft
text-align: left
.alignTextRight
text-align: right
.alignTextCenter
text-align: center
[2] https://drive.google.com/file/d/1n7XbXj_bBEDWWZBOOVmRAFvWb4fHhvaL/view?usp=sharing
The modification would be very simple, add "!important":
.alignTextLeft
text-align: left !important
.alignTextRight
text-align: right !important
.alignTextCenter
text-align: center !important
How do you see it? Any other more convenient option?
Thx
Hiedra
De: Maria Jose Esteve <mj...@iest.com>
Enviado el: domingo, 20 de febrero de 2022 3:21
Para: dev@royale.apache.org
Asunto: Jewel TextAlign bead does not have priority
Hi, quiero pedir vuestra opinión sobre una pequeña modificación que creo que se debería realizar. Tal vez no sea la opción correcta, vosotros me diréis...
Tal y como yo lo entiendo, cuando añadimos un bead es porque queremos establecer un determinado comportamiento y no dejarlo al azar.
Actualmente el estilo asignado por el bead TextAlign [1] no tiene prioridad sobre el propio estilo del componente [2], ¿No debería prevalecer?
[1] (_text.sass)
.alignTextLeft
text-align: left
.alignTextRight
text-align: right
.alignTextCenter
text-align: center
[2]
[cid:image001.png@01D82608.DD356ED0]
La modificación sería muy simple, añadir "!important":
.alignTextLeft
text-align: left !important
.alignTextRight
text-align: right !important
.alignTextCenter
text-align: center !important
¿Cómo lo veis? ¿alguna otra opción más conveniente?
Thx.
Hiedra