You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/03/24 16:12:15 UTC
[GitHub] [hadoop] Hexiaoqiao commented on a change in pull request #4057: HDFS-16498. Fix NPE for checkBlockReportLease
Hexiaoqiao commented on a change in pull request #4057:
URL: https://github.com/apache/hadoop/pull/4057#discussion_r834482510
##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
##########
@@ -2751,6 +2751,13 @@ public boolean checkBlockReportLease(BlockReportContext context,
return true;
}
DatanodeDescriptor node = datanodeManager.getDatanode(nodeID);
+ if (node == null) {
+ final UnregisteredNodeException e = new UnregisteredNodeException(nodeID, null);
+ NameNode.stateChangeLog.error("BLOCK* NameSystem.getDatanode: " + "Data node " + nodeID +
Review comment:
I am confused if we need log here which upper method also do that when meet UnregisteredNodeException. Although it is DEBU level now, we could improve that to WARN, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org