Re: [PR] Add support for Create Iceberg Table statement for Snowflake parser [datafusion-sqlparser-rs]

["iffyio (via GitHub)" <gi...@apache.org>]

iffyio commented on code in PR #1664:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1664#discussion_r1921005207


##########
src/ast/mod.rs:
##########
@@ -2516,6 +2516,35 @@ pub enum Statement {
     /// CREATE TABLE
     /// ```
     CreateTable(CreateTable),
+    /// ``` sql
+    /// CREATE ICEBERG TABLE
+    /// Snowflake-specific statement
+    /// <https://docs.snowflake.com/en/sql-reference/sql/create-iceberg-table>
+    /// ```
+    CreateIcebergTable {

Review Comment:
   The preferred path would be to reuse the `CreateTable` variant, by e.g. adding a `is_iceberg_table: bool` to flag the table type and then including any iceberg table fields as optional/empty 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org