You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/15 10:36:46 UTC
[GitHub] [superset] Yann-OAF opened a new pull request #13130: feat(helm): Evaluate configOverrides as templates
Yann-OAF opened a new pull request #13130:
URL: https://github.com/apache/superset/pull/13130
### SUMMARY
This change will evaluate `configOverrides` as templates. This allows making those overrides dynamic and use input values from `values.yaml` which may not be easy to ingest as env variables. For instance:
```
configOverrides:
reports: |
WEBDRIVER_BASEURL = "http://{{ template "superset.fullname" . }}:{{ .Values.service.port }}/"
```
### TEST PLAN
* Update your `values.yaml` with some values based on Helm values - see example above
* `helm upgrade` your chart release
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Yann-J commented on pull request #13130: feat(helm): Evaluate configOverrides as templates
Posted by GitBox <gi...@apache.org>.
Yann-J commented on pull request #13130:
URL: https://github.com/apache/superset/pull/13130#issuecomment-780605569
Hi there @craig-rueda just a quick ping on that last Helm-related PR from my side... This one was a bit of a leftover from the previous one on config overrides, and should be very safe to merge...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda merged pull request #13130: feat(helm): Evaluate configOverrides as templates
Posted by GitBox <gi...@apache.org>.
craig-rueda merged pull request #13130:
URL: https://github.com/apache/superset/pull/13130
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org