You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "namrathamyske (via GitHub)" <gi...@apache.org> on 2023/06/26 23:06:13 UTC

[GitHub] [iceberg] namrathamyske opened a new issue, #7918: Iceberg requiredNumOfPartitions method

namrathamyske opened a new issue, #7918:
URL: https://github.com/apache/iceberg/issues/7918

   ### Feature Request / Improvement
   
   Hello community,
   
   I wanted to override method in SparkWrite.java
   
   `  default int requiredNumPartitions() { 
             return 0; 
       }
   `
   
   The primary goal of this method is pass custom number of partitions to the range/hash partitioner (After taking value from spark configs) Anyone has concerns on this? 
   
   @rdblue @RussellSpitzer @aokolnychyi @jackye1995 
   
   ### Query engine
   
   None


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] namrathamyske commented on issue #7918: Iceberg requiredNumOfPartitions method

Posted by "namrathamyske (via GitHub)" <gi...@apache.org>.
namrathamyske commented on issue #7918:
URL: https://github.com/apache/iceberg/issues/7918#issuecomment-1615208124

   @rdblue @RussellSpitzer @aokolnychyi 
    Any specific reason we pass the finalNumPartitions from iceberg? spark is not able to apply AQE coalesce partitions as we are specifying the number of partitions(leading to small files problem) But when we pass None as the number of partitions,  Spark AQE kicks in and it coalesces partitions as suitable - [https://github.com/apache/iceberg/blob/8af5b1d8c032ff2b0b2d738b3b5f791e16b83e84/sp[…]ution/datasources/v2/ExtendedDistributionAndOrderingUtils.scala](https://github.com/apache/iceberg/blob/8af5b1d8c032ff2b0b2d738b3b5f791e16b83e84/sp[%E2%80%A6]ution/datasources/v2/ExtendedDistributionAndOrderingUtils.scala).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org