[jira] [Commented] (HDFS-9687) libhdfs++: potential segfault after teardown

["James Clampffer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113368#comment-15113368 ] 

James Clampffer commented on HDFS-9687:
---------------------------------------

Looks good to me.  If it gets a clean CI run I'll +1.

> libhdfs++: potential segfault after teardown
> --------------------------------------------
>
>                 Key: HDFS-9687
>                 URL: https://issues.apache.org/jira/browse/HDFS-9687
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Bob Hansen
>            Assignee: Bob Hansen
>         Attachments: HDFS-9687.HDFS-8707.000.diff
>
>
> During shutdown, it is possible for an RPC task to outlive the RPC connection and segfault when it attempts to signal the engine on timeout.
> In rpc_connection.h, the callback 
> {code}
> req->timer().async_wait(std::bind(
>       &RpcConnection::HandleRpcTimeout, this, req, _1));
> {code}
> does not retain a reference to shared_this, so the connection can be destroyed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)