You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@quickstep.apache.org by sh...@apache.org on 2016/07/05 14:39:31 UTC
incubator-quickstep git commit: Fixed unused variables
Repository: incubator-quickstep
Updated Branches:
refs/heads/SQL-window-aggregation 7242806e7 -> 429f059d9
Fixed unused variables
Project: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/commit/429f059d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/tree/429f059d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/diff/429f059d
Branch: refs/heads/SQL-window-aggregation
Commit: 429f059d91cfdfabe127ea13731e58b596f0a307
Parents: 7242806
Author: shixuan-fan <sh...@apache.org>
Authored: Tue Jul 5 14:38:40 2016 +0000
Committer: shixuan-fan <sh...@apache.org>
Committed: Tue Jul 5 14:38:40 2016 +0000
----------------------------------------------------------------------
storage/WindowAggregationOperationState.hpp | 36 ++++++++++++++++++++++++
1 file changed, 36 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-quickstep/blob/429f059d/storage/WindowAggregationOperationState.hpp
----------------------------------------------------------------------
diff --git a/storage/WindowAggregationOperationState.hpp b/storage/WindowAggregationOperationState.hpp
index 6b287e7..d7b3e6a 100644
--- a/storage/WindowAggregationOperationState.hpp
+++ b/storage/WindowAggregationOperationState.hpp
@@ -106,6 +106,42 @@ class WindowAggregationOperationState {
static bool ProtoIsValid(const serialization::WindowAggregationOperationState &proto,
const CatalogDatabaseLite &database);
+ /**
+ * @brief Get the is_row info.
+ * @note This is a quickfix for "unused variable". After the window aggregate
+ * functions are built, these methods might be dropped.
+ *
+ * @return True if the frame mode is ROW, false if it is RANGE.
+ **/
+ const bool is_row() const { return is_row_; }
+
+ /**
+ * @brief Get the num_preceding info.
+ * @note This is a quickfix for "unused variable". After the window aggregate
+ * functions are built, these methods might be dropped.
+ *
+ * @return The number of rows/range that precedes the current row.
+ **/
+ const std::int64_t num_preceding() const { return num_preceding_; }
+
+ /**
+ * @brief Get the num_following info.
+ * @note This is a quickfix for "unused variable". After the window aggregate
+ * functions are built, these methods might be dropped.
+ *
+ * @return The number of rows/range that follows the current row.
+ **/
+ const std::int64_t num_following() const { return num_following_; }
+
+ /**
+ * @brief Get the pointer to StorageManager.
+ * @note This is a quickfix for "unused variable". After the window aggregate
+ * functions are built, these methods might be dropped.
+ *
+ * @return A pointer to the storage manager.
+ **/
+ StorageManager *storage_manager() { return storage_manager_; }
+
private:
const CatalogRelationSchema &input_relation_;