[GitHub] [spark] LuciferYang commented on a diff in pull request #36208: [SPARK-38911][CORE] Fix the potential resource profile id mess up issue

[GitBox <gi...@apache.org>]

LuciferYang commented on code in PR #36208:
URL: https://github.com/apache/spark/pull/36208#discussion_r851689893


##########
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala:
##########
@@ -3256,11 +3256,12 @@ class DAGSchedulerSuite extends SparkFunSuite with TempLocalSparkContext with Ti
   }
 
   test("test 1 resource profile") {
+    val sparkContext = sc

Review Comment:
   Hmm...this may not be perfect. If we initialize `default ` first, profile with id 1 will no longer exist
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org