You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Manikumar Reddy O <ma...@gmail.com> on 2015/01/01 14:54:03 UTC

Review Request 29523: Patch for KAFKA-1723

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29523/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1723
    https://issues.apache.org/jira/browse/KAFKA-1723


Repository: kafka


Description
-------

Standard JMX MBean Naming is implemented


Diffs
-----

  clients/src/main/java/org/apache/kafka/clients/NetworkClient.java 525b95e98010cd2053eacd8c321d079bcac2f910 
  clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java d859fc588a276eb36bcfd621ae6d7978ad0decdd 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java aa91e1444a49c55870b9a7a32086fa2b04471fba 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java c15485d1af304ef53691d478f113f332fe67af77 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 84a7a07269c51ccc22ebb4ff9797292d07ba778e 
  clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java 3c312011a7ff7e79c277a89048e7e62ebd6078db 
  clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java a7458b50cb16fbb2b31b857d5b359e65258bbf08 
  clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java 49be4019ac03835701c49646920766228ac7ffe9 
  clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java 25c1faf2887ea02708c1f5b5f822f5299ed86bd6 
  clients/src/main/java/org/apache/kafka/common/network/Selector.java 4dd2cdf773f7eb01a93d7f994383088960303dfc 
  clients/src/test/java/org/apache/kafka/clients/producer/BufferPoolTest.java fe3c13f319d48b89a4f26b6d78c2c3e31cc50d7e 
  clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java 2c9932401d573549c40f16fda8c4e3e11309cb85 
  clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java ef2ca65cabe97b909f17b62027a1bb06827e88fe 
  clients/src/test/java/org/apache/kafka/common/metrics/JmxReporterTest.java 2f43c49450e1a3d671bd17417dc42941f1858750 
  clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java 19bea0f1fa1ebf15d86623015ec909b0155e4bd3 
  clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
  clients/src/test/java/org/apache/kafka/test/MetricsBench.java 9d98c1148255455fd801043b59b98fed9d0b76b3 

Diff: https://reviews.apache.org/r/29523/diff/


Testing
-------


Thanks,

Manikumar Reddy O

Re: Review Request 29523: Patch for KAFKA-1723

Posted by Jay Kreps <bo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29523/#review66544
-----------------------------------------------------------



clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java
<https://reviews.apache.org/r/29523/#comment110116>

    Couple of things:
    1. The javadoc example is now out of date I think.
    2. We don't really document what the group and tags concept actually mean. What should I put in there?
    3. Should group/tags be optional? It doesn't look like we have any methods that don't require them.



clients/src/main/java/org/apache/kafka/common/network/Selector.java
<https://reviews.apache.org/r/29523/#comment110111>

    Selector is part of the network package which just does low-level network stuff. It can't reference clientId which is a higher-level concept. If you want to pass in a map of tags that might work.



clients/src/main/java/org/apache/kafka/common/network/Selector.java
<https://reviews.apache.org/r/29523/#comment110113>

    This is hard-coding ProducerMetrics in generic Selector code that is also used in the consumer and will be used elsewhere.



clients/src/test/java/org/apache/kafka/clients/producer/BufferPoolTest.java
<https://reviews.apache.org/r/29523/#comment110114>

    BufferPool doesn't know about clientId


- Jay Kreps


On Jan. 1, 2015, 1:54 p.m., Manikumar Reddy O wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29523/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2015, 1:54 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1723
>     https://issues.apache.org/jira/browse/KAFKA-1723
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Standard JMX MBean Naming is implemented
> 
> 
> Diffs
> -----
> 
>   clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java d859fc588a276eb36bcfd621ae6d7978ad0decdd 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java aa91e1444a49c55870b9a7a32086fa2b04471fba 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java c15485d1af304ef53691d478f113f332fe67af77 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 84a7a07269c51ccc22ebb4ff9797292d07ba778e 
>   clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java 3c312011a7ff7e79c277a89048e7e62ebd6078db 
>   clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java a7458b50cb16fbb2b31b857d5b359e65258bbf08 
>   clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java 49be4019ac03835701c49646920766228ac7ffe9 
>   clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java 25c1faf2887ea02708c1f5b5f822f5299ed86bd6 
>   clients/src/main/java/org/apache/kafka/common/network/Selector.java 4dd2cdf773f7eb01a93d7f994383088960303dfc 
>   clients/src/test/java/org/apache/kafka/clients/producer/BufferPoolTest.java fe3c13f319d48b89a4f26b6d78c2c3e31cc50d7e 
>   clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java 2c9932401d573549c40f16fda8c4e3e11309cb85 
>   clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java ef2ca65cabe97b909f17b62027a1bb06827e88fe 
>   clients/src/test/java/org/apache/kafka/common/metrics/JmxReporterTest.java 2f43c49450e1a3d671bd17417dc42941f1858750 
>   clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java 19bea0f1fa1ebf15d86623015ec909b0155e4bd3 
>   clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
>   clients/src/test/java/org/apache/kafka/test/MetricsBench.java 9d98c1148255455fd801043b59b98fed9d0b76b3 
> 
> Diff: https://reviews.apache.org/r/29523/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Manikumar Reddy O
> 
>

Re: Review Request 29523: Patch for KAFKA-1723

Posted by Manikumar Reddy O <ma...@gmail.com>.

> On Jan. 8, 2015, 10:28 p.m., Jay Kreps wrote:
> > clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java, line 115
> > <https://reviews.apache.org/r/29523/diff/20/?file=813229#file813229line115>
> >
> >     This won't be enough to distinguish the metric, right? Absent the group/tags info...

I have implemented toString() method in MetricName. So this will print complete info about the metric name (name , group, description , tags)


- Manikumar Reddy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29523/#review67314
-----------------------------------------------------------


On Jan. 9, 2015, 6:15 p.m., Manikumar Reddy O wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29523/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 6:15 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1723
>     https://issues.apache.org/jira/browse/KAFKA-1723
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Standard JMX MBean Naming is implemented;Addresing Jun's comments
> 
> 
> Diffs
> -----
> 
>   build.gradle ba52288031e2abc70e35e9297a4423dd5025950b 
>   clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java 1bce50185273dbdbc131fbc9c7f5f3e9c346517a 
>   clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 7f8a41c4bf437711685a8271a4d3c83a176dd957 
>   clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java 8cab16c0a0bdb671fea1fc2fc2694247f66cc971 
>   clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 3053f2745c8e5f6e3b75826d3749656f150878db 
>   clients/src/main/java/org/apache/kafka/clients/producer/Producer.java 5baa6062bd9ba8a7d38058856ed2d831fae491f0 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java aa91e1444a49c55870b9a7a32086fa2b04471fba 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java c15485d1af304ef53691d478f113f332fe67af77 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 84a7a07269c51ccc22ebb4ff9797292d07ba778e 
>   clients/src/main/java/org/apache/kafka/common/Metric.java b023e8e7c486adf21ed9a554085ab8ad7f3ee038 
>   clients/src/main/java/org/apache/kafka/common/metrics/CompoundStat.java 29185a6a90d0035d650c7e56ce612a0878cb115c 
>   clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java 3c312011a7ff7e79c277a89048e7e62ebd6078db 
>   clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java a7458b50cb16fbb2b31b857d5b359e65258bbf08 
>   clients/src/main/java/org/apache/kafka/common/metrics/MetricName.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java 49be4019ac03835701c49646920766228ac7ffe9 
>   clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java 25c1faf2887ea02708c1f5b5f822f5299ed86bd6 
>   clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentile.java 7365ceb39072a6a1ecf533f5a20830ed1f2cfc72 
>   clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentiles.java c70d577ada8c099533d4f4ed2e86d37e0a6e6676 
>   clients/src/main/java/org/apache/kafka/common/network/Selector.java 4dd2cdf773f7eb01a93d7f994383088960303dfc 
>   clients/src/test/java/org/apache/kafka/clients/producer/BufferPoolTest.java fe3c13f319d48b89a4f26b6d78c2c3e31cc50d7e 
>   clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java 2c9932401d573549c40f16fda8c4e3e11309cb85 
>   clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java ef2ca65cabe97b909f17b62027a1bb06827e88fe 
>   clients/src/test/java/org/apache/kafka/common/metrics/JmxReporterTest.java 2f43c49450e1a3d671bd17417dc42941f1858750 
>   clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java 19bea0f1fa1ebf15d86623015ec909b0155e4bd3 
>   clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
>   clients/src/test/java/org/apache/kafka/test/MetricsBench.java 9d98c1148255455fd801043b59b98fed9d0b76b3 
> 
> Diff: https://reviews.apache.org/r/29523/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Manikumar Reddy O
> 
>

Re: Review Request 29523: Patch for KAFKA-1723

Posted by Jay Kreps <bo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29523/#review67314
-----------------------------------------------------------



clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java
<https://reviews.apache.org/r/29523/#comment111310>

    This won't be enough to distinguish the metric, right? Absent the group/tags info...


- Jay Kreps


On Jan. 8, 2015, 4:34 p.m., Manikumar Reddy O wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29523/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2015, 4:34 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1723
>     https://issues.apache.org/jira/browse/KAFKA-1723
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Standard JMX MBean Naming is implemented;Addresing Jay's comments
> 
> 
> Diffs
> -----
> 
>   clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java 1bce50185273dbdbc131fbc9c7f5f3e9c346517a 
>   clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 7f8a41c4bf437711685a8271a4d3c83a176dd957 
>   clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java 8cab16c0a0bdb671fea1fc2fc2694247f66cc971 
>   clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 3053f2745c8e5f6e3b75826d3749656f150878db 
>   clients/src/main/java/org/apache/kafka/clients/producer/Producer.java 5baa6062bd9ba8a7d38058856ed2d831fae491f0 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java aa91e1444a49c55870b9a7a32086fa2b04471fba 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java c15485d1af304ef53691d478f113f332fe67af77 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 84a7a07269c51ccc22ebb4ff9797292d07ba778e 
>   clients/src/main/java/org/apache/kafka/common/Metric.java b023e8e7c486adf21ed9a554085ab8ad7f3ee038 
>   clients/src/main/java/org/apache/kafka/common/metrics/CompoundStat.java 29185a6a90d0035d650c7e56ce612a0878cb115c 
>   clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java 3c312011a7ff7e79c277a89048e7e62ebd6078db 
>   clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java a7458b50cb16fbb2b31b857d5b359e65258bbf08 
>   clients/src/main/java/org/apache/kafka/common/metrics/MetricName.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java 49be4019ac03835701c49646920766228ac7ffe9 
>   clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java 25c1faf2887ea02708c1f5b5f822f5299ed86bd6 
>   clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentile.java 7365ceb39072a6a1ecf533f5a20830ed1f2cfc72 
>   clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentiles.java c70d577ada8c099533d4f4ed2e86d37e0a6e6676 
>   clients/src/main/java/org/apache/kafka/common/network/Selector.java 4dd2cdf773f7eb01a93d7f994383088960303dfc 
>   clients/src/test/java/org/apache/kafka/clients/producer/BufferPoolTest.java fe3c13f319d48b89a4f26b6d78c2c3e31cc50d7e 
>   clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java 2c9932401d573549c40f16fda8c4e3e11309cb85 
>   clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java ef2ca65cabe97b909f17b62027a1bb06827e88fe 
>   clients/src/test/java/org/apache/kafka/common/metrics/JmxReporterTest.java 2f43c49450e1a3d671bd17417dc42941f1858750 
>   clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java 19bea0f1fa1ebf15d86623015ec909b0155e4bd3 
>   clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
>   clients/src/test/java/org/apache/kafka/test/MetricsBench.java 9d98c1148255455fd801043b59b98fed9d0b76b3 
> 
> Diff: https://reviews.apache.org/r/29523/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Manikumar Reddy O
> 
>

Re: Review Request 29523: Patch for KAFKA-1723

Posted by Manikumar Reddy O <ma...@gmail.com>.

> On Jan. 8, 2015, 9:21 p.m., Jun Rao wrote:
> > clients/src/main/java/org/apache/kafka/common/network/Selector.java, line 419
> > <https://reviews.apache.org/r/29523/diff/20/?file=813232#file813232line419>
> >
> >     It's probably better to just reference a "ProducerMetrics" constant.

Selector is a low level utility. It can be used in new producer , consumer or etc. So instead of hard-coding, metricGrpName is passed as an argument


> On Jan. 8, 2015, 9:21 p.m., Jun Rao wrote:
> > clients/src/main/java/org/apache/kafka/common/network/Selector.java, line 483
> > <https://reviews.apache.org/r/29523/diff/20/?file=813232#file813232line483>
> >
> >     Instead of "node-"+node, it probably can just be node.

not sure.. node is a integer value (0,1). I felt node-0, node-1 are more informative, than simple 0, 1. 

Jconsole MBean Tree view looks like this

kafka.producer
  --> ProducerNodeMetrics
       --> node-0
              --> metric-1
       --> node-1
              --> metric-1
             
Is it Ok? If required i can change this?


> On Jan. 8, 2015, 9:21 p.m., Jun Rao wrote:
> > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java, line 336
> > <https://reviews.apache.org/r/29523/diff/20/?file=813222#file813222line336>
> >
> >     Should this be passed in? Or perhaps we can define this as a constant and reference it here.

Sender is internal to producer.. So the group name is hard-coded.


- Manikumar Reddy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29523/#review67246
-----------------------------------------------------------


On Jan. 9, 2015, 6:15 p.m., Manikumar Reddy O wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29523/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 6:15 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1723
>     https://issues.apache.org/jira/browse/KAFKA-1723
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Standard JMX MBean Naming is implemented;Addresing Jun's comments
> 
> 
> Diffs
> -----
> 
>   build.gradle ba52288031e2abc70e35e9297a4423dd5025950b 
>   clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java 1bce50185273dbdbc131fbc9c7f5f3e9c346517a 
>   clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 7f8a41c4bf437711685a8271a4d3c83a176dd957 
>   clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java 8cab16c0a0bdb671fea1fc2fc2694247f66cc971 
>   clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 3053f2745c8e5f6e3b75826d3749656f150878db 
>   clients/src/main/java/org/apache/kafka/clients/producer/Producer.java 5baa6062bd9ba8a7d38058856ed2d831fae491f0 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java aa91e1444a49c55870b9a7a32086fa2b04471fba 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java c15485d1af304ef53691d478f113f332fe67af77 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 84a7a07269c51ccc22ebb4ff9797292d07ba778e 
>   clients/src/main/java/org/apache/kafka/common/Metric.java b023e8e7c486adf21ed9a554085ab8ad7f3ee038 
>   clients/src/main/java/org/apache/kafka/common/metrics/CompoundStat.java 29185a6a90d0035d650c7e56ce612a0878cb115c 
>   clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java 3c312011a7ff7e79c277a89048e7e62ebd6078db 
>   clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java a7458b50cb16fbb2b31b857d5b359e65258bbf08 
>   clients/src/main/java/org/apache/kafka/common/metrics/MetricName.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java 49be4019ac03835701c49646920766228ac7ffe9 
>   clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java 25c1faf2887ea02708c1f5b5f822f5299ed86bd6 
>   clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentile.java 7365ceb39072a6a1ecf533f5a20830ed1f2cfc72 
>   clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentiles.java c70d577ada8c099533d4f4ed2e86d37e0a6e6676 
>   clients/src/main/java/org/apache/kafka/common/network/Selector.java 4dd2cdf773f7eb01a93d7f994383088960303dfc 
>   clients/src/test/java/org/apache/kafka/clients/producer/BufferPoolTest.java fe3c13f319d48b89a4f26b6d78c2c3e31cc50d7e 
>   clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java 2c9932401d573549c40f16fda8c4e3e11309cb85 
>   clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java ef2ca65cabe97b909f17b62027a1bb06827e88fe 
>   clients/src/test/java/org/apache/kafka/common/metrics/JmxReporterTest.java 2f43c49450e1a3d671bd17417dc42941f1858750 
>   clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java 19bea0f1fa1ebf15d86623015ec909b0155e4bd3 
>   clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
>   clients/src/test/java/org/apache/kafka/test/MetricsBench.java 9d98c1148255455fd801043b59b98fed9d0b76b3 
> 
> Diff: https://reviews.apache.org/r/29523/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Manikumar Reddy O
> 
>

Re: Review Request 29523: Patch for KAFKA-1723

Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29523/#review67246
-----------------------------------------------------------


Thanks for the patch. Looks good overall. A few minor comments below.


clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java
<https://reviews.apache.org/r/29523/#comment111226>

    Should use lower case param names.



clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
<https://reviews.apache.org/r/29523/#comment111234>

    Should this be passed in? Or perhaps we can define this as a constant and reference it here.



clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java
<https://reviews.apache.org/r/29523/#comment111198>

    Should we use message-size-avg as the metrics name?



clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java
<https://reviews.apache.org/r/29523/#comment111211>

    Param name is no longer valid. This applies to a few other places as well.



clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java
<https://reviews.apache.org/r/29523/#comment111203>

    Do we need to make this synchronized since the other addMetric is already synchronized.



clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java
<https://reviews.apache.org/r/29523/#comment111212>

    Param name is no longer valid. This applies to a few other places as well.



clients/src/main/java/org/apache/kafka/common/network/Selector.java
<https://reviews.apache.org/r/29523/#comment111251>

    It's probably better to just reference a "ProducerMetrics" constant.



clients/src/main/java/org/apache/kafka/common/network/Selector.java
<https://reviews.apache.org/r/29523/#comment111252>

    Instead of "node-"+node, it probably can just be node.


- Jun Rao


On Jan. 8, 2015, 4:34 p.m., Manikumar Reddy O wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29523/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2015, 4:34 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1723
>     https://issues.apache.org/jira/browse/KAFKA-1723
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Standard JMX MBean Naming is implemented;Addresing Jay's comments
> 
> 
> Diffs
> -----
> 
>   clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java 1bce50185273dbdbc131fbc9c7f5f3e9c346517a 
>   clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 7f8a41c4bf437711685a8271a4d3c83a176dd957 
>   clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java 8cab16c0a0bdb671fea1fc2fc2694247f66cc971 
>   clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 3053f2745c8e5f6e3b75826d3749656f150878db 
>   clients/src/main/java/org/apache/kafka/clients/producer/Producer.java 5baa6062bd9ba8a7d38058856ed2d831fae491f0 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java aa91e1444a49c55870b9a7a32086fa2b04471fba 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java c15485d1af304ef53691d478f113f332fe67af77 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 84a7a07269c51ccc22ebb4ff9797292d07ba778e 
>   clients/src/main/java/org/apache/kafka/common/Metric.java b023e8e7c486adf21ed9a554085ab8ad7f3ee038 
>   clients/src/main/java/org/apache/kafka/common/metrics/CompoundStat.java 29185a6a90d0035d650c7e56ce612a0878cb115c 
>   clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java 3c312011a7ff7e79c277a89048e7e62ebd6078db 
>   clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java a7458b50cb16fbb2b31b857d5b359e65258bbf08 
>   clients/src/main/java/org/apache/kafka/common/metrics/MetricName.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java 49be4019ac03835701c49646920766228ac7ffe9 
>   clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java 25c1faf2887ea02708c1f5b5f822f5299ed86bd6 
>   clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentile.java 7365ceb39072a6a1ecf533f5a20830ed1f2cfc72 
>   clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentiles.java c70d577ada8c099533d4f4ed2e86d37e0a6e6676 
>   clients/src/main/java/org/apache/kafka/common/network/Selector.java 4dd2cdf773f7eb01a93d7f994383088960303dfc 
>   clients/src/test/java/org/apache/kafka/clients/producer/BufferPoolTest.java fe3c13f319d48b89a4f26b6d78c2c3e31cc50d7e 
>   clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java 2c9932401d573549c40f16fda8c4e3e11309cb85 
>   clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java ef2ca65cabe97b909f17b62027a1bb06827e88fe 
>   clients/src/test/java/org/apache/kafka/common/metrics/JmxReporterTest.java 2f43c49450e1a3d671bd17417dc42941f1858750 
>   clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java 19bea0f1fa1ebf15d86623015ec909b0155e4bd3 
>   clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
>   clients/src/test/java/org/apache/kafka/test/MetricsBench.java 9d98c1148255455fd801043b59b98fed9d0b76b3 
> 
> Diff: https://reviews.apache.org/r/29523/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Manikumar Reddy O
> 
>

Re: Review Request 29523: Patch for KAFKA-1723

Posted by Jay Kreps <bo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29523/#review67309
-----------------------------------------------------------



clients/src/main/java/org/apache/kafka/common/metrics/MetricName.java
<https://reviews.apache.org/r/29523/#comment111305>

    Since this is a public class can you add some javadoc that describes the basic data model and gives an example to help explain it? Basically someone who encounters this class from the Producer or Consumer interface should be able to figure out how to interpret things like group and tag.


- Jay Kreps


On Jan. 8, 2015, 4:34 p.m., Manikumar Reddy O wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29523/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2015, 4:34 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1723
>     https://issues.apache.org/jira/browse/KAFKA-1723
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Standard JMX MBean Naming is implemented;Addresing Jay's comments
> 
> 
> Diffs
> -----
> 
>   clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java 1bce50185273dbdbc131fbc9c7f5f3e9c346517a 
>   clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 7f8a41c4bf437711685a8271a4d3c83a176dd957 
>   clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java 8cab16c0a0bdb671fea1fc2fc2694247f66cc971 
>   clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 3053f2745c8e5f6e3b75826d3749656f150878db 
>   clients/src/main/java/org/apache/kafka/clients/producer/Producer.java 5baa6062bd9ba8a7d38058856ed2d831fae491f0 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java aa91e1444a49c55870b9a7a32086fa2b04471fba 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java c15485d1af304ef53691d478f113f332fe67af77 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 84a7a07269c51ccc22ebb4ff9797292d07ba778e 
>   clients/src/main/java/org/apache/kafka/common/Metric.java b023e8e7c486adf21ed9a554085ab8ad7f3ee038 
>   clients/src/main/java/org/apache/kafka/common/metrics/CompoundStat.java 29185a6a90d0035d650c7e56ce612a0878cb115c 
>   clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java 3c312011a7ff7e79c277a89048e7e62ebd6078db 
>   clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java a7458b50cb16fbb2b31b857d5b359e65258bbf08 
>   clients/src/main/java/org/apache/kafka/common/metrics/MetricName.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java 49be4019ac03835701c49646920766228ac7ffe9 
>   clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java 25c1faf2887ea02708c1f5b5f822f5299ed86bd6 
>   clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentile.java 7365ceb39072a6a1ecf533f5a20830ed1f2cfc72 
>   clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentiles.java c70d577ada8c099533d4f4ed2e86d37e0a6e6676 
>   clients/src/main/java/org/apache/kafka/common/network/Selector.java 4dd2cdf773f7eb01a93d7f994383088960303dfc 
>   clients/src/test/java/org/apache/kafka/clients/producer/BufferPoolTest.java fe3c13f319d48b89a4f26b6d78c2c3e31cc50d7e 
>   clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java 2c9932401d573549c40f16fda8c4e3e11309cb85 
>   clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java ef2ca65cabe97b909f17b62027a1bb06827e88fe 
>   clients/src/test/java/org/apache/kafka/common/metrics/JmxReporterTest.java 2f43c49450e1a3d671bd17417dc42941f1858750 
>   clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java 19bea0f1fa1ebf15d86623015ec909b0155e4bd3 
>   clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
>   clients/src/test/java/org/apache/kafka/test/MetricsBench.java 9d98c1148255455fd801043b59b98fed9d0b76b3 
> 
> Diff: https://reviews.apache.org/r/29523/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Manikumar Reddy O
> 
>

Re: Review Request 29523: Patch for KAFKA-1723

Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29523/#review67446
-----------------------------------------------------------


Thanks for the new patch. Looks good. Just a few more minor comments.


clients/src/main/java/org/apache/kafka/clients/producer/Producer.java
<https://reviews.apache.org/r/29523/#comment111471>

    Since both MetricName and Metric are part of the public api, we need to change the gradle build file to include these two classes in the generated javadoc.



clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java
<https://reviews.apache.org/r/29523/#comment111469>

    Incorrect param group.



clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java
<https://reviews.apache.org/r/29523/#comment111470>

    It seems that we pass in the group name here whereas in other places we just define a local constant. It would be good to make this consistent: either the group is passed in or is just defined locally.


- Jun Rao


On Jan. 9, 2015, 8:56 a.m., Manikumar Reddy O wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29523/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 8:56 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1723
>     https://issues.apache.org/jira/browse/KAFKA-1723
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Standard JMX MBean Naming is implemented;Addresing Jun's comments
> 
> 
> Diffs
> -----
> 
>   clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java 1bce50185273dbdbc131fbc9c7f5f3e9c346517a 
>   clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 7f8a41c4bf437711685a8271a4d3c83a176dd957 
>   clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java 8cab16c0a0bdb671fea1fc2fc2694247f66cc971 
>   clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 3053f2745c8e5f6e3b75826d3749656f150878db 
>   clients/src/main/java/org/apache/kafka/clients/producer/Producer.java 5baa6062bd9ba8a7d38058856ed2d831fae491f0 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java aa91e1444a49c55870b9a7a32086fa2b04471fba 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java c15485d1af304ef53691d478f113f332fe67af77 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 84a7a07269c51ccc22ebb4ff9797292d07ba778e 
>   clients/src/main/java/org/apache/kafka/common/Metric.java b023e8e7c486adf21ed9a554085ab8ad7f3ee038 
>   clients/src/main/java/org/apache/kafka/common/metrics/CompoundStat.java 29185a6a90d0035d650c7e56ce612a0878cb115c 
>   clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java 3c312011a7ff7e79c277a89048e7e62ebd6078db 
>   clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java a7458b50cb16fbb2b31b857d5b359e65258bbf08 
>   clients/src/main/java/org/apache/kafka/common/metrics/MetricName.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java 49be4019ac03835701c49646920766228ac7ffe9 
>   clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java 25c1faf2887ea02708c1f5b5f822f5299ed86bd6 
>   clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentile.java 7365ceb39072a6a1ecf533f5a20830ed1f2cfc72 
>   clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentiles.java c70d577ada8c099533d4f4ed2e86d37e0a6e6676 
>   clients/src/main/java/org/apache/kafka/common/network/Selector.java 4dd2cdf773f7eb01a93d7f994383088960303dfc 
>   clients/src/test/java/org/apache/kafka/clients/producer/BufferPoolTest.java fe3c13f319d48b89a4f26b6d78c2c3e31cc50d7e 
>   clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java 2c9932401d573549c40f16fda8c4e3e11309cb85 
>   clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java ef2ca65cabe97b909f17b62027a1bb06827e88fe 
>   clients/src/test/java/org/apache/kafka/common/metrics/JmxReporterTest.java 2f43c49450e1a3d671bd17417dc42941f1858750 
>   clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java 19bea0f1fa1ebf15d86623015ec909b0155e4bd3 
>   clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
>   clients/src/test/java/org/apache/kafka/test/MetricsBench.java 9d98c1148255455fd801043b59b98fed9d0b76b3 
> 
> Diff: https://reviews.apache.org/r/29523/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Manikumar Reddy O
> 
>

Re: Review Request 29523: Patch for KAFKA-1723

Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29523/#review68110
-----------------------------------------------------------

Ship it!


- Jun Rao


On Jan. 14, 2015, 8:02 a.m., Manikumar Reddy O wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29523/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2015, 8:02 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1723
>     https://issues.apache.org/jira/browse/KAFKA-1723
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> corrected javadocs to compile in java 8
> 
> 
> Diffs
> -----
> 
>   clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java c79149a715fcbf40afb06f0c9f9e550143c81bdd 
>   clients/src/main/java/org/apache/kafka/common/MetricName.java 4e810d56b753b7eeb662b99af5cdf36bcfba7ea7 
> 
> Diff: https://reviews.apache.org/r/29523/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Manikumar Reddy O
> 
>

Re: Review Request 29523: Patch for KAFKA-1723

Posted by Manikumar Reddy O <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29523/
-----------------------------------------------------------

(Updated Jan. 14, 2015, 8:02 a.m.)


Review request for kafka.


Bugs: KAFKA-1723
    https://issues.apache.org/jira/browse/KAFKA-1723


Repository: kafka


Description (updated)
-------

corrected javadocs to compile in java 8


Diffs (updated)
-----

  clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java c79149a715fcbf40afb06f0c9f9e550143c81bdd 
  clients/src/main/java/org/apache/kafka/common/MetricName.java 4e810d56b753b7eeb662b99af5cdf36bcfba7ea7 

Diff: https://reviews.apache.org/r/29523/diff/


Testing
-------


Thanks,

Manikumar Reddy O

Re: Review Request 29523: Patch for KAFKA-1723

Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29523/#review67479
-----------------------------------------------------------

Ship it!


Thanks for the patch. Checked the jmx and looks good to me. Will wait a bit to see if you come up with a better way of using the metrics through the api.

- Jun Rao


On Jan. 9, 2015, 6:15 p.m., Manikumar Reddy O wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29523/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 6:15 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1723
>     https://issues.apache.org/jira/browse/KAFKA-1723
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Standard JMX MBean Naming is implemented;Addresing Jun's comments
> 
> 
> Diffs
> -----
> 
>   build.gradle ba52288031e2abc70e35e9297a4423dd5025950b 
>   clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java 1bce50185273dbdbc131fbc9c7f5f3e9c346517a 
>   clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 7f8a41c4bf437711685a8271a4d3c83a176dd957 
>   clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java 8cab16c0a0bdb671fea1fc2fc2694247f66cc971 
>   clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 3053f2745c8e5f6e3b75826d3749656f150878db 
>   clients/src/main/java/org/apache/kafka/clients/producer/Producer.java 5baa6062bd9ba8a7d38058856ed2d831fae491f0 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java aa91e1444a49c55870b9a7a32086fa2b04471fba 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java c15485d1af304ef53691d478f113f332fe67af77 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 84a7a07269c51ccc22ebb4ff9797292d07ba778e 
>   clients/src/main/java/org/apache/kafka/common/Metric.java b023e8e7c486adf21ed9a554085ab8ad7f3ee038 
>   clients/src/main/java/org/apache/kafka/common/metrics/CompoundStat.java 29185a6a90d0035d650c7e56ce612a0878cb115c 
>   clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java 3c312011a7ff7e79c277a89048e7e62ebd6078db 
>   clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java a7458b50cb16fbb2b31b857d5b359e65258bbf08 
>   clients/src/main/java/org/apache/kafka/common/metrics/MetricName.java PRE-CREATION 
>   clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java 49be4019ac03835701c49646920766228ac7ffe9 
>   clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java 25c1faf2887ea02708c1f5b5f822f5299ed86bd6 
>   clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentile.java 7365ceb39072a6a1ecf533f5a20830ed1f2cfc72 
>   clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentiles.java c70d577ada8c099533d4f4ed2e86d37e0a6e6676 
>   clients/src/main/java/org/apache/kafka/common/network/Selector.java 4dd2cdf773f7eb01a93d7f994383088960303dfc 
>   clients/src/test/java/org/apache/kafka/clients/producer/BufferPoolTest.java fe3c13f319d48b89a4f26b6d78c2c3e31cc50d7e 
>   clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java 2c9932401d573549c40f16fda8c4e3e11309cb85 
>   clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java ef2ca65cabe97b909f17b62027a1bb06827e88fe 
>   clients/src/test/java/org/apache/kafka/common/metrics/JmxReporterTest.java 2f43c49450e1a3d671bd17417dc42941f1858750 
>   clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java 19bea0f1fa1ebf15d86623015ec909b0155e4bd3 
>   clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
>   clients/src/test/java/org/apache/kafka/test/MetricsBench.java 9d98c1148255455fd801043b59b98fed9d0b76b3 
> 
> Diff: https://reviews.apache.org/r/29523/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Manikumar Reddy O
> 
>

Re: Review Request 29523: Patch for KAFKA-1723

Posted by Manikumar Reddy O <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29523/
-----------------------------------------------------------

(Updated Jan. 9, 2015, 6:15 p.m.)


Review request for kafka.


Bugs: KAFKA-1723
    https://issues.apache.org/jira/browse/KAFKA-1723


Repository: kafka


Description
-------

Standard JMX MBean Naming is implemented;Addresing Jun's comments


Diffs (updated)
-----

  build.gradle ba52288031e2abc70e35e9297a4423dd5025950b 
  clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java 1bce50185273dbdbc131fbc9c7f5f3e9c346517a 
  clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 7f8a41c4bf437711685a8271a4d3c83a176dd957 
  clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java 8cab16c0a0bdb671fea1fc2fc2694247f66cc971 
  clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 3053f2745c8e5f6e3b75826d3749656f150878db 
  clients/src/main/java/org/apache/kafka/clients/producer/Producer.java 5baa6062bd9ba8a7d38058856ed2d831fae491f0 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java aa91e1444a49c55870b9a7a32086fa2b04471fba 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java c15485d1af304ef53691d478f113f332fe67af77 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 84a7a07269c51ccc22ebb4ff9797292d07ba778e 
  clients/src/main/java/org/apache/kafka/common/Metric.java b023e8e7c486adf21ed9a554085ab8ad7f3ee038 
  clients/src/main/java/org/apache/kafka/common/metrics/CompoundStat.java 29185a6a90d0035d650c7e56ce612a0878cb115c 
  clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java 3c312011a7ff7e79c277a89048e7e62ebd6078db 
  clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java a7458b50cb16fbb2b31b857d5b359e65258bbf08 
  clients/src/main/java/org/apache/kafka/common/metrics/MetricName.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java 49be4019ac03835701c49646920766228ac7ffe9 
  clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java 25c1faf2887ea02708c1f5b5f822f5299ed86bd6 
  clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentile.java 7365ceb39072a6a1ecf533f5a20830ed1f2cfc72 
  clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentiles.java c70d577ada8c099533d4f4ed2e86d37e0a6e6676 
  clients/src/main/java/org/apache/kafka/common/network/Selector.java 4dd2cdf773f7eb01a93d7f994383088960303dfc 
  clients/src/test/java/org/apache/kafka/clients/producer/BufferPoolTest.java fe3c13f319d48b89a4f26b6d78c2c3e31cc50d7e 
  clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java 2c9932401d573549c40f16fda8c4e3e11309cb85 
  clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java ef2ca65cabe97b909f17b62027a1bb06827e88fe 
  clients/src/test/java/org/apache/kafka/common/metrics/JmxReporterTest.java 2f43c49450e1a3d671bd17417dc42941f1858750 
  clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java 19bea0f1fa1ebf15d86623015ec909b0155e4bd3 
  clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
  clients/src/test/java/org/apache/kafka/test/MetricsBench.java 9d98c1148255455fd801043b59b98fed9d0b76b3 

Diff: https://reviews.apache.org/r/29523/diff/


Testing
-------


Thanks,

Manikumar Reddy O

Re: Review Request 29523: Patch for KAFKA-1723

Posted by Manikumar Reddy O <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29523/
-----------------------------------------------------------

(Updated Jan. 9, 2015, 6:12 p.m.)


Review request for kafka.


Bugs: KAFKA-1723
    https://issues.apache.org/jira/browse/KAFKA-1723


Repository: kafka


Description
-------

Standard JMX MBean Naming is implemented;Addresing Jun's comments


Diffs (updated)
-----

  build.gradle ba52288031e2abc70e35e9297a4423dd5025950b 
  clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java 1bce50185273dbdbc131fbc9c7f5f3e9c346517a 
  clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 7f8a41c4bf437711685a8271a4d3c83a176dd957 
  clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java 8cab16c0a0bdb671fea1fc2fc2694247f66cc971 
  clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 3053f2745c8e5f6e3b75826d3749656f150878db 
  clients/src/main/java/org/apache/kafka/clients/producer/Producer.java 5baa6062bd9ba8a7d38058856ed2d831fae491f0 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java aa91e1444a49c55870b9a7a32086fa2b04471fba 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java c15485d1af304ef53691d478f113f332fe67af77 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 84a7a07269c51ccc22ebb4ff9797292d07ba778e 
  clients/src/main/java/org/apache/kafka/common/Metric.java b023e8e7c486adf21ed9a554085ab8ad7f3ee038 
  clients/src/main/java/org/apache/kafka/common/metrics/CompoundStat.java 29185a6a90d0035d650c7e56ce612a0878cb115c 
  clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java 3c312011a7ff7e79c277a89048e7e62ebd6078db 
  clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java a7458b50cb16fbb2b31b857d5b359e65258bbf08 
  clients/src/main/java/org/apache/kafka/common/metrics/MetricName.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java 49be4019ac03835701c49646920766228ac7ffe9 
  clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java 25c1faf2887ea02708c1f5b5f822f5299ed86bd6 
  clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentile.java 7365ceb39072a6a1ecf533f5a20830ed1f2cfc72 
  clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentiles.java c70d577ada8c099533d4f4ed2e86d37e0a6e6676 
  clients/src/main/java/org/apache/kafka/common/network/Selector.java 4dd2cdf773f7eb01a93d7f994383088960303dfc 
  clients/src/test/java/org/apache/kafka/clients/producer/BufferPoolTest.java fe3c13f319d48b89a4f26b6d78c2c3e31cc50d7e 
  clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java 2c9932401d573549c40f16fda8c4e3e11309cb85 
  clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java ef2ca65cabe97b909f17b62027a1bb06827e88fe 
  clients/src/test/java/org/apache/kafka/common/metrics/JmxReporterTest.java 2f43c49450e1a3d671bd17417dc42941f1858750 
  clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java 19bea0f1fa1ebf15d86623015ec909b0155e4bd3 
  clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
  clients/src/test/java/org/apache/kafka/test/MetricsBench.java 9d98c1148255455fd801043b59b98fed9d0b76b3 

Diff: https://reviews.apache.org/r/29523/diff/


Testing
-------


Thanks,

Manikumar Reddy O

Re: Review Request 29523: Patch for KAFKA-1723

Posted by Manikumar Reddy O <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29523/
-----------------------------------------------------------

(Updated Jan. 9, 2015, 8:56 a.m.)


Review request for kafka.


Bugs: KAFKA-1723
    https://issues.apache.org/jira/browse/KAFKA-1723


Repository: kafka


Description (updated)
-------

Standard JMX MBean Naming is implemented;Addresing Jun's comments


Diffs (updated)
-----

  clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java 1bce50185273dbdbc131fbc9c7f5f3e9c346517a 
  clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 7f8a41c4bf437711685a8271a4d3c83a176dd957 
  clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java 8cab16c0a0bdb671fea1fc2fc2694247f66cc971 
  clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 3053f2745c8e5f6e3b75826d3749656f150878db 
  clients/src/main/java/org/apache/kafka/clients/producer/Producer.java 5baa6062bd9ba8a7d38058856ed2d831fae491f0 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java aa91e1444a49c55870b9a7a32086fa2b04471fba 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java c15485d1af304ef53691d478f113f332fe67af77 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 84a7a07269c51ccc22ebb4ff9797292d07ba778e 
  clients/src/main/java/org/apache/kafka/common/Metric.java b023e8e7c486adf21ed9a554085ab8ad7f3ee038 
  clients/src/main/java/org/apache/kafka/common/metrics/CompoundStat.java 29185a6a90d0035d650c7e56ce612a0878cb115c 
  clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java 3c312011a7ff7e79c277a89048e7e62ebd6078db 
  clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java a7458b50cb16fbb2b31b857d5b359e65258bbf08 
  clients/src/main/java/org/apache/kafka/common/metrics/MetricName.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java 49be4019ac03835701c49646920766228ac7ffe9 
  clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java 25c1faf2887ea02708c1f5b5f822f5299ed86bd6 
  clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentile.java 7365ceb39072a6a1ecf533f5a20830ed1f2cfc72 
  clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentiles.java c70d577ada8c099533d4f4ed2e86d37e0a6e6676 
  clients/src/main/java/org/apache/kafka/common/network/Selector.java 4dd2cdf773f7eb01a93d7f994383088960303dfc 
  clients/src/test/java/org/apache/kafka/clients/producer/BufferPoolTest.java fe3c13f319d48b89a4f26b6d78c2c3e31cc50d7e 
  clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java 2c9932401d573549c40f16fda8c4e3e11309cb85 
  clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java ef2ca65cabe97b909f17b62027a1bb06827e88fe 
  clients/src/test/java/org/apache/kafka/common/metrics/JmxReporterTest.java 2f43c49450e1a3d671bd17417dc42941f1858750 
  clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java 19bea0f1fa1ebf15d86623015ec909b0155e4bd3 
  clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
  clients/src/test/java/org/apache/kafka/test/MetricsBench.java 9d98c1148255455fd801043b59b98fed9d0b76b3 

Diff: https://reviews.apache.org/r/29523/diff/


Testing
-------


Thanks,

Manikumar Reddy O

Re: Review Request 29523: Patch for KAFKA-1723

Posted by Manikumar Reddy O <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29523/
-----------------------------------------------------------

(Updated Jan. 8, 2015, 4:34 p.m.)


Review request for kafka.


Bugs: KAFKA-1723
    https://issues.apache.org/jira/browse/KAFKA-1723


Repository: kafka


Description
-------

Standard JMX MBean Naming is implemented;Addresing Jay's comments


Diffs (updated)
-----

  clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java 1bce50185273dbdbc131fbc9c7f5f3e9c346517a 
  clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 7f8a41c4bf437711685a8271a4d3c83a176dd957 
  clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java 8cab16c0a0bdb671fea1fc2fc2694247f66cc971 
  clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 3053f2745c8e5f6e3b75826d3749656f150878db 
  clients/src/main/java/org/apache/kafka/clients/producer/Producer.java 5baa6062bd9ba8a7d38058856ed2d831fae491f0 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java aa91e1444a49c55870b9a7a32086fa2b04471fba 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java c15485d1af304ef53691d478f113f332fe67af77 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 84a7a07269c51ccc22ebb4ff9797292d07ba778e 
  clients/src/main/java/org/apache/kafka/common/Metric.java b023e8e7c486adf21ed9a554085ab8ad7f3ee038 
  clients/src/main/java/org/apache/kafka/common/metrics/CompoundStat.java 29185a6a90d0035d650c7e56ce612a0878cb115c 
  clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java 3c312011a7ff7e79c277a89048e7e62ebd6078db 
  clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java a7458b50cb16fbb2b31b857d5b359e65258bbf08 
  clients/src/main/java/org/apache/kafka/common/metrics/MetricName.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java 49be4019ac03835701c49646920766228ac7ffe9 
  clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java 25c1faf2887ea02708c1f5b5f822f5299ed86bd6 
  clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentile.java 7365ceb39072a6a1ecf533f5a20830ed1f2cfc72 
  clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentiles.java c70d577ada8c099533d4f4ed2e86d37e0a6e6676 
  clients/src/main/java/org/apache/kafka/common/network/Selector.java 4dd2cdf773f7eb01a93d7f994383088960303dfc 
  clients/src/test/java/org/apache/kafka/clients/producer/BufferPoolTest.java fe3c13f319d48b89a4f26b6d78c2c3e31cc50d7e 
  clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java 2c9932401d573549c40f16fda8c4e3e11309cb85 
  clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java ef2ca65cabe97b909f17b62027a1bb06827e88fe 
  clients/src/test/java/org/apache/kafka/common/metrics/JmxReporterTest.java 2f43c49450e1a3d671bd17417dc42941f1858750 
  clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java 19bea0f1fa1ebf15d86623015ec909b0155e4bd3 
  clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
  clients/src/test/java/org/apache/kafka/test/MetricsBench.java 9d98c1148255455fd801043b59b98fed9d0b76b3 

Diff: https://reviews.apache.org/r/29523/diff/


Testing
-------


Thanks,

Manikumar Reddy O

Re: Review Request 29523: Patch for KAFKA-1723

Posted by Manikumar Reddy O <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29523/
-----------------------------------------------------------

(Updated Jan. 8, 2015, 4:13 p.m.)


Review request for kafka.


Bugs: KAFKA-1723
    https://issues.apache.org/jira/browse/KAFKA-1723


Repository: kafka


Description (updated)
-------

Standard JMX MBean Naming is implemented;Addresing Jay's comments


Diffs (updated)
-----

  clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java 1bce50185273dbdbc131fbc9c7f5f3e9c346517a 
  clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 7f8a41c4bf437711685a8271a4d3c83a176dd957 
  clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java 8cab16c0a0bdb671fea1fc2fc2694247f66cc971 
  clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 3053f2745c8e5f6e3b75826d3749656f150878db 
  clients/src/main/java/org/apache/kafka/clients/producer/Producer.java 5baa6062bd9ba8a7d38058856ed2d831fae491f0 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java aa91e1444a49c55870b9a7a32086fa2b04471fba 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java c15485d1af304ef53691d478f113f332fe67af77 
  clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 84a7a07269c51ccc22ebb4ff9797292d07ba778e 
  clients/src/main/java/org/apache/kafka/common/Metric.java b023e8e7c486adf21ed9a554085ab8ad7f3ee038 
  clients/src/main/java/org/apache/kafka/common/metrics/CompoundStat.java 29185a6a90d0035d650c7e56ce612a0878cb115c 
  clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java 3c312011a7ff7e79c277a89048e7e62ebd6078db 
  clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java a7458b50cb16fbb2b31b857d5b359e65258bbf08 
  clients/src/main/java/org/apache/kafka/common/metrics/MetricName.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java 49be4019ac03835701c49646920766228ac7ffe9 
  clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java 25c1faf2887ea02708c1f5b5f822f5299ed86bd6 
  clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentile.java 7365ceb39072a6a1ecf533f5a20830ed1f2cfc72 
  clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentiles.java c70d577ada8c099533d4f4ed2e86d37e0a6e6676 
  clients/src/main/java/org/apache/kafka/common/network/Selector.java 4dd2cdf773f7eb01a93d7f994383088960303dfc 
  clients/src/test/java/org/apache/kafka/clients/producer/BufferPoolTest.java fe3c13f319d48b89a4f26b6d78c2c3e31cc50d7e 
  clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java 2c9932401d573549c40f16fda8c4e3e11309cb85 
  clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java ef2ca65cabe97b909f17b62027a1bb06827e88fe 
  clients/src/test/java/org/apache/kafka/common/metrics/JmxReporterTest.java 2f43c49450e1a3d671bd17417dc42941f1858750 
  clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java 19bea0f1fa1ebf15d86623015ec909b0155e4bd3 
  clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 
  clients/src/test/java/org/apache/kafka/test/MetricsBench.java 9d98c1148255455fd801043b59b98fed9d0b76b3 

Diff: https://reviews.apache.org/r/29523/diff/


Testing
-------


Thanks,

Manikumar Reddy O