[jira] [Resolved] (ARROW-1467) [JAVA]: Fix reset() and allocateNew() in Nullable Value Vectors template

["Wes McKinney (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARROW-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wes McKinney resolved ARROW-1467.
---------------------------------
    Resolution: Fixed

Issue resolved by pull request 1052
[https://github.com/apache/arrow/pull/1052]

> [JAVA]: Fix reset() and allocateNew() in Nullable Value Vectors template
> ------------------------------------------------------------------------
>
>                 Key: ARROW-1467
>                 URL: https://issues.apache.org/jira/browse/ARROW-1467
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Java - Vectors
>            Reporter: Siddharth Teotia
>            Assignee: Siddharth Teotia
>
> (1) 
> allocateNew() in NullableValueVectors allocates extra memory for the validity vector of fixed-width vectors. Instead of doing bits.allocateNew(valueCount + 1), we should simply do bits.allocateNew(valueCount). 
> AFAIK, the only case where we need an additional valueCount is for the offsetVector and we already do that. Additional valueCount for the validity vector is not needed.
> (2)
> reset() method should call reset() on the underlying value vector as well to re-initialize the state (allocation monitor, reader index etc) and zero out the buffers. Right now we just reset the validity vector.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)