You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/05 00:19:42 UTC
[GitHub] [incubator-nuttx] btashton opened a new pull request #3317: Update python scripts to py3 and lint all of them againt Black
btashton opened a new pull request #3317:
URL: https://github.com/apache/incubator-nuttx/pull/3317
## Summary
We have a handful of python script that had not been updated to support python3. We also had python code style that was all over the place including using tabs. For consistency I enabled Black (https://github.com/psf/black) which is from the Python Software Foundation. It is highly opinionated, but also is able to auto format the code so you do not have to spend too much time sorting it out.
Also I removed the xmodem.py script since this is a copy of the upstream project. We should just have people install it (updated the readme to include a note about this).
## Impact
Python scripts can not be checked in CI for code style and are also python3 compliant.
## Testing
Basic testing of the scripts that I am able to use. The ide_exporter.py I think we should consider dropping because I think we already dropped support for native support of IAR and Keil.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #3317: Update python scripts to py3 and lint all of them againt Black
Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #3317:
URL: https://github.com/apache/incubator-nuttx/pull/3317#discussion_r606872867
##########
File path: .github/workflows/lint.yml
##########
@@ -1,15 +1,15 @@
-name: ❄️ Lint
Review comment:
If you change this name you need to update the cancel workflow, where this string is used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #3317: Update python scripts to py3 and lint all of them againt Black
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #3317:
URL: https://github.com/apache/incubator-nuttx/pull/3317#discussion_r606873513
##########
File path: .github/workflows/lint.yml
##########
@@ -1,15 +1,15 @@
-name: ❄️ Lint
Review comment:
Ah I had missed that, just pushed the fix. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #3317: Update python scripts to py3 and lint all of them againt Black
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #3317:
URL: https://github.com/apache/incubator-nuttx/pull/3317#issuecomment-813576987
I will take a look this evening, I had removed the regex to limit the search but I can probably open it up. My guess is it is including all the .git files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #3317: Update python scripts to py3 and lint all of them againt Black
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #3317:
URL: https://github.com/apache/incubator-nuttx/pull/3317#issuecomment-813569776
Look at this one for example:
https://github.com/apache/incubator-nuttx/runs/2271096705?check_suite_focus=true
My guess is it takes a lot to traverse all files. Do we really need to do that? That lint action seems to be extremely inefficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #3317: Update python scripts to py3 and lint all of them againt Black
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #3317:
URL: https://github.com/apache/incubator-nuttx/pull/3317#issuecomment-813568260
@btashton the lint workflow is taking a lot of time and is blocking CI. Could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3317: Update python scripts to py3 and lint all of them againt Black
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #3317:
URL: https://github.com/apache/incubator-nuttx/pull/3317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org