You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/14 18:12:26 UTC

[GitHub] [incubator-superset] rusackas commented on a change in pull request #10853: docs(style): make more responsive for mobile

rusackas commented on a change in pull request #10853:
URL: https://github.com/apache/incubator-superset/pull/10853#discussion_r488128080



##########
File path: docs/src/pages/resources.tsx
##########
@@ -228,17 +186,18 @@ const Resources = () => {
             </Modal>
             <h2>Videos</h2>
             <Card>
-              {youtubeIds.map(([idx, ids, cardTitle]) => (
+              {youtubeIds.map(([idx, ids, title]) => (

Review comment:
       @mistercrunch @pkdotson NIT that shouldn't hold up this PR: We can remove the index from the data arrays, and let the `map` provide it intrinsically, e.g. `{youtubeIds.map(([ids, title], idx) => (`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org