You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by rh...@apache.org on 2012/12/03 13:46:09 UTC
svn commit: r1416494 - /subversion/branches/1.7.x/STATUS
Author: rhuijben
Date: Mon Dec 3 12:46:08 2012
New Revision: 1416494
URL: http://svn.apache.org/viewvc?rev=1416494&view=rev
Log:
* STATUS: Cast some votes, approving r1407597 which the bot can't merge.
Modified:
subversion/branches/1.7.x/STATUS
Modified: subversion/branches/1.7.x/STATUS
URL: http://svn.apache.org/viewvc/subversion/branches/1.7.x/STATUS?rev=1416494&r1=1416493&r2=1416494&view=diff
==============================================================================
--- subversion/branches/1.7.x/STATUS (original)
+++ subversion/branches/1.7.x/STATUS Mon Dec 3 12:46:08 2012
@@ -79,21 +79,6 @@ Candidate changes:
Votes:
+1: philip, rhuijben
- * r1407597
- Fix issue #4079 ("svnmucc cp rev arg" SEGV).
- Justification:
- "Segmentation fault (core dumped)" is considered sub-par error reporting.
- Notes:
- svnmucc.c has been renamed since 1.7.x, so backporting this change should
- be done like so:
- $ svn merge --ignore-ancestry -c1407597 \
- ^/subversion/trunk/subversion/svnmucc/svnmucc.c \
- tools/client-side/svnmucc/svnmucc.c
- $ svn merge --record-only -c1407597 ^/subversion/trunk
- $ svn ci -m ...
- Votes:
- +1: cmpilato, danielsh
-
* r1408632, r1408647, r1408676, r1408684, r1408653
Fix 'svnmucc propset ^/'.
Notes:
@@ -103,7 +88,7 @@ Candidate changes:
Tries to access the parent of the repository root as a repository.
('svnmucc ps foo bar https://svn.apache.org/repos')
Votes:
- +1: danielsh
+ +1: danielsh, rhuijben
* r1407131, r1407812, r1408650
Properly handle incoming changes on symlinks (issue #4091)
@@ -133,9 +118,26 @@ Candidate changes:
misrepresentation that the first error is caused by the second.
Votes:
+1: danielsh
+ -0: rhuijben (I'm not sure if this should be in a patch release and the
+ stacktrace where this refers to is maintainer only)
Veto-blocked changes:
=====================
Approved changes:
=================
+
+ * r1407597
+ Fix issue #4079 ("svnmucc cp rev arg" SEGV).
+ Justification:
+ "Segmentation fault (core dumped)" is considered sub-par error reporting.
+ Notes:
+ svnmucc.c has been renamed since 1.7.x, so backporting this change should
+ be done like so:
+ $ svn merge --ignore-ancestry -c1407597 \
+ ^/subversion/trunk/subversion/svnmucc/svnmucc.c \
+ tools/client-side/svnmucc/svnmucc.c
+ $ svn merge --record-only -c1407597 ^/subversion/trunk
+ $ svn ci -m ...
+ Votes:
+ +1: cmpilato, danielsh, rhuijben
Re: svn commit: r1416494 - /subversion/branches/1.7.x/STATUS
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Bert Huijben wrote on Mon, Dec 03, 2012 at 13:51:20 +0100:
> > -----Original Message-----
> > From: rhuijben@apache.org [mailto:rhuijben@apache.org]
> > Sent: maandag 3 december 2012 13:46
> > To: commits@subversion.apache.org
> > Subject: svn commit: r1416494 - /subversion/branches/1.7.x/STATUS
> >
> > Author: rhuijben
> > Date: Mon Dec 3 12:46:08 2012
> > New Revision: 1416494
> >
> > URL: http://svn.apache.org/viewvc?rev=1416494&view=rev
> > Log:
> > * STATUS: Cast some votes, approving r1407597 which the bot can't merge.
>
> * r1409804
> Add a delimiter between the two chains in svn_error_compose_create().
> Justification:
> > misrepresentation that the first error is caused by the second.
> > Votes:
> > +1: danielsh
> > + -0: rhuijben (I'm not sure if this should be in a patch release and the
> > + stacktrace where this refers to is maintainer only)
>
> Note that this patch just adds the _("Additional errors:") when using svn_error_compose_create() while in many cases we just pass err to svn_error_createf(), even though it isn't really an error cause.
> (Some examples are closing files, resetting sqlite statements, etc.)
>
>
> I don't think we should apply this change as it just changes the expectations of users.
>
> In some cases the second error might even be the root cause. (I usually position the most important error first, but that doesn't make it the root cause)
>
Is your problem only with the wording? If so I'm happy to change it.
Re your comments in STATUS --- the patch inserts an svn_error_t * link
(into the middle of the error chain) whose ->message member is set to
"Additional errors:" --- and that member is part a public API not only
in maintainer mode, but in release builds too.
> Bert
>
RE: svn commit: r1416494 - /subversion/branches/1.7.x/STATUS
Posted by Bert Huijben <be...@qqmail.nl>.
> -----Original Message-----
> From: rhuijben@apache.org [mailto:rhuijben@apache.org]
> Sent: maandag 3 december 2012 13:46
> To: commits@subversion.apache.org
> Subject: svn commit: r1416494 - /subversion/branches/1.7.x/STATUS
>
> Author: rhuijben
> Date: Mon Dec 3 12:46:08 2012
> New Revision: 1416494
>
> URL: http://svn.apache.org/viewvc?rev=1416494&view=rev
> Log:
> * STATUS: Cast some votes, approving r1407597 which the bot can't merge.
* r1409804
Add a delimiter between the two chains in svn_error_compose_create().
Justification:
> misrepresentation that the first error is caused by the second.
> Votes:
> +1: danielsh
> + -0: rhuijben (I'm not sure if this should be in a patch release and the
> + stacktrace where this refers to is maintainer only)
Note that this patch just adds the _("Additional errors:") when using svn_error_compose_create() while in many cases we just pass err to svn_error_createf(), even though it isn't really an error cause.
(Some examples are closing files, resetting sqlite statements, etc.)
I don't think we should apply this change as it just changes the expectations of users.
In some cases the second error might even be the root cause. (I usually position the most important error first, but that doesn't make it the root cause)
Bert