You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "Chetan Mehrotra (JIRA)" <ji...@apache.org> on 2012/08/20 13:14:37 UTC
[jira] [Created] (OAK-257) NPE in
o.a.j.oak.security.privilege.PrivilegeDefinitionImpl constructor
Chetan Mehrotra created OAK-257:
-----------------------------------
Summary: NPE in o.a.j.oak.security.privilege.PrivilegeDefinitionImpl constructor
Key: OAK-257
URL: https://issues.apache.org/jira/browse/OAK-257
Project: Jackrabbit Oak
Issue Type: Bug
Components: core
Affects Versions: 0.5
Reporter: Chetan Mehrotra
Priority: Minor
While running Granite with Oak following NPE is seen
{noformat}
20.08.2012 16:37:21.791 *ERROR* [OsgiInstallerImpl] com.day.jcr.vault.packaging.impl.ZipVaultPackage Error during install. java.lang.NullPointerException
at com.google.common.collect.ImmutableSet.copyOf(ImmutableSet.java:259)
at org.apache.jackrabbit.oak.security.privilege.PrivilegeDefinitionImpl.<init>(PrivilegeDefinitionImpl.java:44)
at org.apache.jackrabbit.oak.security.privilege.PrivilegeDefinitionReader.readDefinition(PrivilegeDefinitionReader.java:89)
at org.apache.jackrabbit.oak.security.privilege.PrivilegeDefinitionReader.readDefinitions(PrivilegeDefinitionReader.java:76)
at org.apache.jackrabbit.oak.security.privilege.PrivilegeRegistry.getAllDefinitions(PrivilegeRegistry.java:85)
at org.apache.jackrabbit.oak.security.privilege.PrivilegeRegistry.<init>(PrivilegeRegistry.java:70)
at org.apache.jackrabbit.oak.jcr.security.privilege.PrivilegeManagerImpl.<init>(PrivilegeManagerImpl.java:49)
at org.apache.jackrabbit.oak.jcr.WorkspaceImpl.getPrivilegeManager(WorkspaceImpl.java:239)
at com.day.jcr.vault.fs.spi.impl.jcr20.JackrabbitPrivilegeInstaller.install(JackrabbitPrivilegeInstaller.java:72)
at com.day.jcr.vault.fs.io.Importer.registerPrivileges(Importer.java:507)
at com.day.jcr.vault.fs.io.Importer.run(Importer.java:412)
at com.day.jcr.vault.packaging.impl.ZipVaultPackage.extract(ZipVaultPackage.java:359)
at com.day.jcr.vault.packaging.impl.JcrPackageImpl.extract(JcrPackageImpl.java:364)
at com.day.jcr.vault.packaging.impl.JcrPackageImpl.extract(JcrPackageImpl.java:320)
at com.adobe.granite.installer.factory.packages.impl.PackageTransformer$InstallPackageTask.execute(PackageTransformer.java:251)
at org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:692)
at org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:219)
at java.lang.Thread.run(Thread.java:662)
{noformat}
This is seen while collecting all Privileges and occurs for /jcr:system/rep:privileges/crx:replicate. It probably does not have 'rep:aggregates' property. Checking with JR2 o.a.j.spi.commons.privilege.PrivilegeDefinitionImpl it constructor does a null check for declaredAggregateNames.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OAK-257) NPE in
o.a.j.oak.security.privilege.PrivilegeDefinitionImpl constructor
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Dürig resolved OAK-257.
-------------------------------
Resolution: Fixed
Fix Version/s: 0.5
Fixed at revision 1374986. Thanks Chetan Mehrotra for the patch.
> NPE in o.a.j.oak.security.privilege.PrivilegeDefinitionImpl constructor
> -----------------------------------------------------------------------
>
> Key: OAK-257
> URL: https://issues.apache.org/jira/browse/OAK-257
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Affects Versions: 0.5
> Reporter: Chetan Mehrotra
> Assignee: Michael Dürig
> Priority: Minor
> Fix For: 0.5
>
> Attachments: OAK-257.patch
>
>
> While running Granite with Oak following NPE is seen
> {noformat}
> 20.08.2012 16:37:21.791 *ERROR* [OsgiInstallerImpl] com.day.jcr.vault.packaging.impl.ZipVaultPackage Error during install. java.lang.NullPointerException
> at com.google.common.collect.ImmutableSet.copyOf(ImmutableSet.java:259)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeDefinitionImpl.<init>(PrivilegeDefinitionImpl.java:44)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeDefinitionReader.readDefinition(PrivilegeDefinitionReader.java:89)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeDefinitionReader.readDefinitions(PrivilegeDefinitionReader.java:76)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeRegistry.getAllDefinitions(PrivilegeRegistry.java:85)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeRegistry.<init>(PrivilegeRegistry.java:70)
> at org.apache.jackrabbit.oak.jcr.security.privilege.PrivilegeManagerImpl.<init>(PrivilegeManagerImpl.java:49)
> at org.apache.jackrabbit.oak.jcr.WorkspaceImpl.getPrivilegeManager(WorkspaceImpl.java:239)
> at com.day.jcr.vault.fs.spi.impl.jcr20.JackrabbitPrivilegeInstaller.install(JackrabbitPrivilegeInstaller.java:72)
> at com.day.jcr.vault.fs.io.Importer.registerPrivileges(Importer.java:507)
> at com.day.jcr.vault.fs.io.Importer.run(Importer.java:412)
> at com.day.jcr.vault.packaging.impl.ZipVaultPackage.extract(ZipVaultPackage.java:359)
> at com.day.jcr.vault.packaging.impl.JcrPackageImpl.extract(JcrPackageImpl.java:364)
> at com.day.jcr.vault.packaging.impl.JcrPackageImpl.extract(JcrPackageImpl.java:320)
> at com.adobe.granite.installer.factory.packages.impl.PackageTransformer$InstallPackageTask.execute(PackageTransformer.java:251)
> at org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:692)
> at org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:219)
> at java.lang.Thread.run(Thread.java:662)
> {noformat}
> This is seen while collecting all Privileges and occurs for /jcr:system/rep:privileges/crx:replicate. It probably does not have 'rep:aggregates' property. Checking with JR2 o.a.j.spi.commons.privilege.PrivilegeDefinitionImpl it constructor does a null check for declaredAggregateNames.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OAK-257) NPE in
o.a.j.oak.security.privilege.PrivilegeDefinitionImpl constructor
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Dürig reassigned OAK-257:
---------------------------------
Assignee: Michael Dürig
> NPE in o.a.j.oak.security.privilege.PrivilegeDefinitionImpl constructor
> -----------------------------------------------------------------------
>
> Key: OAK-257
> URL: https://issues.apache.org/jira/browse/OAK-257
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Affects Versions: 0.5
> Reporter: Chetan Mehrotra
> Assignee: Michael Dürig
> Priority: Minor
> Attachments: OAK-257.patch
>
>
> While running Granite with Oak following NPE is seen
> {noformat}
> 20.08.2012 16:37:21.791 *ERROR* [OsgiInstallerImpl] com.day.jcr.vault.packaging.impl.ZipVaultPackage Error during install. java.lang.NullPointerException
> at com.google.common.collect.ImmutableSet.copyOf(ImmutableSet.java:259)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeDefinitionImpl.<init>(PrivilegeDefinitionImpl.java:44)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeDefinitionReader.readDefinition(PrivilegeDefinitionReader.java:89)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeDefinitionReader.readDefinitions(PrivilegeDefinitionReader.java:76)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeRegistry.getAllDefinitions(PrivilegeRegistry.java:85)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeRegistry.<init>(PrivilegeRegistry.java:70)
> at org.apache.jackrabbit.oak.jcr.security.privilege.PrivilegeManagerImpl.<init>(PrivilegeManagerImpl.java:49)
> at org.apache.jackrabbit.oak.jcr.WorkspaceImpl.getPrivilegeManager(WorkspaceImpl.java:239)
> at com.day.jcr.vault.fs.spi.impl.jcr20.JackrabbitPrivilegeInstaller.install(JackrabbitPrivilegeInstaller.java:72)
> at com.day.jcr.vault.fs.io.Importer.registerPrivileges(Importer.java:507)
> at com.day.jcr.vault.fs.io.Importer.run(Importer.java:412)
> at com.day.jcr.vault.packaging.impl.ZipVaultPackage.extract(ZipVaultPackage.java:359)
> at com.day.jcr.vault.packaging.impl.JcrPackageImpl.extract(JcrPackageImpl.java:364)
> at com.day.jcr.vault.packaging.impl.JcrPackageImpl.extract(JcrPackageImpl.java:320)
> at com.adobe.granite.installer.factory.packages.impl.PackageTransformer$InstallPackageTask.execute(PackageTransformer.java:251)
> at org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:692)
> at org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:219)
> at java.lang.Thread.run(Thread.java:662)
> {noformat}
> This is seen while collecting all Privileges and occurs for /jcr:system/rep:privileges/crx:replicate. It probably does not have 'rep:aggregates' property. Checking with JR2 o.a.j.spi.commons.privilege.PrivilegeDefinitionImpl it constructor does a null check for declaredAggregateNames.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OAK-257) NPE in
o.a.j.oak.security.privilege.PrivilegeDefinitionImpl constructor
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela updated OAK-257:
-----------------------
Priority: Trivial (was: Minor)
> NPE in o.a.j.oak.security.privilege.PrivilegeDefinitionImpl constructor
> -----------------------------------------------------------------------
>
> Key: OAK-257
> URL: https://issues.apache.org/jira/browse/OAK-257
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Affects Versions: 0.5
> Reporter: Chetan Mehrotra
> Assignee: Michael Dürig
> Priority: Trivial
> Fix For: 0.5
>
> Attachments: OAK-257.patch
>
>
> While running Granite with Oak following NPE is seen
> {noformat}
> 20.08.2012 16:37:21.791 *ERROR* [OsgiInstallerImpl] com.day.jcr.vault.packaging.impl.ZipVaultPackage Error during install. java.lang.NullPointerException
> at com.google.common.collect.ImmutableSet.copyOf(ImmutableSet.java:259)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeDefinitionImpl.<init>(PrivilegeDefinitionImpl.java:44)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeDefinitionReader.readDefinition(PrivilegeDefinitionReader.java:89)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeDefinitionReader.readDefinitions(PrivilegeDefinitionReader.java:76)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeRegistry.getAllDefinitions(PrivilegeRegistry.java:85)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeRegistry.<init>(PrivilegeRegistry.java:70)
> at org.apache.jackrabbit.oak.jcr.security.privilege.PrivilegeManagerImpl.<init>(PrivilegeManagerImpl.java:49)
> at org.apache.jackrabbit.oak.jcr.WorkspaceImpl.getPrivilegeManager(WorkspaceImpl.java:239)
> at com.day.jcr.vault.fs.spi.impl.jcr20.JackrabbitPrivilegeInstaller.install(JackrabbitPrivilegeInstaller.java:72)
> at com.day.jcr.vault.fs.io.Importer.registerPrivileges(Importer.java:507)
> at com.day.jcr.vault.fs.io.Importer.run(Importer.java:412)
> at com.day.jcr.vault.packaging.impl.ZipVaultPackage.extract(ZipVaultPackage.java:359)
> at com.day.jcr.vault.packaging.impl.JcrPackageImpl.extract(JcrPackageImpl.java:364)
> at com.day.jcr.vault.packaging.impl.JcrPackageImpl.extract(JcrPackageImpl.java:320)
> at com.adobe.granite.installer.factory.packages.impl.PackageTransformer$InstallPackageTask.execute(PackageTransformer.java:251)
> at org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:692)
> at org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:219)
> at java.lang.Thread.run(Thread.java:662)
> {noformat}
> This is seen while collecting all Privileges and occurs for /jcr:system/rep:privileges/crx:replicate. It probably does not have 'rep:aggregates' property. Checking with JR2 o.a.j.spi.commons.privilege.PrivilegeDefinitionImpl it constructor does a null check for declaredAggregateNames.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-257) NPE in
o.a.j.oak.security.privilege.PrivilegeDefinitionImpl constructor
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437906#comment-13437906 ]
angela commented on OAK-257:
----------------------------
i fixed the same issue this morning while adding test cases for privilege registration
and reverted the patch with my version.
> NPE in o.a.j.oak.security.privilege.PrivilegeDefinitionImpl constructor
> -----------------------------------------------------------------------
>
> Key: OAK-257
> URL: https://issues.apache.org/jira/browse/OAK-257
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Affects Versions: 0.5
> Reporter: Chetan Mehrotra
> Assignee: Michael Dürig
> Priority: Trivial
> Fix For: 0.5
>
> Attachments: OAK-257.patch
>
>
> While running Granite with Oak following NPE is seen
> {noformat}
> 20.08.2012 16:37:21.791 *ERROR* [OsgiInstallerImpl] com.day.jcr.vault.packaging.impl.ZipVaultPackage Error during install. java.lang.NullPointerException
> at com.google.common.collect.ImmutableSet.copyOf(ImmutableSet.java:259)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeDefinitionImpl.<init>(PrivilegeDefinitionImpl.java:44)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeDefinitionReader.readDefinition(PrivilegeDefinitionReader.java:89)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeDefinitionReader.readDefinitions(PrivilegeDefinitionReader.java:76)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeRegistry.getAllDefinitions(PrivilegeRegistry.java:85)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeRegistry.<init>(PrivilegeRegistry.java:70)
> at org.apache.jackrabbit.oak.jcr.security.privilege.PrivilegeManagerImpl.<init>(PrivilegeManagerImpl.java:49)
> at org.apache.jackrabbit.oak.jcr.WorkspaceImpl.getPrivilegeManager(WorkspaceImpl.java:239)
> at com.day.jcr.vault.fs.spi.impl.jcr20.JackrabbitPrivilegeInstaller.install(JackrabbitPrivilegeInstaller.java:72)
> at com.day.jcr.vault.fs.io.Importer.registerPrivileges(Importer.java:507)
> at com.day.jcr.vault.fs.io.Importer.run(Importer.java:412)
> at com.day.jcr.vault.packaging.impl.ZipVaultPackage.extract(ZipVaultPackage.java:359)
> at com.day.jcr.vault.packaging.impl.JcrPackageImpl.extract(JcrPackageImpl.java:364)
> at com.day.jcr.vault.packaging.impl.JcrPackageImpl.extract(JcrPackageImpl.java:320)
> at com.adobe.granite.installer.factory.packages.impl.PackageTransformer$InstallPackageTask.execute(PackageTransformer.java:251)
> at org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:692)
> at org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:219)
> at java.lang.Thread.run(Thread.java:662)
> {noformat}
> This is seen while collecting all Privileges and occurs for /jcr:system/rep:privileges/crx:replicate. It probably does not have 'rep:aggregates' property. Checking with JR2 o.a.j.spi.commons.privilege.PrivilegeDefinitionImpl it constructor does a null check for declaredAggregateNames.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OAK-257) NPE in
o.a.j.oak.security.privilege.PrivilegeDefinitionImpl constructor
Posted by "Chetan Mehrotra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chetan Mehrotra updated OAK-257:
--------------------------------
Attachment: OAK-257.patch
> NPE in o.a.j.oak.security.privilege.PrivilegeDefinitionImpl constructor
> -----------------------------------------------------------------------
>
> Key: OAK-257
> URL: https://issues.apache.org/jira/browse/OAK-257
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Affects Versions: 0.5
> Reporter: Chetan Mehrotra
> Priority: Minor
> Attachments: OAK-257.patch
>
>
> While running Granite with Oak following NPE is seen
> {noformat}
> 20.08.2012 16:37:21.791 *ERROR* [OsgiInstallerImpl] com.day.jcr.vault.packaging.impl.ZipVaultPackage Error during install. java.lang.NullPointerException
> at com.google.common.collect.ImmutableSet.copyOf(ImmutableSet.java:259)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeDefinitionImpl.<init>(PrivilegeDefinitionImpl.java:44)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeDefinitionReader.readDefinition(PrivilegeDefinitionReader.java:89)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeDefinitionReader.readDefinitions(PrivilegeDefinitionReader.java:76)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeRegistry.getAllDefinitions(PrivilegeRegistry.java:85)
> at org.apache.jackrabbit.oak.security.privilege.PrivilegeRegistry.<init>(PrivilegeRegistry.java:70)
> at org.apache.jackrabbit.oak.jcr.security.privilege.PrivilegeManagerImpl.<init>(PrivilegeManagerImpl.java:49)
> at org.apache.jackrabbit.oak.jcr.WorkspaceImpl.getPrivilegeManager(WorkspaceImpl.java:239)
> at com.day.jcr.vault.fs.spi.impl.jcr20.JackrabbitPrivilegeInstaller.install(JackrabbitPrivilegeInstaller.java:72)
> at com.day.jcr.vault.fs.io.Importer.registerPrivileges(Importer.java:507)
> at com.day.jcr.vault.fs.io.Importer.run(Importer.java:412)
> at com.day.jcr.vault.packaging.impl.ZipVaultPackage.extract(ZipVaultPackage.java:359)
> at com.day.jcr.vault.packaging.impl.JcrPackageImpl.extract(JcrPackageImpl.java:364)
> at com.day.jcr.vault.packaging.impl.JcrPackageImpl.extract(JcrPackageImpl.java:320)
> at com.adobe.granite.installer.factory.packages.impl.PackageTransformer$InstallPackageTask.execute(PackageTransformer.java:251)
> at org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:692)
> at org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:219)
> at java.lang.Thread.run(Thread.java:662)
> {noformat}
> This is seen while collecting all Privileges and occurs for /jcr:system/rep:privileges/crx:replicate. It probably does not have 'rep:aggregates' property. Checking with JR2 o.a.j.spi.commons.privilege.PrivilegeDefinitionImpl it constructor does a null check for declaredAggregateNames.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira