You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Justin Ross (Jira)" <ji...@apache.org> on 2020/03/09 22:27:00 UTC
[jira] [Commented] (PROTON-2180) [python binding] on_released
called when delivery is MODIFIED
[ https://issues.apache.org/jira/browse/PROTON-2180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055433#comment-17055433 ]
Justin Ross commented on PROTON-2180:
-------------------------------------
Looking at the code, this is intentional:
https://github.com/apache/qpid-proton/blob/master/python/proton/_handlers.py#L70
https://github.com/apache/qpid-proton/blob/master/python/proton/_handlers.py#L111
And I'm sympathetic. I think modified is very much like released ("back to you - deal with it"), plus some extra info.
> [python binding] on_released called when delivery is MODIFIED
> -------------------------------------------------------------
>
> Key: PROTON-2180
> URL: https://issues.apache.org/jira/browse/PROTON-2180
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
> Affects Versions: proton-c-0.28.0
> Reporter: Charles E. Rolke
> Priority: Major
> Attachments: PROTON-2180-test-log.txt, system_tests_multicast-PROTON-2180.py
>
>
> Reproducer:
> qpid-dispatch self test system_tests_multicast: test_63_unsettled_3ack_outcomes
> Description:
> qpid-dispatch test code has an on_released method in class MulticastBase. The comments are dated April 2, 2019 so the issue has been in play since then:
> {quote}{color:#000080}def {color}on_released({color:#94558d}self{color}, event):
> {color:#808080}# for some reason Proton 'helpfully' calls on_released even though the
> {color}{color:#808080} # delivery state is actually MODIFIED
> {color} {color:#000080}if {color}event.delivery.remote_state == Delivery.MODIFIED:
> {color:#000080}return {color}{color:#94558d}self{color}.on_modified(event)
> {quote}
> The self test today triggers the if statement six times on every run.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org