You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "allisonwang-db (via GitHub)" <gi...@apache.org> on 2024/03/13 00:11:10 UTC
[PR] [SPARK-47367][PYTHON][CONNECT] Support Python data sources with Spark Connect [spark]
allisonwang-db opened a new pull request, #45486:
URL: https://github.com/apache/spark/pull/45486
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR adds support for registering and using Python data sources with Spark Connect.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To make Python data source work with Spark Connect.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
New unit tests.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47367][PYTHON][CONNECT] Support Python data sources with Spark Connect [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #45486:
URL: https://github.com/apache/spark/pull/45486#discussion_r1522364851
##########
python/pyspark/sql/tests/connect/test_parity_python_datasource.py:
##########
@@ -0,0 +1,34 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+from pyspark.sql.tests.test_python_datasource import BasePythonDataSourceTestsMixin
+from pyspark.testing.connectutils import ReusedConnectTestCase
+
+class PythonDataSourceParityTests(BasePythonDataSourceTestsMixin, ReusedConnectTestCase):
+ ...
Review Comment:
```suggestion
pass
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47367][PYTHON][CONNECT] Support Python data sources with Spark Connect [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #45486:
URL: https://github.com/apache/spark/pull/45486#discussion_r1522364851
##########
python/pyspark/sql/tests/connect/test_parity_python_datasource.py:
##########
@@ -0,0 +1,34 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+from pyspark.sql.tests.test_python_datasource import BasePythonDataSourceTestsMixin
+from pyspark.testing.connectutils import ReusedConnectTestCase
+
+class PythonDataSourceParityTests(BasePythonDataSourceTestsMixin, ReusedConnectTestCase):
+ ...
Review Comment:
```suggestion
pass
```
##########
python/pyspark/sql/connect/session.py:
##########
@@ -743,6 +743,14 @@ def udtf(self) -> "UDTFRegistration":
udtf.__doc__ = PySparkSession.udtf.__doc__
+ @property
+ def dataSource(self) -> "DataSourceRegistration":
+ from pyspark.sql.connect.datasource import DataSourceRegistration
+
+ return DataSourceRegistration(self)
+
+ dataSource.__doc__ = PySparkSession.dataSource.__doc__
Review Comment:
I already handled this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47367][PYTHON][CONNECT] Support Python data sources with Spark Connect [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #45486:
URL: https://github.com/apache/spark/pull/45486#discussion_r1538753052
##########
python/pyspark/sql/tests/test_python_datasource.py:
##########
@@ -236,12 +236,10 @@ def reader(self, schema) -> "DataSourceReader":
self.spark.dataSource.register(InMemoryDataSource)
df = self.spark.read.format("memory").load()
- self.assertEqual(df.rdd.getNumPartitions(), 3)
Review Comment:
nit, if we want to validate number of partitions in this case, we might use `spark_partition_id`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47367][PYTHON][CONNECT] Support Python data sources with Spark Connect [spark]
Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng commented on PR #45486:
URL: https://github.com/apache/spark/pull/45486#issuecomment-1998165902
Please run `dev/reformat-python`, thanks!
LGTM after resolving the above comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47367][PYTHON][CONNECT] Support Python data sources with Spark Connect [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #45486:
URL: https://github.com/apache/spark/pull/45486#discussion_r1538778783
##########
python/pyspark/sql/tests/test_python_datasource.py:
##########
@@ -236,12 +236,10 @@ def reader(self, schema) -> "DataSourceReader":
self.spark.dataSource.register(InMemoryDataSource)
df = self.spark.read.format("memory").load()
- self.assertEqual(df.rdd.getNumPartitions(), 3)
Review Comment:
Made a PR: https://github.com/apache/spark/pull/45720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47367][PYTHON][CONNECT] Support Python data sources with Spark Connect [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #45486:
URL: https://github.com/apache/spark/pull/45486#issuecomment-2019658945
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47367][PYTHON][CONNECT] Support Python data sources with Spark Connect [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #45486:
URL: https://github.com/apache/spark/pull/45486#discussion_r1522365836
##########
python/pyspark/sql/connect/session.py:
##########
@@ -743,6 +743,14 @@ def udtf(self) -> "UDTFRegistration":
udtf.__doc__ = PySparkSession.udtf.__doc__
+ @property
+ def dataSource(self) -> "DataSourceRegistration":
+ from pyspark.sql.connect.datasource import DataSourceRegistration
+
+ return DataSourceRegistration(self)
+
+ dataSource.__doc__ = PySparkSession.dataSource.__doc__
Review Comment:
Let's add
```
Notes
-----
Supports Spark Connect.
```
into `spark.dataSource` docstring
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47367][PYTHON][CONNECT] Support Python data sources with Spark Connect [spark]
Posted by "ueshin (via GitHub)" <gi...@apache.org>.
ueshin commented on code in PR #45486:
URL: https://github.com/apache/spark/pull/45486#discussion_r1523802659
##########
python/pyspark/sql/tests/connect/test_parity_python_datasource.py:
##########
Review Comment:
This module needs to be listed in `dev/sparktestsupport/modules.py`.
##########
python/pyspark/sql/connect/plan.py:
##########
@@ -2408,6 +2408,46 @@ def __repr__(self) -> str:
return f"{self._function_name}({', '.join([str(arg) for arg in self._arguments])})"
+class PythonDataSource:
+ """Represents a user-defined Python data source."""
+ def __init__(self, data_source: Type, python_ver: str):
+ self._data_source = data_source
+ self._python_ver = python_ver
+
+ def to_plan(self, session: "SparkConnectClient") -> proto.PythonDataSource:
+ ds = proto.PythonDataSource()
+ ds.command = CloudPickleSerializer().dumps(self._data_source)
+ ds.python_ver = self._python_ver
+ return ds
+
+
+class CommonInlineUserDefinedDataSource(LogicalPlan):
+ """Logical plan object for a user-defined data source"""
+
+ def __init__(self, name: str, data_source: PythonDataSource) -> None:
+ super().__init__(None)
+ self._name = name
+ self._data_source = data_source
+
+ def plan(self, session: "SparkConnectClient") -> proto.Relation:
+ plan = self._create_proto_relation()
+ plan.common_inline_user_defined_data_source.name = self._name
+ plan.common_inline_user_defined_data_source.python_data_source.CopyFrom(
+ self._data_source.to_plan(session)
+ )
+ return plan
+
+ def to_data_source_proto(
+ self, session: "SparkConnectClient"
+ ) -> "proto.CommonInlineUserDefinedDataSource":
+ plan = proto.CommonInlineUserDefinedDataSource()
+ plan.name = self._name
+ plan.python_data_source.CopyFrom(
+ cast(proto.PythonDataSource, self._data_source.to_plan(session)) # type: ignore[arg-type]
Review Comment:
Do we need `cast` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47367][PYTHON][CONNECT] Support Python data sources with Spark Connect [spark]
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on code in PR #45486:
URL: https://github.com/apache/spark/pull/45486#discussion_r1534794771
##########
python/pyspark/sql/connect/plan.py:
##########
@@ -2408,6 +2408,46 @@ def __repr__(self) -> str:
return f"{self._function_name}({', '.join([str(arg) for arg in self._arguments])})"
+class PythonDataSource:
+ """Represents a user-defined Python data source."""
+ def __init__(self, data_source: Type, python_ver: str):
+ self._data_source = data_source
+ self._python_ver = python_ver
+
+ def to_plan(self, session: "SparkConnectClient") -> proto.PythonDataSource:
+ ds = proto.PythonDataSource()
+ ds.command = CloudPickleSerializer().dumps(self._data_source)
+ ds.python_ver = self._python_ver
+ return ds
+
+
+class CommonInlineUserDefinedDataSource(LogicalPlan):
+ """Logical plan object for a user-defined data source"""
+
+ def __init__(self, name: str, data_source: PythonDataSource) -> None:
+ super().__init__(None)
+ self._name = name
+ self._data_source = data_source
+
+ def plan(self, session: "SparkConnectClient") -> proto.Relation:
+ plan = self._create_proto_relation()
+ plan.common_inline_user_defined_data_source.name = self._name
+ plan.common_inline_user_defined_data_source.python_data_source.CopyFrom(
+ self._data_source.to_plan(session)
+ )
+ return plan
+
+ def to_data_source_proto(
+ self, session: "SparkConnectClient"
+ ) -> "proto.CommonInlineUserDefinedDataSource":
+ plan = proto.CommonInlineUserDefinedDataSource()
+ plan.name = self._name
+ plan.python_data_source.CopyFrom(
+ cast(proto.PythonDataSource, self._data_source.to_plan(session)) # type: ignore[arg-type]
Review Comment:
Good catch I think we don't need this cast here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47367][PYTHON][CONNECT] Support Python data sources with Spark Connect [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #45486: [SPARK-47367][PYTHON][CONNECT] Support Python data sources with Spark Connect
URL: https://github.com/apache/spark/pull/45486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org