[jira] [Commented] (TAVERNA-161) Tool Service JSON configuration needs updating for T3

["Stian Soiland-Reyes (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAVERNA-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949174#comment-15949174 ] 

Stian Soiland-Reyes commented on TAVERNA-161:
---------------------------------------------

I think this bug is still outstanding. With TAverna Commandline 3.1 I get:

{code}
stain@biggiebuntu:~/Downloads$ executeworkflow Simple_Python_example-v1.t2flow 
..
Caused by: java.lang.ClassCastException: com.fasterxml.jackson.databind.node.ObjectNode cannot be cast to org.apache.taverna.activities.externaltool.ExternalToolActivityConfigurationBean
    at org.apache.taverna.activities.externaltool.ExternalToolActivity.configure(ExternalToolActivity.java:57)
    at org.apache.taverna.platform.capability.activity.impl.ActivityServiceImpl.createActivity(ActivityServiceImpl.java:74)
{code}

https://github.com/apache/incubator-taverna-common-activities/blob/master/taverna-external-tool-activity/src/main/java/org/apache/taverna/activities/externaltool/ExternalToolActivity.java seems to not use the JSON ObjectNode yet. It's configure() method needs to be updated and create the ExternalToolActivityConfigurationBean from it.

> Tool Service JSON configuration needs updating for T3
> -----------------------------------------------------
>
>                 Key: TAVERNA-161
>                 URL: https://issues.apache.org/jira/browse/TAVERNA-161
>             Project: Apache Taverna
>          Issue Type: Bug
>          Components: Taverna Common Activities
>            Reporter: Stian Soiland-Reyes
>            Priority: Blocker
>              Labels: tool
>   Original Estimate: 40h
>  Remaining Estimate: 40h
>
> External Tool service has not yet been updated to use JSON configuration. The configuration is a bit complex at the moment, and needs to be simplified (as using Tool is the most likely usecase for Scufl2 outside the Workbench).
> This work includes:
>  * Defining JSON schema for Tool
>  * Updating Tool Activity
>  * Updating Tool Activity UI
>  * Updating SCUFL2 translator



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)