You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "Alonexc (via GitHub)" <gi...@apache.org> on 2023/02/10 06:55:07 UTC
[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #3085: [Enhancement] Method uses integer based for loops to iterate over a List
Alonexc opened a new issue, #3085:
URL: https://github.com/apache/incubator-eventmesh/issues/3085
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
located at:
eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/grpc/protos/BatchMessage.java line 1539
analysis and explanation:
This method uses an integer-based for loop to iterate over a java.util.List, by calling List.get(i) each time through the loop. The integer is not used for other reasons.
### Describe the solution you'd like
It is better to use an iterator or foreach instead.
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 closed issue #3085: [Enhancement] Method uses integer based for loops to iterate over a List
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 closed issue #3085: [Enhancement] Method uses integer based for loops to iterate over a List
URL: https://github.com/apache/incubator-eventmesh/issues/3085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] PreetAngadSingh commented on issue #3085: [Enhancement] Method uses integer based for loops to iterate over a List
Posted by "PreetAngadSingh (via GitHub)" <gi...@apache.org>.
PreetAngadSingh commented on issue #3085:
URL: https://github.com/apache/incubator-eventmesh/issues/3085#issuecomment-1433874584
Hi @Alonexc can you reassign this issue to me? I have already implemented the solution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Alonexc commented on issue #3085: [Enhancement] Method uses integer based for loops to iterate over a List
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on issue #3085:
URL: https://github.com/apache/incubator-eventmesh/issues/3085#issuecomment-1429220196
> Please assign this task to me.
@Prince-1110 Welcome, you can submit a pr first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Prince-1110 commented on issue #3085: [Enhancement] Method uses integer based for loops to iterate over a List
Posted by "Prince-1110 (via GitHub)" <gi...@apache.org>.
Prince-1110 commented on issue #3085:
URL: https://github.com/apache/incubator-eventmesh/issues/3085#issuecomment-1428371832
Please assign this task to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Alonexc commented on issue #3085: [Enhancement] Method uses integer based for loops to iterate over a List
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on issue #3085:
URL: https://github.com/apache/incubator-eventmesh/issues/3085#issuecomment-1436382279
> Hi @Alonexc can you reassign this issue to me? I have already implemented the solution
@PreetAngadSingh Of course, you can submit a pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org