[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #662: OAK-9893 Prefetch for queries

[GitBox <gi...@apache.org>]

mreutegg commented on code in PR #662:
URL: https://github.com/apache/jackrabbit-oak/pull/662#discussion_r949160842


##########
oak-core/src/main/java/org/apache/jackrabbit/oak/Oak.java:
##########
@@ -576,6 +577,10 @@ public Oak with(@NotNull Whiteboard whiteboard) {
             newSettings.setLimitReads(this.queryEngineSettings.getLimitReads());
             this.queryEngineSettings = new AnnotatedQueryEngineSettings(newSettings);
         }
+        if (queryEngineSettings != null) {
+            Feature prefetchFeature = Feature.newFeature(QueryEngineSettings.FT_NAME_PREFETCH_FOR_QUERIES, whiteboard);

Review Comment:
   Should register feature with closer to make sure it is removed from whiteboard when the ContentRepository is closed.
   ```suggestion
               Feature prefetchFeature = Feature.newFeature(QueryEngineSettings.FT_NAME_PREFETCH_FOR_QUERIES, whiteboard);
               closer.register(prefetchFeature);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org