You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2023/01/19 06:14:18 UTC
[GitHub] [kyuubi] bowenliang123 opened a new pull request, #4190: Bump Netty from 4.1.84 to 4.1.87
bowenliang123 opened a new pull request, #4190:
URL: https://github.com/apache/kyuubi/pull/4190
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
- Bump Netty from `4.1.84.Final` to `4.1.87.Final` (release note: https://netty.io/news/2023/01/12/4-1-87-Final.html)
- with 2 CVE fixed in 4.1.86.Final for 4.1.85 and before, `CVE-2022-41915` and `CVE-2022-41881`
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #4190: Bump Netty from 4.1.84 to 4.1.87
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #4190:
URL: https://github.com/apache/kyuubi/pull/4190#issuecomment-1396553861
# [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4190?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4190](https://codecov.io/gh/apache/kyuubi/pull/4190?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (44c3fab) into [master](https://codecov.io/gh/apache/kyuubi/commit/3d91a9651bdf2ff5ed701218f6f8d9b3525a5f16?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3d91a96) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #4190 +/- ##
============================================
- Coverage 53.01% 52.99% -0.03%
Complexity 13 13
============================================
Files 548 548
Lines 29946 29948 +2
Branches 4025 4025
============================================
- Hits 15875 15870 -5
- Misses 12596 12602 +6
- Partials 1475 1476 +1
```
| [Impacted Files](https://codecov.io/gh/apache/kyuubi/pull/4190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/kyuubi/server/api/v1/BatchesResource.scala](https://codecov.io/gh/apache/kyuubi/pull/4190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL0JhdGNoZXNSZXNvdXJjZS5zY2FsYQ==) | `68.81% <0.00%> (-2.98%)` | :arrow_down: |
| [...pache/kyuubi/server/metadata/MetadataManager.scala](https://codecov.io/gh/apache/kyuubi/pull/4190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbWV0YWRhdGEvTWV0YWRhdGFNYW5hZ2VyLnNjYWxh) | `83.01% <0.00%> (-1.26%)` | :arrow_down: |
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/kyuubi/pull/4190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `48.38% <0.00%> (-1.08%)` | :arrow_down: |
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/kyuubi/pull/4190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `80.24% <0.00%> (-0.62%)` | :arrow_down: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/kyuubi/pull/4190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `76.35% <0.00%> (-0.37%)` | :arrow_down: |
| [...apache/kyuubi/engine/JpsApplicationOperation.scala](https://codecov.io/gh/apache/kyuubi/pull/4190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvSnBzQXBwbGljYXRpb25PcGVyYXRpb24uc2NhbGE=) | `77.41% <0.00%> (ø)` | |
| [...g/apache/kyuubi/operation/BatchJobSubmission.scala](https://codecov.io/gh/apache/kyuubi/pull/4190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vQmF0Y2hKb2JTdWJtaXNzaW9uLnNjYWxh) | `76.57% <0.00%> (+2.28%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4190: Bump Netty from 4.1.84 to 4.1.87
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #4190:
URL: https://github.com/apache/kyuubi/pull/4190#discussion_r1081483654
##########
dev/dependencyList:
##########
@@ -132,23 +132,24 @@ metrics-core/4.2.8//metrics-core-4.2.8.jar
metrics-jmx/4.2.8//metrics-jmx-4.2.8.jar
metrics-json/4.2.8//metrics-json-4.2.8.jar
metrics-jvm/4.2.8//metrics-jvm-4.2.8.jar
-netty-all/4.1.84.Final//netty-all-4.1.84.Final.jar
-netty-buffer/4.1.84.Final//netty-buffer-4.1.84.Final.jar
-netty-codec-dns/4.1.84.Final//netty-codec-dns-4.1.84.Final.jar
-netty-codec-http/4.1.84.Final//netty-codec-http-4.1.84.Final.jar
-netty-codec-http2/4.1.84.Final//netty-codec-http2-4.1.84.Final.jar
-netty-codec-socks/4.1.84.Final//netty-codec-socks-4.1.84.Final.jar
-netty-codec/4.1.84.Final//netty-codec-4.1.84.Final.jar
-netty-common/4.1.84.Final//netty-common-4.1.84.Final.jar
-netty-handler-proxy/4.1.84.Final//netty-handler-proxy-4.1.84.Final.jar
-netty-handler/4.1.84.Final//netty-handler-4.1.84.Final.jar
-netty-resolver-dns/4.1.84.Final//netty-resolver-dns-4.1.84.Final.jar
-netty-resolver/4.1.84.Final//netty-resolver-4.1.84.Final.jar
-netty-transport-classes-epoll/4.1.84.Final//netty-transport-classes-epoll-4.1.84.Final.jar
-netty-transport-native-epoll/4.1.84.Final/linux-aarch_64/netty-transport-native-epoll-4.1.84.Final-linux-aarch_64.jar
-netty-transport-native-epoll/4.1.84.Final/linux-x86_64/netty-transport-native-epoll-4.1.84.Final-linux-x86_64.jar
-netty-transport-native-unix-common/4.1.84.Final//netty-transport-native-unix-common-4.1.84.Final.jar
-netty-transport/4.1.84.Final//netty-transport-4.1.84.Final.jar
+netty-all/4.1.87.Final//netty-all-4.1.87.Final.jar
+netty-buffer/4.1.87.Final//netty-buffer-4.1.87.Final.jar
+netty-codec-dns/4.1.87.Final//netty-codec-dns-4.1.87.Final.jar
+netty-codec-http/4.1.87.Final//netty-codec-http-4.1.87.Final.jar
+netty-codec-http2/4.1.87.Final//netty-codec-http2-4.1.87.Final.jar
+netty-codec-socks/4.1.87.Final//netty-codec-socks-4.1.87.Final.jar
+netty-codec/4.1.87.Final//netty-codec-4.1.87.Final.jar
+netty-common/4.1.87.Final//netty-common-4.1.87.Final.jar
+netty-handler-proxy/4.1.87.Final//netty-handler-proxy-4.1.87.Final.jar
+netty-handler-ssl-ocsp/4.1.87.Final//netty-handler-ssl-ocsp-4.1.87.Final.jar
Review Comment:
it's a new jar, is it expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4190: Bump Netty from 4.1.84 to 4.1.87
Posted by GitBox <gi...@apache.org>.
bowenliang123 commented on code in PR #4190:
URL: https://github.com/apache/kyuubi/pull/4190#discussion_r1081490318
##########
dev/dependencyList:
##########
@@ -132,23 +132,24 @@ metrics-core/4.2.8//metrics-core-4.2.8.jar
metrics-jmx/4.2.8//metrics-jmx-4.2.8.jar
metrics-json/4.2.8//metrics-json-4.2.8.jar
metrics-jvm/4.2.8//metrics-jvm-4.2.8.jar
-netty-all/4.1.84.Final//netty-all-4.1.84.Final.jar
-netty-buffer/4.1.84.Final//netty-buffer-4.1.84.Final.jar
-netty-codec-dns/4.1.84.Final//netty-codec-dns-4.1.84.Final.jar
-netty-codec-http/4.1.84.Final//netty-codec-http-4.1.84.Final.jar
-netty-codec-http2/4.1.84.Final//netty-codec-http2-4.1.84.Final.jar
-netty-codec-socks/4.1.84.Final//netty-codec-socks-4.1.84.Final.jar
-netty-codec/4.1.84.Final//netty-codec-4.1.84.Final.jar
-netty-common/4.1.84.Final//netty-common-4.1.84.Final.jar
-netty-handler-proxy/4.1.84.Final//netty-handler-proxy-4.1.84.Final.jar
-netty-handler/4.1.84.Final//netty-handler-4.1.84.Final.jar
-netty-resolver-dns/4.1.84.Final//netty-resolver-dns-4.1.84.Final.jar
-netty-resolver/4.1.84.Final//netty-resolver-4.1.84.Final.jar
-netty-transport-classes-epoll/4.1.84.Final//netty-transport-classes-epoll-4.1.84.Final.jar
-netty-transport-native-epoll/4.1.84.Final/linux-aarch_64/netty-transport-native-epoll-4.1.84.Final-linux-aarch_64.jar
-netty-transport-native-epoll/4.1.84.Final/linux-x86_64/netty-transport-native-epoll-4.1.84.Final-linux-x86_64.jar
-netty-transport-native-unix-common/4.1.84.Final//netty-transport-native-unix-common-4.1.84.Final.jar
-netty-transport/4.1.84.Final//netty-transport-4.1.84.Final.jar
+netty-all/4.1.87.Final//netty-all-4.1.87.Final.jar
+netty-buffer/4.1.87.Final//netty-buffer-4.1.87.Final.jar
+netty-codec-dns/4.1.87.Final//netty-codec-dns-4.1.87.Final.jar
+netty-codec-http/4.1.87.Final//netty-codec-http-4.1.87.Final.jar
+netty-codec-http2/4.1.87.Final//netty-codec-http2-4.1.87.Final.jar
+netty-codec-socks/4.1.87.Final//netty-codec-socks-4.1.87.Final.jar
+netty-codec/4.1.87.Final//netty-codec-4.1.87.Final.jar
+netty-common/4.1.87.Final//netty-common-4.1.87.Final.jar
+netty-handler-proxy/4.1.87.Final//netty-handler-proxy-4.1.87.Final.jar
+netty-handler-ssl-ocsp/4.1.87.Final//netty-handler-ssl-ocsp-4.1.87.Final.jar
Review Comment:
It's mentioned in PR description. All I know is 1. `netty-handler-ssl-ocsp` package is released from 4.1.86+, and 2. it's included by `netty-all` which is a dependency of kyuubi server module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4190: Bump Netty from 4.1.84 to 4.1.87
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #4190:
URL: https://github.com/apache/kyuubi/pull/4190#discussion_r1081516984
##########
dev/dependencyList:
##########
@@ -132,23 +132,24 @@ metrics-core/4.2.8//metrics-core-4.2.8.jar
metrics-jmx/4.2.8//metrics-jmx-4.2.8.jar
metrics-json/4.2.8//metrics-json-4.2.8.jar
metrics-jvm/4.2.8//metrics-jvm-4.2.8.jar
-netty-all/4.1.84.Final//netty-all-4.1.84.Final.jar
-netty-buffer/4.1.84.Final//netty-buffer-4.1.84.Final.jar
-netty-codec-dns/4.1.84.Final//netty-codec-dns-4.1.84.Final.jar
-netty-codec-http/4.1.84.Final//netty-codec-http-4.1.84.Final.jar
-netty-codec-http2/4.1.84.Final//netty-codec-http2-4.1.84.Final.jar
-netty-codec-socks/4.1.84.Final//netty-codec-socks-4.1.84.Final.jar
-netty-codec/4.1.84.Final//netty-codec-4.1.84.Final.jar
-netty-common/4.1.84.Final//netty-common-4.1.84.Final.jar
-netty-handler-proxy/4.1.84.Final//netty-handler-proxy-4.1.84.Final.jar
-netty-handler/4.1.84.Final//netty-handler-4.1.84.Final.jar
-netty-resolver-dns/4.1.84.Final//netty-resolver-dns-4.1.84.Final.jar
-netty-resolver/4.1.84.Final//netty-resolver-4.1.84.Final.jar
-netty-transport-classes-epoll/4.1.84.Final//netty-transport-classes-epoll-4.1.84.Final.jar
-netty-transport-native-epoll/4.1.84.Final/linux-aarch_64/netty-transport-native-epoll-4.1.84.Final-linux-aarch_64.jar
-netty-transport-native-epoll/4.1.84.Final/linux-x86_64/netty-transport-native-epoll-4.1.84.Final-linux-x86_64.jar
-netty-transport-native-unix-common/4.1.84.Final//netty-transport-native-unix-common-4.1.84.Final.jar
-netty-transport/4.1.84.Final//netty-transport-4.1.84.Final.jar
+netty-all/4.1.87.Final//netty-all-4.1.87.Final.jar
+netty-buffer/4.1.87.Final//netty-buffer-4.1.87.Final.jar
+netty-codec-dns/4.1.87.Final//netty-codec-dns-4.1.87.Final.jar
+netty-codec-http/4.1.87.Final//netty-codec-http-4.1.87.Final.jar
+netty-codec-http2/4.1.87.Final//netty-codec-http2-4.1.87.Final.jar
+netty-codec-socks/4.1.87.Final//netty-codec-socks-4.1.87.Final.jar
+netty-codec/4.1.87.Final//netty-codec-4.1.87.Final.jar
+netty-common/4.1.87.Final//netty-common-4.1.87.Final.jar
+netty-handler-proxy/4.1.87.Final//netty-handler-proxy-4.1.87.Final.jar
+netty-handler-ssl-ocsp/4.1.87.Final//netty-handler-ssl-ocsp-4.1.87.Final.jar
Review Comment:
sgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4190: Bump Netty from 4.1.84 to 4.1.87
Posted by GitBox <gi...@apache.org>.
bowenliang123 commented on code in PR #4190:
URL: https://github.com/apache/kyuubi/pull/4190#discussion_r1082009855
##########
dev/dependencyList:
##########
@@ -132,23 +132,24 @@ metrics-core/4.2.8//metrics-core-4.2.8.jar
metrics-jmx/4.2.8//metrics-jmx-4.2.8.jar
metrics-json/4.2.8//metrics-json-4.2.8.jar
metrics-jvm/4.2.8//metrics-jvm-4.2.8.jar
-netty-all/4.1.84.Final//netty-all-4.1.84.Final.jar
-netty-buffer/4.1.84.Final//netty-buffer-4.1.84.Final.jar
-netty-codec-dns/4.1.84.Final//netty-codec-dns-4.1.84.Final.jar
-netty-codec-http/4.1.84.Final//netty-codec-http-4.1.84.Final.jar
-netty-codec-http2/4.1.84.Final//netty-codec-http2-4.1.84.Final.jar
-netty-codec-socks/4.1.84.Final//netty-codec-socks-4.1.84.Final.jar
-netty-codec/4.1.84.Final//netty-codec-4.1.84.Final.jar
-netty-common/4.1.84.Final//netty-common-4.1.84.Final.jar
-netty-handler-proxy/4.1.84.Final//netty-handler-proxy-4.1.84.Final.jar
-netty-handler/4.1.84.Final//netty-handler-4.1.84.Final.jar
-netty-resolver-dns/4.1.84.Final//netty-resolver-dns-4.1.84.Final.jar
-netty-resolver/4.1.84.Final//netty-resolver-4.1.84.Final.jar
-netty-transport-classes-epoll/4.1.84.Final//netty-transport-classes-epoll-4.1.84.Final.jar
-netty-transport-native-epoll/4.1.84.Final/linux-aarch_64/netty-transport-native-epoll-4.1.84.Final-linux-aarch_64.jar
-netty-transport-native-epoll/4.1.84.Final/linux-x86_64/netty-transport-native-epoll-4.1.84.Final-linux-x86_64.jar
-netty-transport-native-unix-common/4.1.84.Final//netty-transport-native-unix-common-4.1.84.Final.jar
-netty-transport/4.1.84.Final//netty-transport-4.1.84.Final.jar
+netty-all/4.1.87.Final//netty-all-4.1.87.Final.jar
+netty-buffer/4.1.87.Final//netty-buffer-4.1.87.Final.jar
+netty-codec-dns/4.1.87.Final//netty-codec-dns-4.1.87.Final.jar
+netty-codec-http/4.1.87.Final//netty-codec-http-4.1.87.Final.jar
+netty-codec-http2/4.1.87.Final//netty-codec-http2-4.1.87.Final.jar
+netty-codec-socks/4.1.87.Final//netty-codec-socks-4.1.87.Final.jar
+netty-codec/4.1.87.Final//netty-codec-4.1.87.Final.jar
+netty-common/4.1.87.Final//netty-common-4.1.87.Final.jar
+netty-handler-proxy/4.1.87.Final//netty-handler-proxy-4.1.87.Final.jar
+netty-handler-ssl-ocsp/4.1.87.Final//netty-handler-ssl-ocsp-4.1.87.Final.jar
Review Comment:
OK, addressed and updated the description for exclusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4190: Bump Netty from 4.1.84 to 4.1.87
Posted by GitBox <gi...@apache.org>.
bowenliang123 commented on PR #4190:
URL: https://github.com/apache/kyuubi/pull/4190#issuecomment-1397934024
thanks, merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 closed pull request #4190: Bump Netty from 4.1.84 to 4.1.87
Posted by GitBox <gi...@apache.org>.
bowenliang123 closed pull request #4190: Bump Netty from 4.1.84 to 4.1.87
URL: https://github.com/apache/kyuubi/pull/4190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4190: Bump Netty from 4.1.84 to 4.1.87
Posted by GitBox <gi...@apache.org>.
bowenliang123 commented on code in PR #4190:
URL: https://github.com/apache/kyuubi/pull/4190#discussion_r1081505673
##########
dev/dependencyList:
##########
@@ -132,23 +132,24 @@ metrics-core/4.2.8//metrics-core-4.2.8.jar
metrics-jmx/4.2.8//metrics-jmx-4.2.8.jar
metrics-json/4.2.8//metrics-json-4.2.8.jar
metrics-jvm/4.2.8//metrics-jvm-4.2.8.jar
-netty-all/4.1.84.Final//netty-all-4.1.84.Final.jar
-netty-buffer/4.1.84.Final//netty-buffer-4.1.84.Final.jar
-netty-codec-dns/4.1.84.Final//netty-codec-dns-4.1.84.Final.jar
-netty-codec-http/4.1.84.Final//netty-codec-http-4.1.84.Final.jar
-netty-codec-http2/4.1.84.Final//netty-codec-http2-4.1.84.Final.jar
-netty-codec-socks/4.1.84.Final//netty-codec-socks-4.1.84.Final.jar
-netty-codec/4.1.84.Final//netty-codec-4.1.84.Final.jar
-netty-common/4.1.84.Final//netty-common-4.1.84.Final.jar
-netty-handler-proxy/4.1.84.Final//netty-handler-proxy-4.1.84.Final.jar
-netty-handler/4.1.84.Final//netty-handler-4.1.84.Final.jar
-netty-resolver-dns/4.1.84.Final//netty-resolver-dns-4.1.84.Final.jar
-netty-resolver/4.1.84.Final//netty-resolver-4.1.84.Final.jar
-netty-transport-classes-epoll/4.1.84.Final//netty-transport-classes-epoll-4.1.84.Final.jar
-netty-transport-native-epoll/4.1.84.Final/linux-aarch_64/netty-transport-native-epoll-4.1.84.Final-linux-aarch_64.jar
-netty-transport-native-epoll/4.1.84.Final/linux-x86_64/netty-transport-native-epoll-4.1.84.Final-linux-x86_64.jar
-netty-transport-native-unix-common/4.1.84.Final//netty-transport-native-unix-common-4.1.84.Final.jar
-netty-transport/4.1.84.Final//netty-transport-4.1.84.Final.jar
+netty-all/4.1.87.Final//netty-all-4.1.87.Final.jar
+netty-buffer/4.1.87.Final//netty-buffer-4.1.87.Final.jar
+netty-codec-dns/4.1.87.Final//netty-codec-dns-4.1.87.Final.jar
+netty-codec-http/4.1.87.Final//netty-codec-http-4.1.87.Final.jar
+netty-codec-http2/4.1.87.Final//netty-codec-http2-4.1.87.Final.jar
+netty-codec-socks/4.1.87.Final//netty-codec-socks-4.1.87.Final.jar
+netty-codec/4.1.87.Final//netty-codec-4.1.87.Final.jar
+netty-common/4.1.87.Final//netty-common-4.1.87.Final.jar
+netty-handler-proxy/4.1.87.Final//netty-handler-proxy-4.1.87.Final.jar
+netty-handler-ssl-ocsp/4.1.87.Final//netty-handler-ssl-ocsp-4.1.87.Final.jar
Review Comment:
I think we could exclude `netty-handler-ssl-ocsp` from `netty-all` this time, as we never uses ocsp related feature for ssl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org