You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/11/22 18:08:47 UTC
[GitHub] [cordova-ios] TylerBreau opened a new pull request, #1271: Updated ci.yml node versions to 16.x and 18.x
TylerBreau opened a new pull request, #1271:
URL: https://github.com/apache/cordova-ios/pull/1271
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Node 10 and 12 is already EOL.
Node 14 is EOL in early 2023.
### Description
<!-- Describe your changes in detail -->
Updated ci.yml.
Removed node 10.x, 12.x, and 14.x.
Added node 16.x and 18.x.
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-commenter commented on pull request #1271: ci: remove Node 10-12 & added Node 16-18
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1271:
URL: https://github.com/apache/cordova-ios/pull/1271#issuecomment-1326114633
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1271?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1271](https://codecov.io/gh/apache/cordova-ios/pull/1271?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (268fb44) into [master](https://codecov.io/gh/apache/cordova-ios/commit/f804a42e171b2ec9288421e0ce63eb35bb0afe14?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f804a42) will **increase** coverage by `78.26%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1271 +/- ##
===========================================
+ Coverage 0 78.26% +78.26%
===========================================
Files 0 15 +15
Lines 0 1767 +1767
===========================================
+ Hits 0 1383 +1383
- Misses 0 384 +384
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/1271?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [lib/projectFile.js](https://codecov.io/gh/apache/cordova-ios/pull/1271/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL3Byb2plY3RGaWxlLmpz) | `94.91% <0.00%> (ø)` | |
| [lib/PodsJson.js](https://codecov.io/gh/apache/cordova-ios/pull/1271/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL1BvZHNKc29uLmpz) | `95.04% <0.00%> (ø)` | |
| [lib/listEmulatorBuildTargets.js](https://codecov.io/gh/apache/cordova-ios/pull/1271/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2xpc3RFbXVsYXRvckJ1aWxkVGFyZ2V0cy5qcw==) | `96.77% <0.00%> (ø)` | |
| [lib/listDevices.js](https://codecov.io/gh/apache/cordova-ios/pull/1271/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2xpc3REZXZpY2VzLmpz) | `100.00% <0.00%> (ø)` | |
| [lib/plugman/pluginHandlers.js](https://codecov.io/gh/apache/cordova-ios/pull/1271/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL3BsdWdtYW4vcGx1Z2luSGFuZGxlcnMuanM=) | `90.05% <0.00%> (ø)` | |
| [lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/1271/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL3ByZXBhcmUuanM=) | `85.00% <0.00%> (ø)` | |
| [lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/1271/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2J1aWxkLmpz) | `63.69% <0.00%> (ø)` | |
| [lib/Api.js](https://codecov.io/gh/apache/cordova-ios/pull/1271/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL0FwaS5qcw==) | `71.76% <0.00%> (ø)` | |
| [lib/listEmulatorImages.js](https://codecov.io/gh/apache/cordova-ios/pull/1271/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2xpc3RFbXVsYXRvckltYWdlcy5qcw==) | `100.00% <0.00%> (ø)` | |
| [lib/run.js](https://codecov.io/gh/apache/cordova-ios/pull/1271/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL3J1bi5qcw==) | `21.97% <0.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/cordova-ios/pull/1271/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] breautek merged pull request #1271: ci: remove Node 10-12 & added Node 16-18
Posted by GitBox <gi...@apache.org>.
breautek merged PR #1271:
URL: https://github.com/apache/cordova-ios/pull/1271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org