You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "danimtb (via GitHub)" <gi...@apache.org> on 2024/04/03 14:16:28 UTC

[I] Clarification on "auto"option values in Conan recipe for Arrow C++ Library [arrow]

danimtb opened a new issue, #40979:
URL: https://github.com/apache/arrow/issues/40979

   ### Describe the usage question you have. Please include as many useful details as  possible.
   
   
   Hey Arrow Project Team!
   
   My name is Dani, I'm a Conan developer working on the Conan recipe for the Arrow C++ library in at the Conan central repository https://github.com/conan-io/conan-center-index.
   
   We've been streamlining the options management in the recipe as we have received some issues in the past, so we are aiming to make things simpler and more user-friendly. As part of this process, we've noticed some quirks with the "auto" values for certain options and we are hesitant about its behavior as we do not have a deep knowledge of the arrow cpp build intrinsics
   
   For example, the options "with_jemalloc" has an auto behavior of setting its value to True on BSD systems. Making this option False by default now would cause any kind of trouble? Should it be True for such platform?
   
   I would like to get some support in this way at the PR https://github.com/conan-io/conan-center-index/pull/23163 were we are working on the changes, specficically regarding the confirmation of the following behaviors:
   
   ```
   # Warn/error on some option values
           if not self.options.with_boost:
               if self.options.gandiva:
                   self.output.warning("Option 'with_boost=True' could be required when option 'gandiva=True'")
           if not self.options.with_re2:
               if self.options.gandiva or self.options.parquet:
                   self.output.warning("Option 'with_re2=True' could be required when option 'gandiva=True' or 'parquet=True'")
               if self.options.compute or self.options.dataset_modules:
                   self.output.warning("Option 'with_re2=True' could be required when 'compute=True' or 'dataset_modules=True'")
           if not self.options.with_jemalloc:
               if "BSD" in self.settings.os:
                   self.output.warning("Option 'with_jemalloc=True' could be required for BSD in settings.os")
   ```
   
   I have noticed that the conan recipe it is also included in this repository and updated from conan-center-index from time to time. For that reason as well we would like to align on this refactor of option to avoid creating any further trouble to anyone.
   
   Thanks a bunch for your time and support.
   
   Cheers!
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Packaging][Conan] Clarification on "auto"option values in Conan recipe for Arrow C++ Library [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #40979:
URL: https://github.com/apache/arrow/issues/40979#issuecomment-2039316182

   Thanks for working on this!
   
   > For example, the options "with_jemalloc" has an auto behavior of setting its value to True on BSD systems. Making this option False by default now would cause any kind of trouble? Should it be True for such platform?
   
   We can use `False` as the default value for all platforms. But we recommend using jemalloc as much as possible on jemalloc available platforms. Because jemalloc is faster than system memory allocator in general.
   
   > I would like to get some support in this way at the PR [conan-io/conan-center-index#23163](https://github.com/conan-io/conan-center-index/pull/23163) were we are working on the changes, specficically regarding the confirmation of the following behaviors:
   
   Should we support this work on the PR instead of here?
   
   Then we can close this issue and comment on the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Packaging][Conan] Clarification on "auto"option values in Conan recipe for Arrow C++ Library [arrow]

Posted by "danimtb (via GitHub)" <gi...@apache.org>.
danimtb commented on issue #40979:
URL: https://github.com/apache/arrow/issues/40979#issuecomment-2039350914

   Hi @kou!
   
   Thanks a lot for the response. Indeed, we can continue the conversation at https://github.com/conan-io/conan-center-index/pull/23163, I see you already commented there.
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Packaging][Conan] Clarification on "auto"option values in Conan recipe for Arrow C++ Library [arrow]

Posted by "danimtb (via GitHub)" <gi...@apache.org>.
danimtb closed issue #40979: [Packaging][Conan] Clarification on "auto"option values in Conan recipe for Arrow  C++ Library
URL: https://github.com/apache/arrow/issues/40979


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org