You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2013/01/22 08:07:46 UTC
svn commit: r1436768 [13/13] - in /commons/proper/lang/trunk/src:
main/java/org/apache/commons/lang3/
main/java/org/apache/commons/lang3/builder/
main/java/org/apache/commons/lang3/concurrent/
main/java/org/apache/commons/lang3/event/ main/java/org/apa...
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/BasicThreadFactoryTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/BasicThreadFactoryTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/BasicThreadFactoryTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/BasicThreadFactoryTest.java Tue Jan 22 07:07:42 2013
@@ -52,7 +52,7 @@ public class BasicThreadFactoryTest {
*
* @param factory the factory to be checked
*/
- private void checkFactoryDefaults(BasicThreadFactory factory) {
+ private void checkFactoryDefaults(final BasicThreadFactory factory) {
assertNull("Got a naming pattern", factory.getNamingPattern());
assertNull("Got an exception handler", factory
.getUncaughtExceptionHandler());
@@ -170,7 +170,7 @@ public class BasicThreadFactoryTest {
*
* @param flag the value of the flag
*/
- private void checkDaemonFlag(boolean flag) {
+ private void checkDaemonFlag(final boolean flag) {
ThreadFactory wrapped = EasyMock.createMock(ThreadFactory.class);
Runnable r = EasyMock.createMock(Runnable.class);
Thread t = new Thread();
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/ConstantInitializerTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/ConstantInitializerTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/ConstantInitializerTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/ConstantInitializerTest.java Tue Jan 22 07:07:42 2013
@@ -47,7 +47,7 @@ public class ConstantInitializerTest {
* @param obj the object to compare with the test instance
* @param expected the expected result
*/
- private void checkEquals(Object obj, boolean expected) {
+ private void checkEquals(final Object obj, final boolean expected) {
assertTrue("Wrong result of equals", expected == init.equals(obj));
if (obj != null) {
assertTrue("Not symmetric", expected == obj.equals(init));
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/MultiBackgroundInitializerTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/MultiBackgroundInitializerTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/MultiBackgroundInitializerTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/MultiBackgroundInitializerTest.java Tue Jan 22 07:07:42 2013
@@ -56,8 +56,8 @@ public class MultiBackgroundInitializerT
* not be checked)
* @throws ConcurrentException if an error occurs
*/
- private void checkChild(BackgroundInitializer<?> child,
- ExecutorService expExec) throws ConcurrentException {
+ private void checkChild(final BackgroundInitializer<?> child,
+ final ExecutorService expExec) throws ConcurrentException {
ChildBackgroundInitializer cinit = (ChildBackgroundInitializer) child;
Integer result = cinit.get();
assertEquals("Wrong result", 1, result.intValue());
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/TimedSemaphoreTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/TimedSemaphoreTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/TimedSemaphoreTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/TimedSemaphoreTest.java Tue Jan 22 07:07:42 2013
@@ -150,8 +150,8 @@ public class TimedSemaphoreTest {
* @param service the mock
* @param future the future
*/
- private void prepareStartTimer(ScheduledExecutorService service,
- ScheduledFuture<?> future) {
+ private void prepareStartTimer(final ScheduledExecutorService service,
+ final ScheduledFuture<?> future) {
service.scheduleAtFixedRate((Runnable) EasyMock.anyObject(), EasyMock
.eq(PERIOD), EasyMock.eq(PERIOD), EasyMock.eq(UNIT));
EasyMock.expectLastCall().andReturn(future);
@@ -380,13 +380,13 @@ public class TimedSemaphoreTest {
/** Counter for the endOfPeriod() invocations. */
private int periodEnds;
- public TimedSemaphoreTestImpl(long timePeriod, TimeUnit timeUnit,
- int limit) {
+ public TimedSemaphoreTestImpl(final long timePeriod, final TimeUnit timeUnit,
+ final int limit) {
super(timePeriod, timeUnit, limit);
}
- public TimedSemaphoreTestImpl(ScheduledExecutorService service,
- long timePeriod, TimeUnit timeUnit, int limit) {
+ public TimedSemaphoreTestImpl(final ScheduledExecutorService service,
+ final long timePeriod, final TimeUnit timeUnit, final int limit) {
super(service, timePeriod, timeUnit, limit);
}
@@ -448,7 +448,7 @@ public class TimedSemaphoreTest {
/** The number of invocations of the latch. */
private final int latchCount;
- public SemaphoreThread(TimedSemaphore b, CountDownLatch l, int c, int lc) {
+ public SemaphoreThread(final TimedSemaphore b, final CountDownLatch l, final int c, final int lc) {
semaphore = b;
latch = l;
count = c;
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/event/EventListenerSupportTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/event/EventListenerSupportTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/event/EventListenerSupportTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/event/EventListenerSupportTest.java Tue Jan 22 07:07:42 2013
@@ -126,7 +126,7 @@ public class EventListenerSupportTest
listenerSupport.addListener(new VetoableChangeListener() {
@Override
- public void vetoableChange(PropertyChangeEvent e) {
+ public void vetoableChange(final PropertyChangeEvent e) {
}
});
listenerSupport.addListener(EasyMock.createNiceMock(VetoableChangeListener.class));
@@ -174,7 +174,7 @@ public class EventListenerSupportTest
* {@inheritDoc}
*/
@Override
- public Object invoke(Object proxy, Method method, Object[] args)
+ public Object invoke(final Object proxy, final Method method, final Object[] args)
throws Throwable {
return "vetoableChange".equals(method.getName())
&& "Hour".equals(((PropertyChangeEvent) args[0]).getPropertyName()) ? null
@@ -201,7 +201,7 @@ public class EventListenerSupportTest
listenerSupport.addListener(new VetoableChangeListener()
{
@Override
- public void vetoableChange(PropertyChangeEvent e)
+ public void vetoableChange(final PropertyChangeEvent e)
{
listenerSupport.removeListener(this);
}
@@ -213,7 +213,7 @@ public class EventListenerSupportTest
return new VetoableChangeListener()
{
@Override
- public void vetoableChange(PropertyChangeEvent e)
+ public void vetoableChange(final PropertyChangeEvent e)
{
calledListeners.add(this);
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/event/EventUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/event/EventUtilsTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/event/EventUtilsTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/event/EventUtilsTest.java Tue Jan 22 07:07:42 2013
@@ -94,7 +94,7 @@ public class EventUtilsTest
EventUtils.addEventListener(src, PropertyChangeListener.class, new PropertyChangeListener()
{
@Override
- public void propertyChange(PropertyChangeEvent e)
+ public void propertyChange(final PropertyChangeEvent e)
{
// Do nothing!
}
@@ -187,7 +187,7 @@ public class EventUtilsTest
{
private int count;
- public void eventOccurred(PropertyChangeEvent e)
+ public void eventOccurred(final PropertyChangeEvent e)
{
count++;
}
@@ -203,21 +203,21 @@ public class EventUtilsTest
{
private final Map<String, Integer> eventCounts = new TreeMap<String, Integer>();
- public <L> L createListener(Class<L> listenerType)
+ public <L> L createListener(final Class<L> listenerType)
{
return listenerType.cast(Proxy.newProxyInstance(Thread.currentThread().getContextClassLoader(),
new Class[]{listenerType},
this));
}
- public int getEventCount(String eventName)
+ public int getEventCount(final String eventName)
{
Integer count = eventCounts.get(eventName);
return count == null ? 0 : count.intValue();
}
@Override
- public Object invoke(Object proxy, Method method, Object[] args) throws Throwable
+ public Object invoke(final Object proxy, final Method method, final Object[] args) throws Throwable
{
Integer count = eventCounts.get(method.getName());
if (count == null)
@@ -236,7 +236,7 @@ public class EventUtilsTest
{
private final EventListenerSupport<MultipleEventListener> listeners = EventListenerSupport.create(MultipleEventListener.class);
- public void addMultipleEventListener(MultipleEventListener listener)
+ public void addMultipleEventListener(final MultipleEventListener listener)
{
listeners.addListener(listener);
}
@@ -244,7 +244,7 @@ public class EventUtilsTest
public static class ExceptionEventSource
{
- public void addPropertyChangeListener(PropertyChangeListener listener)
+ public void addPropertyChangeListener(final PropertyChangeListener listener)
{
throw new RuntimeException();
}
@@ -256,24 +256,24 @@ public class EventUtilsTest
private String property;
- public void setProperty(String property)
+ public void setProperty(final String property)
{
String oldValue = this.property;
this.property = property;
listeners.fire().propertyChange(new PropertyChangeEvent(this, "property", oldValue, property));
}
- protected void addVetoableChangeListener(VetoableChangeListener listener)
+ protected void addVetoableChangeListener(final VetoableChangeListener listener)
{
// Do nothing!
}
- public void addPropertyChangeListener(PropertyChangeListener listener)
+ public void addPropertyChangeListener(final PropertyChangeListener listener)
{
listeners.addListener(listener);
}
- public void removePropertyChangeListener(PropertyChangeListener listener)
+ public void removePropertyChangeListener(final PropertyChangeListener listener)
{
listeners.removeListener(listener);
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/exception/ExceptionUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/exception/ExceptionUtilsTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/exception/ExceptionUtilsTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/exception/ExceptionUtilsTest.java Tue Jan 22 07:07:42 2013
@@ -490,12 +490,12 @@ public class ExceptionUtilsTest {
private static class ExceptionWithCause extends Exception {
private Throwable cause;
- public ExceptionWithCause(String str, Throwable cause) {
+ public ExceptionWithCause(final String str, final Throwable cause) {
super(str);
setCause(cause);
}
- public ExceptionWithCause(Throwable cause) {
+ public ExceptionWithCause(final Throwable cause) {
super();
setCause(cause);
}
@@ -505,7 +505,7 @@ public class ExceptionUtilsTest {
return cause;
}
- public void setCause(Throwable cause) {
+ public void setCause(final Throwable cause) {
this.cause = cause;
}
}
@@ -526,7 +526,7 @@ public class ExceptionUtilsTest {
private static class NestableException extends Exception {
@SuppressWarnings("unused")
public NestableException() { super(); }
- public NestableException(Throwable t) { super(t); }
+ public NestableException(final Throwable t) { super(t); }
}
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java Tue Jan 22 07:07:42 2013
@@ -285,7 +285,7 @@ public class NumberUtilsTest {
this.testCreateFloatFailure("\u00A0\uFEFF\u000B\u000C\u001C\u001D\u001E\u001F");
}
- protected void testCreateFloatFailure(String str) {
+ protected void testCreateFloatFailure(final String str) {
try {
Float value = NumberUtils.createFloat(str);
fail("createFloat(blank) failed: " + value);
@@ -305,7 +305,7 @@ public class NumberUtilsTest {
this.testCreateDoubleFailure("\u00A0\uFEFF\u000B\u000C\u001C\u001D\u001E\u001F");
}
- protected void testCreateDoubleFailure(String str) {
+ protected void testCreateDoubleFailure(final String str) {
try {
Double value = NumberUtils.createDouble(str);
fail("createDouble(blank) failed: " + value);
@@ -325,7 +325,7 @@ public class NumberUtilsTest {
this.testCreateIntegerFailure("\u00A0\uFEFF\u000B\u000C\u001C\u001D\u001E\u001F");
}
- protected void testCreateIntegerFailure(String str) {
+ protected void testCreateIntegerFailure(final String str) {
try {
Integer value = NumberUtils.createInteger(str);
fail("createInteger(blank) failed: " + value);
@@ -345,7 +345,7 @@ public class NumberUtilsTest {
this.testCreateLongFailure("\u00A0\uFEFF\u000B\u000C\u001C\u001D\u001E\u001F");
}
- protected void testCreateLongFailure(String str) {
+ protected void testCreateLongFailure(final String str) {
try {
Long value = NumberUtils.createLong(str);
fail("createLong(blank) failed: " + value);
@@ -377,7 +377,7 @@ public class NumberUtilsTest {
testCreateBigIntegerFailure("-0x");
}
- protected void testCreateBigIntegerFailure(String str) {
+ protected void testCreateBigIntegerFailure(final String str) {
try {
BigInteger value = NumberUtils.createBigInteger(str);
fail("createBigInteger(blank) failed: " + value);
@@ -403,7 +403,7 @@ public class NumberUtilsTest {
this.testCreateBigDecimalFailure("++0");
}
- protected void testCreateBigDecimalFailure(String str) {
+ protected void testCreateBigDecimalFailure(final String str) {
try {
BigDecimal value = NumberUtils.createBigDecimal(str);
fail("createBigDecimal(blank) failed: " + value);
@@ -1254,7 +1254,7 @@ public class NumberUtilsTest {
assertFalse("isNumber(String) LANG-664 failed", NumberUtils.isNumber(val));
}
- private boolean checkCreateNumber(String val) {
+ private boolean checkCreateNumber(final String val) {
try {
Object obj = NumberUtils.createNumber(val);
if (obj == null) {
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/reflect/ConstructorUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/reflect/ConstructorUtilsTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/reflect/ConstructorUtilsTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/reflect/ConstructorUtilsTest.java Tue Jan 22 07:07:42 2013
@@ -40,23 +40,23 @@ public class ConstructorUtilsTest {
toString = "()";
}
- public TestBean(int i) {
+ public TestBean(final int i) {
toString = "(int)";
}
- public TestBean(Integer i) {
+ public TestBean(final Integer i) {
toString = "(Integer)";
}
- public TestBean(double d) {
+ public TestBean(final double d) {
toString = "(double)";
}
- public TestBean(String s) {
+ public TestBean(final String s) {
toString = "(String)";
}
- public TestBean(Object o) {
+ public TestBean(final Object o) {
toString = "(Object)";
}
@@ -212,8 +212,8 @@ public class ConstructorUtilsTest {
singletonArray(null), singletonArray(Object.class));
}
- private void expectMatchingAccessibleConstructorParameterTypes(Class<?> cls,
- Class<?>[] requestTypes, Class<?>[] actualTypes) {
+ private void expectMatchingAccessibleConstructorParameterTypes(final Class<?> cls,
+ final Class<?>[] requestTypes, final Class<?>[] actualTypes) {
Constructor<?> c = ConstructorUtils.getMatchingAccessibleConstructor(cls,
requestTypes);
assertTrue(toString(c.getParameterTypes()) + " not equals "
@@ -221,11 +221,11 @@ public class ConstructorUtilsTest {
.getParameterTypes()));
}
- private String toString(Class<?>[] c) {
+ private String toString(final Class<?>[] c) {
return Arrays.asList(c).toString();
}
- private Class<?>[] singletonArray(Class<?> c) {
+ private Class<?>[] singletonArray(final Class<?> c) {
Class<?>[] result = classCache.get(c);
if (result == null) {
result = new Class[] { c };
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/reflect/MethodUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/reflect/MethodUtilsTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/reflect/MethodUtilsTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/reflect/MethodUtilsTest.java Tue Jan 22 07:07:42 2013
@@ -56,27 +56,27 @@ public class MethodUtilsTest {
return "bar()";
}
- public static String bar(int i) {
+ public static String bar(final int i) {
return "bar(int)";
}
- public static String bar(Integer i) {
+ public static String bar(final Integer i) {
return "bar(Integer)";
}
- public static String bar(double d) {
+ public static String bar(final double d) {
return "bar(double)";
}
- public static String bar(String s) {
+ public static String bar(final String s) {
return "bar(String)";
}
- public static String bar(Object o) {
+ public static String bar(final Object o) {
return "bar(Object)";
}
- public static void oneParameterStatic(String s) {
+ public static void oneParameterStatic(final String s) {
// empty
}
@@ -89,27 +89,27 @@ public class MethodUtilsTest {
return "foo()";
}
- public String foo(int i) {
+ public String foo(final int i) {
return "foo(int)";
}
- public String foo(Integer i) {
+ public String foo(final Integer i) {
return "foo(Integer)";
}
- public String foo(double d) {
+ public String foo(final double d) {
return "foo(double)";
}
- public String foo(String s) {
+ public String foo(final String s) {
return "foo(String)";
}
- public String foo(Object o) {
+ public String foo(final Object o) {
return "foo(Object)";
}
- public void oneParameter(String s) {
+ public void oneParameter(final String s) {
// empty
}
}
@@ -121,7 +121,7 @@ public class MethodUtilsTest {
}
@Override
- public void setValue(Object value) {
+ public void setValue(final Object value) {
}
}
@@ -377,8 +377,8 @@ public class MethodUtilsTest {
singletonArray(null), singletonArray(String.class));
}
- private void expectMatchingAccessibleMethodParameterTypes(Class<?> cls,
- String methodName, Class<?>[] requestTypes, Class<?>[] actualTypes) {
+ private void expectMatchingAccessibleMethodParameterTypes(final Class<?> cls,
+ final String methodName, final Class<?>[] requestTypes, final Class<?>[] actualTypes) {
Method m = MethodUtils.getMatchingAccessibleMethod(cls, methodName,
requestTypes);
assertTrue(toString(m.getParameterTypes()) + " not equals "
@@ -386,11 +386,11 @@ public class MethodUtilsTest {
.getParameterTypes()));
}
- private String toString(Class<?>[] c) {
+ private String toString(final Class<?>[] c) {
return Arrays.asList(c).toString();
}
- private Class<?>[] singletonArray(Class<?> c) {
+ private Class<?>[] singletonArray(final Class<?> c) {
Class<?>[] result = classCache.get(c);
if (result == null) {
result = new Class[] { c };
@@ -400,12 +400,12 @@ public class MethodUtilsTest {
}
public static class InheritanceBean {
- public void testOne(Object obj) {}
- public void testOne(GrandParentObject obj) {}
- public void testOne(ParentObject obj) {}
- public void testTwo(Object obj) {}
- public void testTwo(GrandParentObject obj) {}
- public void testTwo(ChildInterface obj) {}
+ public void testOne(final Object obj) {}
+ public void testOne(final GrandParentObject obj) {}
+ public void testOne(final ParentObject obj) {}
+ public void testTwo(final Object obj) {}
+ public void testTwo(final GrandParentObject obj) {}
+ public void testTwo(final ChildInterface obj) {}
}
interface ChildInterface {}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java Tue Jan 22 07:07:42 2013
@@ -96,11 +96,11 @@ public class TypeUtilsTest<B> {
public static URI uri;
- public void dummyMethod(List list0, List<Object> list1, List<?> list2,
- List<? super Object> list3, List<String> list4, List<? extends String> list5,
- List<? super String> list6, List[] list7, List<Object>[] list8, List<?>[] list9,
- List<? super Object>[] list10, List<String>[] list11, List<? extends String>[] list12,
- List<? super String>[] list13) {
+ public void dummyMethod(final List list0, final List<Object> list1, final List<?> list2,
+ final List<? super Object> list3, final List<String> list4, final List<? extends String> list5,
+ final List<? super String> list6, final List[] list7, final List<Object>[] list8, final List<?>[] list9,
+ final List<? super Object>[] list10, final List<String>[] list11, final List<? extends String>[] list12,
+ final List<? super String>[] list13) {
}
@SuppressWarnings("boxing") // deliberately used here
@@ -441,7 +441,7 @@ public class TypeUtilsTest<B> {
Assert.assertTrue(TypeUtils.isAssignable(fClassType, eClassType));
}
- public void delegateBooleanAssertion(Type[] types, int i2, int i1, boolean expected) {
+ public void delegateBooleanAssertion(final Type[] types, final int i2, final int i1, final boolean expected) {
Type type1 = types[i1];
Type type2 = types[i2];
boolean isAssignable = TypeUtils.isAssignable(type2, type1);
@@ -692,7 +692,7 @@ class AAAClass extends AAClass<String> {
//raw types, where used, are used purposely
class AClass extends AAClass<String>.BBClass<Number> {
- public AClass(AAClass<String> enclosingInstance) {
+ public AClass(final AAClass<String> enclosingInstance) {
enclosingInstance.super();
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/text/CompositeFormatTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/text/CompositeFormatTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/text/CompositeFormatTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/text/CompositeFormatTest.java Tue Jan 22 07:07:42 2013
@@ -38,24 +38,24 @@ public class CompositeFormatTest {
Format parser = new Format() {
@Override
- public StringBuffer format(Object obj, StringBuffer toAppendTo, FieldPosition pos) {
+ public StringBuffer format(final Object obj, final StringBuffer toAppendTo, final FieldPosition pos) {
throw new UnsupportedOperationException("Not implemented");
}
@Override
- public Object parseObject(String source, ParsePosition pos) {
+ public Object parseObject(final String source, final ParsePosition pos) {
return null; // do nothing
}
};
Format formatter = new Format() {
@Override
- public StringBuffer format(Object obj, StringBuffer toAppendTo, FieldPosition pos) {
+ public StringBuffer format(final Object obj, final StringBuffer toAppendTo, final FieldPosition pos) {
return null; // do nothing
}
@Override
- public Object parseObject(String source, ParsePosition pos) {
+ public Object parseObject(final String source, final ParsePosition pos) {
throw new UnsupportedOperationException("Not implemented");
}
};
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/text/ExtendedMessageFormatTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/text/ExtendedMessageFormatTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/text/ExtendedMessageFormatTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/text/ExtendedMessageFormatTest.java Tue Jan 22 07:07:42 2013
@@ -311,7 +311,7 @@ public class ExtendedMessageFormatTest {
* @param args MessageFormat arguments
* @param locales to test
*/
- private void checkBuiltInFormat(String pattern, Object[] args, Locale[] locales) {
+ private void checkBuiltInFormat(final String pattern, final Object[] args, final Locale[] locales) {
checkBuiltInFormat(pattern, null, args, locales);
}
@@ -322,7 +322,7 @@ public class ExtendedMessageFormatTest {
* @param args MessageFormat arguments
* @param locales to test
*/
- private void checkBuiltInFormat(String pattern, Map<String, ?> registry, Object[] args, Locale[] locales) {
+ private void checkBuiltInFormat(final String pattern, final Map<String, ?> registry, final Object[] args, final Locale[] locales) {
checkBuiltInFormat(pattern, registry, args, (Locale) null);
for (Locale locale : locales) {
checkBuiltInFormat(pattern, registry, args, locale);
@@ -337,7 +337,7 @@ public class ExtendedMessageFormatTest {
* @param args Object[]
* @param locale Locale
*/
- private void checkBuiltInFormat(String pattern, Map<String, ?> registry, Object[] args, Locale locale) {
+ private void checkBuiltInFormat(final String pattern, final Map<String, ?> registry, final Object[] args, final Locale locale) {
StringBuilder buffer = new StringBuilder();
buffer.append("Pattern=[");
buffer.append(pattern);
@@ -357,7 +357,7 @@ public class ExtendedMessageFormatTest {
}
//can't trust what MessageFormat does with toPattern() pre 1.4:
- private void assertPatternsEqual(String message, String expected, String actual) {
+ private void assertPatternsEqual(final String message, final String expected, final String actual) {
if (SystemUtils.isJavaVersionAtLeast(JAVA_1_4)) {
assertEquals(message, expected, actual);
}
@@ -369,7 +369,7 @@ public class ExtendedMessageFormatTest {
* @param locale Locale
* @return MessageFormat
*/
- private MessageFormat createMessageFormat(String pattern, Locale locale) {
+ private MessageFormat createMessageFormat(final String pattern, final Locale locale) {
MessageFormat result = new MessageFormat(pattern);
if (locale != null) {
result.setLocale(locale);
@@ -385,11 +385,11 @@ public class ExtendedMessageFormatTest {
*/
private static class LowerCaseFormat extends Format {
@Override
- public StringBuffer format(Object obj, StringBuffer toAppendTo, FieldPosition pos) {
+ public StringBuffer format(final Object obj, final StringBuffer toAppendTo, final FieldPosition pos) {
return toAppendTo.append(((String)obj).toLowerCase());
}
@Override
- public Object parseObject(String source, ParsePosition pos) {throw new UnsupportedOperationException();}
+ public Object parseObject(final String source, final ParsePosition pos) {throw new UnsupportedOperationException();}
}
/**
@@ -397,11 +397,11 @@ public class ExtendedMessageFormatTest {
*/
private static class UpperCaseFormat extends Format {
@Override
- public StringBuffer format(Object obj, StringBuffer toAppendTo, FieldPosition pos) {
+ public StringBuffer format(final Object obj, final StringBuffer toAppendTo, final FieldPosition pos) {
return toAppendTo.append(((String)obj).toUpperCase());
}
@Override
- public Object parseObject(String source, ParsePosition pos) {throw new UnsupportedOperationException();}
+ public Object parseObject(final String source, final ParsePosition pos) {throw new UnsupportedOperationException();}
}
@@ -412,7 +412,7 @@ public class ExtendedMessageFormatTest {
private static class LowerCaseFormatFactory implements FormatFactory {
private static final Format LOWER_INSTANCE = new LowerCaseFormat();
@Override
- public Format getFormat(String name, String arguments, Locale locale) {
+ public Format getFormat(final String name, final String arguments, final Locale locale) {
return LOWER_INSTANCE;
}
}
@@ -422,7 +422,7 @@ public class ExtendedMessageFormatTest {
private static class UpperCaseFormatFactory implements FormatFactory {
private static final Format UPPER_INSTANCE = new UpperCaseFormat();
@Override
- public Format getFormat(String name, String arguments, Locale locale) {
+ public Format getFormat(final String name, final String arguments, final Locale locale) {
return UPPER_INSTANCE;
}
}
@@ -431,7 +431,7 @@ public class ExtendedMessageFormatTest {
*/
private static class OverrideShortDateFormatFactory implements FormatFactory {
@Override
- public Format getFormat(String name, String arguments, Locale locale) {
+ public Format getFormat(final String name, final String arguments, final Locale locale) {
return !"short".equals(arguments) ? null
: locale == null ? DateFormat
.getDateInstance(DateFormat.DEFAULT) : DateFormat
@@ -443,8 +443,8 @@ public class ExtendedMessageFormatTest {
* Alternative ExtendedMessageFormat impl.
*/
private static class OtherExtendedMessageFormat extends ExtendedMessageFormat {
- public OtherExtendedMessageFormat(String pattern, Locale locale,
- Map<String, ? extends FormatFactory> registry) {
+ public OtherExtendedMessageFormat(final String pattern, final Locale locale,
+ final Map<String, ? extends FormatFactory> registry) {
super(pattern, locale, registry);
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/text/StrBuilderAppendInsertTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/text/StrBuilderAppendInsertTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/text/StrBuilderAppendInsertTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/text/StrBuilderAppendInsertTest.java Tue Jan 22 07:07:42 2013
@@ -547,7 +547,7 @@ public class StrBuilderAppendInsertTest
final int[] count = new int[2];
StrBuilder sb = new StrBuilder() {
@Override
- public StrBuilder append(String str) {
+ public StrBuilder append(final String str) {
count[0]++;
return super.append(str);
}
@@ -583,7 +583,7 @@ public class StrBuilderAppendInsertTest
final int[] count = new int[2];
StrBuilder sb = new StrBuilder() {
@Override
- public StrBuilder append(String str) {
+ public StrBuilder append(final String str) {
count[0]++;
return super.append(str);
}
@@ -605,7 +605,7 @@ public class StrBuilderAppendInsertTest
final int[] count = new int[2];
StrBuilder sb = new StrBuilder() {
@Override
- public StrBuilder append(String str, int startIndex, int length) {
+ public StrBuilder append(final String str, final int startIndex, final int length) {
count[0]++;
return super.append(str, startIndex, length);
}
@@ -627,7 +627,7 @@ public class StrBuilderAppendInsertTest
final int[] count = new int[2];
StrBuilder sb = new StrBuilder() {
@Override
- public StrBuilder append(StringBuffer str) {
+ public StrBuilder append(final StringBuffer str) {
count[0]++;
return super.append(str);
}
@@ -649,7 +649,7 @@ public class StrBuilderAppendInsertTest
final int[] count = new int[2];
StrBuilder sb = new StrBuilder() {
@Override
- public StrBuilder append(StringBuilder str) {
+ public StrBuilder append(final StringBuilder str) {
count[0]++;
return super.append(str);
}
@@ -671,7 +671,7 @@ public class StrBuilderAppendInsertTest
final int[] count = new int[2];
StrBuilder sb = new StrBuilder() {
@Override
- public StrBuilder append(StringBuffer str, int startIndex, int length) {
+ public StrBuilder append(final StringBuffer str, final int startIndex, final int length) {
count[0]++;
return super.append(str, startIndex, length);
}
@@ -693,7 +693,7 @@ public class StrBuilderAppendInsertTest
final int[] count = new int[2];
StrBuilder sb = new StrBuilder() {
@Override
- public StrBuilder append(StringBuilder str, int startIndex, int length) {
+ public StrBuilder append(final StringBuilder str, final int startIndex, final int length) {
count[0]++;
return super.append(str, startIndex, length);
}
@@ -715,7 +715,7 @@ public class StrBuilderAppendInsertTest
final int[] count = new int[2];
StrBuilder sb = new StrBuilder() {
@Override
- public StrBuilder append(StrBuilder str) {
+ public StrBuilder append(final StrBuilder str) {
count[0]++;
return super.append(str);
}
@@ -737,7 +737,7 @@ public class StrBuilderAppendInsertTest
final int[] count = new int[2];
StrBuilder sb = new StrBuilder() {
@Override
- public StrBuilder append(StrBuilder str, int startIndex, int length) {
+ public StrBuilder append(final StrBuilder str, final int startIndex, final int length) {
count[0]++;
return super.append(str, startIndex, length);
}
@@ -759,7 +759,7 @@ public class StrBuilderAppendInsertTest
final int[] count = new int[2];
StrBuilder sb = new StrBuilder() {
@Override
- public StrBuilder append(char[] str) {
+ public StrBuilder append(final char[] str) {
count[0]++;
return super.append(str);
}
@@ -781,7 +781,7 @@ public class StrBuilderAppendInsertTest
final int[] count = new int[2];
StrBuilder sb = new StrBuilder() {
@Override
- public StrBuilder append(char[] str, int startIndex, int length) {
+ public StrBuilder append(final char[] str, final int startIndex, final int length) {
count[0]++;
return super.append(str, startIndex, length);
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/text/StrBuilderTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/text/StrBuilderTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/text/StrBuilderTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/text/StrBuilderTest.java Tue Jan 22 07:07:42 2013
@@ -1560,7 +1560,7 @@ public class StrBuilderTest {
static final StrMatcher A_NUMBER_MATCHER = new StrMatcher() {
@Override
- public int isMatch(char[] buffer, int pos, int bufferStart, int bufferEnd) {
+ public int isMatch(final char[] buffer, int pos, final int bufferStart, final int bufferEnd) {
if (buffer[pos] == 'A') {
pos++;
if (pos < bufferEnd && buffer[pos] >= '0' && buffer[pos] <= '9') {
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/text/StrSubstitutorTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/text/StrSubstitutorTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/text/StrSubstitutorTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/text/StrSubstitutorTest.java Tue Jan 22 07:07:42 2013
@@ -341,7 +341,7 @@ public class StrSubstitutorTest {
map.put("name", "commons");
StrSubstitutor sub = new StrSubstitutor(map) {
@Override
- protected String resolveVariable(String variableName, StrBuilder buf, int startPos, int endPos) {
+ protected String resolveVariable(final String variableName, final StrBuilder buf, final int startPos, final int endPos) {
assertEquals("name", variableName);
assertSame(builder, buf);
assertEquals(3, startPos);
@@ -523,7 +523,7 @@ public class StrSubstitutorTest {
}
//-----------------------------------------------------------------------
- private void doTestReplace(String expectedResult, String replaceTemplate, boolean substring) {
+ private void doTestReplace(final String expectedResult, final String replaceTemplate, final boolean substring) {
String expectedShortResult = expectedResult.substring(1, expectedResult.length() - 1);
StrSubstitutor sub = new StrSubstitutor(values);
@@ -579,7 +579,7 @@ public class StrSubstitutorTest {
}
}
- private void doTestNoReplace(String replaceTemplate) {
+ private void doTestNoReplace(final String replaceTemplate) {
StrSubstitutor sub = new StrSubstitutor(values);
if (replaceTemplate == null) {
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/text/StrTokenizerTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/text/StrTokenizerTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/text/StrTokenizerTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/text/StrTokenizerTest.java Tue Jan 22 07:07:42 2013
@@ -37,7 +37,7 @@ public class StrTokenizerTest {
private static final String TSV_SIMPLE_FIXTURE = "A\tb\tc";
- private void checkClone(StrTokenizer tokenizer) {
+ private void checkClone(final StrTokenizer tokenizer) {
assertFalse(StrTokenizer.getCSVInstance() == tokenizer);
assertFalse(StrTokenizer.getTSVInstance() == tokenizer);
}
@@ -507,7 +507,7 @@ public class StrTokenizerTest {
}
//-----------------------------------------------------------------------
- private void testCSV(String data) {
+ private void testCSV(final String data) {
this.testXSVAbc(StrTokenizer.getCSVInstance(data));
this.testXSVAbc(StrTokenizer.getCSVInstance(data.toCharArray()));
}
@@ -530,7 +530,7 @@ public class StrTokenizerTest {
this.testCSV(" \n " + CSV_SIMPLE_FIXTURE + "\n\n\r");
}
- void testEmpty(StrTokenizer tokenizer) {
+ void testEmpty(final StrTokenizer tokenizer) {
this.checkClone(tokenizer);
assertFalse(tokenizer.hasNext());
assertFalse(tokenizer.hasPrevious());
@@ -771,7 +771,7 @@ public class StrTokenizerTest {
this.testEmpty(StrTokenizer.getCSVInstance(""));
}
- void testXSVAbc(StrTokenizer tokenizer) {
+ void testXSVAbc(final StrTokenizer tokenizer) {
this.checkClone(tokenizer);
assertEquals(-1, tokenizer.previousIndex());
assertEquals(0, tokenizer.nextIndex());
@@ -843,7 +843,7 @@ public class StrTokenizerTest {
public void testTokenizeSubclassInputChange() {
StrTokenizer tkn = new StrTokenizer("a b c d e") {
@Override
- protected List<String> tokenize(char[] chars, int offset, int count) {
+ protected List<String> tokenize(final char[] chars, final int offset, final int count) {
return super.tokenize("w x y z".toCharArray(), 2, 5);
}
};
@@ -856,7 +856,7 @@ public class StrTokenizerTest {
public void testTokenizeSubclassOutputChange() {
StrTokenizer tkn = new StrTokenizer("a b c") {
@Override
- protected List<String> tokenize(char[] chars, int offset, int count) {
+ protected List<String> tokenize(final char[] chars, final int offset, final int count) {
List<String> list = super.tokenize(chars, offset, count);
Collections.reverse(list);
return list;
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DateUtilsRoundingTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DateUtilsRoundingTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DateUtilsRoundingTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DateUtilsRoundingTest.java Tue Jan 22 07:07:42 2013
@@ -699,7 +699,7 @@ public class DateUtilsRoundingTest {
* @param calendarField
* @since 3.0
*/
- protected void roundToJanuaryFirst(Date minDate, Date maxDate, int calendarField) {
+ protected void roundToJanuaryFirst(final Date minDate, final Date maxDate, final int calendarField) {
assertEquals("Rounding "+ fdf.format(januaryOneDate) +" as Date with CalendarField-value "+ calendarField +" must return itself", januaryOneDate, DateUtils.round(januaryOneDate, calendarField));
assertEquals(januaryOneDate, DateUtils.round(minDate, calendarField));
assertEquals(januaryOneDate, DateUtils.round(maxDate, calendarField));
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java Tue Jan 22 07:07:42 2013
@@ -623,7 +623,7 @@ public class DateUtilsTest {
}
//-----------------------------------------------------------------------
- private void assertDate(Date date, int year, int month, int day, int hour, int min, int sec, int mil) throws Exception {
+ private void assertDate(final Date date, final int year, final int month, final int day, final int hour, final int min, final int sec, final int mil) throws Exception {
GregorianCalendar cal = new GregorianCalendar();
cal.setTime(date);
assertEquals(year, cal.get(Calendar.YEAR));
@@ -1630,7 +1630,7 @@ public class DateUtilsTest {
* This checks that this is a 7 element iterator of Calendar objects
* that are dates (no time), and exactly 1 day spaced after each other.
*/
- private static void assertWeekIterator(Iterator<?> it, Calendar start) {
+ private static void assertWeekIterator(final Iterator<?> it, final Calendar start) {
Calendar end = (Calendar) start.clone();
end.add(Calendar.DATE, 6);
@@ -1640,7 +1640,7 @@ public class DateUtilsTest {
/**
* Convenience method for when working with Date objects
*/
- private static void assertWeekIterator(Iterator<?> it, Date start, Date end) {
+ private static void assertWeekIterator(final Iterator<?> it, final Date start, final Date end) {
Calendar calStart = Calendar.getInstance();
calStart.setTime(start);
Calendar calEnd = Calendar.getInstance();
@@ -1654,7 +1654,7 @@ public class DateUtilsTest {
* that are dates (no time), and exactly 1 day spaced after each other
* (in addition to the proper start and stop dates)
*/
- private static void assertWeekIterator(Iterator<?> it, Calendar start, Calendar end) {
+ private static void assertWeekIterator(final Iterator<?> it, final Calendar start, final Calendar end) {
Calendar cal = (Calendar) it.next();
assertCalendarsEquals("", start, cal, 0);
Calendar last = null;
@@ -1681,14 +1681,14 @@ public class DateUtilsTest {
* Used to check that Calendar objects are close enough
* delta is in milliseconds
*/
- private static void assertCalendarsEquals(String message, Calendar cal1, Calendar cal2, long delta) {
+ private static void assertCalendarsEquals(final String message, final Calendar cal1, final Calendar cal2, final long delta) {
if (Math.abs(cal1.getTime().getTime() - cal2.getTime().getTime()) > delta) {
throw new AssertionFailedError(
message + " expected " + cal1.getTime() + " but got " + cal2.getTime());
}
}
- void warn(String msg) {
+ void warn(final String msg) {
System.err.println(msg);
}
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java Tue Jan 22 07:07:42 2013
@@ -542,7 +542,7 @@ public class DurationFormatUtilsTest {
// }
// }
- private void bruteForce(int year, int month, int day, String format, int calendarType) {
+ private void bruteForce(final int year, final int month, final int day, final String format, final int calendarType) {
String msg = year + "-" + month + "-" + day + " to ";
Calendar c = Calendar.getInstance();
c.set(year, month, day, 0, 0, 0);
@@ -558,10 +558,10 @@ public class DurationFormatUtilsTest {
}
}
- private void assertEqualDuration(String expected, int[] start, int[] end, String format) {
+ private void assertEqualDuration(final String expected, final int[] start, final int[] end, final String format) {
assertEqualDuration(null, expected, start, end, format);
}
- private void assertEqualDuration(String message, String expected, int[] start, int[] end, String format) {
+ private void assertEqualDuration(final String message, final String expected, final int[] start, final int[] end, final String format) {
Calendar cal1 = Calendar.getInstance();
cal1.set(start[0], start[1], start[2], start[3], start[4], start[5]);
cal1.set(Calendar.MILLISECOND, 0);
@@ -578,7 +578,7 @@ public class DurationFormatUtilsTest {
}
}
- private void assertArrayEquals(DurationFormatUtils.Token[] obj1, DurationFormatUtils.Token[] obj2) {
+ private void assertArrayEquals(final DurationFormatUtils.Token[] obj1, final DurationFormatUtils.Token[] obj2) {
assertEquals("Arrays are unequal length. ", obj1.length, obj2.length);
for (int i = 0; i < obj1.length; i++) {
assertTrue("Index " + i + " not equal, " + obj1[i] + " vs " + obj2[i], obj1[i].equals(obj2[i]));
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/FastDateFormatTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/FastDateFormatTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/FastDateFormatTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/FastDateFormatTest.java Tue Jan 22 07:07:42 2013
@@ -259,7 +259,7 @@ public class FastDateFormatTest {
private static final long serialVersionUID = 1L; // because SimpleDateFormat is serializable
@Override
- public Object parseObject(String formattedDate) throws ParseException {
+ public Object parseObject(final String formattedDate) throws ParseException {
synchronized(this) {
return super.parse(formattedDate);
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/FastDateFormat_ParserTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/FastDateFormat_ParserTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/FastDateFormat_ParserTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/FastDateFormat_ParserTest.java Tue Jan 22 07:07:42 2013
@@ -27,7 +27,7 @@ import java.util.TimeZone;
public class FastDateFormat_ParserTest extends FastDateParserTest {
@Override
- protected DateParser getInstance(String format, TimeZone timeZone, Locale locale) {
+ protected DateParser getInstance(final String format, final TimeZone timeZone, final Locale locale) {
return FastDateFormat.getInstance(format, timeZone, locale);
}
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/FastDateFormat_PrinterTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/FastDateFormat_PrinterTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/FastDateFormat_PrinterTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/FastDateFormat_PrinterTest.java Tue Jan 22 07:07:42 2013
@@ -27,7 +27,7 @@ import java.util.TimeZone;
public class FastDateFormat_PrinterTest extends FastDatePrinterTest {
@Override
- protected DatePrinter getInstance(String format, TimeZone timeZone, Locale locale) {
+ protected DatePrinter getInstance(final String format, final TimeZone timeZone, final Locale locale) {
return FastDateFormat.getInstance(format, timeZone, locale);
}
}
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/FastDateParserTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/FastDateParserTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/FastDateParserTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/FastDateParserTest.java Tue Jan 22 07:07:42 2013
@@ -58,26 +58,26 @@ public class FastDateParserTest {
private static final Locale SWEDEN = new Locale("sv", "SE");
- DateParser getInstance(String format) {
+ DateParser getInstance(final String format) {
return getInstance(format, TimeZone.getDefault(), Locale.getDefault());
}
- private DateParser getDateInstance(int dateStyle, Locale locale) {
+ private DateParser getDateInstance(final int dateStyle, final Locale locale) {
return getInstance(FormatCache.getPatternForStyle(Integer.valueOf(dateStyle), null, locale), TimeZone.getDefault(), Locale.getDefault());
}
- private DateParser getInstance(String format, Locale locale) {
+ private DateParser getInstance(final String format, final Locale locale) {
return getInstance(format, TimeZone.getDefault(), locale);
}
- private DateParser getInstance(String format, TimeZone timeZone) {
+ private DateParser getInstance(final String format, final TimeZone timeZone) {
return getInstance(format, timeZone, Locale.getDefault());
}
/**
* Override this method in derived tests to change the construction of instances
*/
- protected DateParser getInstance(String format, TimeZone timeZone, Locale locale) {
+ protected DateParser getInstance(final String format, final TimeZone timeZone, final Locale locale) {
return new FastDateParser(format, timeZone, locale);
}
@@ -268,7 +268,7 @@ public class FastDateParserTest {
testLocales(SHORT_FORMAT_NOERA, true);
}
- private void testLocales(String format, boolean eraBC) throws Exception {
+ private void testLocales(final String format, final boolean eraBC) throws Exception {
Calendar cal= Calendar.getInstance(GMT);
cal.clear();
@@ -292,7 +292,7 @@ public class FastDateParserTest {
}
}
- private String trimMessage(String msg) {
+ private String trimMessage(final String msg) {
if (msg.length() < 100) {
return msg;
}
@@ -303,7 +303,7 @@ public class FastDateParserTest {
return msg.substring(0, 100)+"...";
}
- private void checkParse(Locale locale, Calendar cal, SimpleDateFormat sdf, DateParser fdf) throws ParseException {
+ private void checkParse(final Locale locale, final Calendar cal, final SimpleDateFormat sdf, final DateParser fdf) throws ParseException {
String formattedDate= sdf.format(cal.getTime());
Date expectedTime = sdf.parse(formattedDate);
Date actualTime = fdf.parse(formattedDate);
@@ -355,7 +355,7 @@ public class FastDateParserTest {
testSdfAndFdp("M E","3 Tue", true);
}
- private void testSdfAndFdp(String format, String date, boolean shouldFail)
+ private void testSdfAndFdp(final String format, final String date, final boolean shouldFail)
throws Exception {
final boolean debug = false;
Date dfdp = null;
Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/FastDatePrinterTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/FastDatePrinterTest.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/FastDatePrinterTest.java (original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/FastDatePrinterTest.java Tue Jan 22 07:07:42 2013
@@ -43,19 +43,19 @@ public class FastDatePrinterTest {
private static final TimeZone NEW_YORK = TimeZone.getTimeZone("America/New_York");
private static final Locale SWEDEN = new Locale("sv", "SE");
- DatePrinter getInstance(String format) {
+ DatePrinter getInstance(final String format) {
return getInstance(format, TimeZone.getDefault(), Locale.getDefault());
}
- private DatePrinter getDateInstance(int dateStyle, Locale locale) {
+ private DatePrinter getDateInstance(final int dateStyle, final Locale locale) {
return getInstance(FormatCache.getPatternForStyle(Integer.valueOf(dateStyle), null, locale), TimeZone.getDefault(), Locale.getDefault());
}
- private DatePrinter getInstance(String format, Locale locale) {
+ private DatePrinter getInstance(final String format, final Locale locale) {
return getInstance(format, TimeZone.getDefault(), locale);
}
- private DatePrinter getInstance(String format, TimeZone timeZone) {
+ private DatePrinter getInstance(final String format, final TimeZone timeZone) {
return getInstance(format, timeZone, Locale.getDefault());
}
@@ -66,7 +66,7 @@ public class FastDatePrinterTest {
* @param locale
* @return
*/
- protected DatePrinter getInstance(String format, TimeZone timeZone, Locale locale) {
+ protected DatePrinter getInstance(final String format, final TimeZone timeZone, final Locale locale) {
return new FastDatePrinter(format, timeZone, locale);
}