You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by rm...@apache.org on 2020/08/31 08:52:10 UTC
[lucene-solr] branch master updated: master is on java 11!
This is an automated email from the ASF dual-hosted git repository.
rmuir pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
The following commit(s) were added to refs/heads/master by this push:
new 4129daa master is on java 11!
4129daa is described below
commit 4129daa6dd23f7f741cd38e6fcf2d4920d681ef6
Author: Robert Muir <rm...@apache.org>
AuthorDate: Mon Aug 31 04:53:44 2020 -0400
master is on java 11!
---
.../validate-source-patterns/check-source-patterns.groovy | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/gradle/validation/validate-source-patterns/check-source-patterns.groovy b/gradle/validation/validate-source-patterns/check-source-patterns.groovy
index 774023d..aabcd27 100644
--- a/gradle/validation/validate-source-patterns/check-source-patterns.groovy
+++ b/gradle/validation/validate-source-patterns/check-source-patterns.groovy
@@ -49,13 +49,6 @@ def invalidPatterns = [
(~$/import java\.lang\.\w+;/$) : 'java.lang import is unnecessary'
]
-// Python and others merrily use var declarations, this is a problem _only_ in Java at least for 8x where we're forbidding var declarations
-def invalidJavaOnlyPatterns = [
- (~$/\n\s*var\s+.*=.*<>.*/$) : 'Diamond operators should not be used with var',
- (~$/\n\s*var\s+/$) : 'var is not allowed in until we stop development on the 8x code line'
-]
-
-
def baseDir = properties['basedir'];
def baseDirLen = baseDir.length() + 1;
@@ -209,11 +202,6 @@ ant.fileScanner{
reportViolation(f, "Solr test cases should extend SolrTestCase rather than LuceneTestCase");
}
}
- invalidJavaOnlyPatterns.each { pattern,name ->
- if (pattern.matcher(text).find()) {
- reportViolation(f, name);
- }
- }
}
if (f.name.endsWith('.xml') || f.name.endsWith('.xml.template')) {
checkLicenseHeaderPrecedes(f, '<tag>', xmlTagPattern, xmlCommentPattern, text, ratDocument);
RE: [lucene-solr] branch master updated: master is on java 11!
Posted by Uwe Schindler <uw...@thetaphi.de>.
Hi Robert,
please revert this and open an issue. There was a discussion about this and commits like this should not be done without negotiation.
Uwe
-----
Uwe Schindler
Achterdiek 19, D-28357 Bremen
https://www.thetaphi.de
eMail: uwe@thetaphi.de
> -----Original Message-----
> From: rmuir@apache.org <rm...@apache.org>
> Sent: Monday, August 31, 2020 10:52 AM
> To: commits@lucene.apache.org
> Subject: [lucene-solr] branch master updated: master is on java 11!
>
> This is an automated email from the ASF dual-hosted git repository.
>
> rmuir pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
> new 4129daa master is on java 11!
> 4129daa is described below
>
> commit 4129daa6dd23f7f741cd38e6fcf2d4920d681ef6
> Author: Robert Muir <rm...@apache.org>
> AuthorDate: Mon Aug 31 04:53:44 2020 -0400
>
> master is on java 11!
> ---
> .../validate-source-patterns/check-source-patterns.groovy | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/gradle/validation/validate-source-patterns/check-source-
> patterns.groovy b/gradle/validation/validate-source-patterns/check-source-
> patterns.groovy
> index 774023d..aabcd27 100644
> --- a/gradle/validation/validate-source-patterns/check-source-patterns.groovy
> +++ b/gradle/validation/validate-source-patterns/check-source-patterns.groovy
> @@ -49,13 +49,6 @@ def invalidPatterns = [
> (~$/import java\.lang\.\w+;/$) : 'java.lang import is unnecessary'
> ]
>
> -// Python and others merrily use var declarations, this is a problem _only_ in
> Java at least for 8x where we're forbidding var declarations
> -def invalidJavaOnlyPatterns = [
> - (~$/\n\s*var\s+.*=.*<>.*/$) : 'Diamond operators should not be used with
> var',
> - (~$/\n\s*var\s+/$) : 'var is not allowed in until we stop development on the
> 8x code line'
> -]
> -
> -
> def baseDir = properties['basedir'];
> def baseDirLen = baseDir.length() + 1;
>
> @@ -209,11 +202,6 @@ ant.fileScanner{
> reportViolation(f, "Solr test cases should extend SolrTestCase rather than
> LuceneTestCase");
> }
> }
> - invalidJavaOnlyPatterns.each { pattern,name ->
> - if (pattern.matcher(text).find()) {
> - reportViolation(f, name);
> - }
> - }
> }
> if (f.name.endsWith('.xml') || f.name.endsWith('.xml.template')) {
> checkLicenseHeaderPrecedes(f, '<tag>', xmlTagPattern,
> xmlCommentPattern, text, ratDocument);
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org