You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/07/29 17:37:53 UTC
[GitHub] [incubator-doris] caiconghui opened a new pull request #4205: [Bug] Fix Fe meta problem, make drop meta check code easy to read and add doc content for drop meta check
caiconghui opened a new pull request #4205:
URL: https://github.com/apache/incubator-doris/pull/4205
## Proposed changes
This PR is mainly do three things:
1. Fix bug introduced by #4029 , when fix conflict with #4086
2. Make drop check code easy to read
3. Add doc content for drop meta check
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [x] Documentation Update (if none of the other choices apply)
- [x] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on #ISSUE #4135 , and have described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #4205: [Bug] Fix fe meta version problem, make drop meta check code easy to read and add doc content for drop meta check
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #4205:
URL: https://github.com/apache/incubator-doris/pull/4205#discussion_r462247082
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java
##########
@@ -2733,12 +2733,12 @@ public void dropDb(DropDbStmt stmt) throws DdlException {
fullNameToDb.remove(db.getFullName());
final Cluster cluster = nameToCluster.get(db.getClusterName());
cluster.removeDb(dbName, db.getId());
- editLog.logDropDb(dbName, !stmt.isNeedCheckCommittedTxns());
+ editLog.logDropDb(dbName, stmt.isForceDrop());
Review comment:
I suggest to modify it like this:
```
DropDbInfo info = new DropDbInfo(dbName, stmt.isForceDrop());
editLog.logDropDb(info);
```
Just like other `editLog.logxxx()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4205: [Bug] Fix fe meta version problem, make drop meta check code easy to read and add doc content for drop meta check
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4205:
URL: https://github.com/apache/incubator-doris/pull/4205
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on a change in pull request #4205: [Bug] Fix fe meta version problem, make drop meta check code easy to read and add doc content for drop meta check
Posted by GitBox <gi...@apache.org>.
caiconghui commented on a change in pull request #4205:
URL: https://github.com/apache/incubator-doris/pull/4205#discussion_r462250949
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java
##########
@@ -2733,12 +2733,12 @@ public void dropDb(DropDbStmt stmt) throws DdlException {
fullNameToDb.remove(db.getFullName());
final Cluster cluster = nameToCluster.get(db.getClusterName());
cluster.removeDb(dbName, db.getId());
- editLog.logDropDb(dbName, !stmt.isNeedCheckCommittedTxns());
+ editLog.logDropDb(dbName, stmt.isForceDrop());
Review comment:
fix done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org