[GitHub] [spark] asmello commented on a change in pull request #24121: [SPARK-26979][PYTHON][FOLLOW-UP] Make binary math/string functions take string as columns as well

[GitBox <gi...@apache.org>]

asmello commented on a change in pull request #24121: [SPARK-26979][PYTHON][FOLLOW-UP] Make binary math/string functions take string as columns as well
URL: https://github.com/apache/spark/pull/24121#discussion_r266332629
 
 

 ##########
 File path: python/pyspark/sql/functions.py
 ##########
 @@ -48,8 +55,11 @@ def _(col):
     return _
 
 
-def _create_function(name, doc=""):
-    """ Create a function that takes a Column object, by name"""
+def _create_function_with_column(name, doc=""):
 
 Review comment:
   While I'm not opposed to renaming these to make their behaviour more clear, I find `_create_function_with_column` quite confusing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org