You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/14 13:55:58 UTC

[GitHub] [apisix-dashboard] starsz opened a new pull request #1051: feat: support search route by label 

starsz opened a new pull request #1051:
URL: https://github.com/apache/apisix-dashboard/pull/1051


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   
   - Related issues
   fix #861 
   ___
   
   ### New feature or improvement
   - Describe the details and related test reports.
   
   1. Add API for the searching labels.
   2. Support filter route by labels.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] membphis edited a comment on pull request #1051: feat: support search route by label

Posted by GitBox <gi...@apache.org>.
membphis edited a comment on pull request #1051:
URL: https://github.com/apache/apisix-dashboard/pull/1051#issuecomment-745315051


   @starsz this is a big PR, can we split this PR to multiple small PRs? 
   
   small PR is easy to review and merge, and we can implement this feature step by step


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] membphis commented on pull request #1051: feat: support search route by label

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1051:
URL: https://github.com/apache/apisix-dashboard/pull/1051#issuecomment-745315051


   @starsz this is a big PR, can we split this PR to multiple small PRs?
   
   small PR is easy to review and merge.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on pull request #1051: feat: support search route by label

Posted by GitBox <gi...@apache.org>.
starsz commented on pull request #1051:
URL: https://github.com/apache/apisix-dashboard/pull/1051#issuecomment-747263698


   I will split it into two PRs.
   The first is #1061.
   And after merging, I will push the second PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on pull request #1051: feat: support search route by label

Posted by GitBox <gi...@apache.org>.
starsz commented on pull request #1051:
URL: https://github.com/apache/apisix-dashboard/pull/1051#issuecomment-745342934


   > @starsz this is a big PR, can we split this PR to multiple small PRs?
   > 
   > small PR is easy to review and merge, and we can implement this feature step by step
   
   Sure, let me split it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1051: feat: support search route by label

Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1051:
URL: https://github.com/apache/apisix-dashboard/pull/1051#issuecomment-748727516


   this PR should be closed now. feel free to reopen it if you need.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen closed pull request #1051: feat: support search route by label

Posted by GitBox <gi...@apache.org>.
nic-chen closed pull request #1051:
URL: https://github.com/apache/apisix-dashboard/pull/1051


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org