You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2016/02/12 03:40:18 UTC
[jira] [Commented] (GEODE-913) Refactor DistributionConfig to ease
the addition of new configuration
[ https://issues.apache.org/jira/browse/GEODE-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143920#comment-15143920 ]
ASF subversion and git services commented on GEODE-913:
-------------------------------------------------------
Commit 700599052b74072115b4b17b25de23dcd78cd8c2 in incubator-geode's branch refs/heads/develop from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=7005990 ]
GEODE-913: refactor AbstractDistributionConfig
* use annotations to annotate the config attributes and its setters/getters/checkers
* delete multiple huge if/else statements to use annoations
* delete unnecessary checks use annotated checkers.
* delete all isXXModifiers to use attribute lists to denote if the attribute is modifiable or not.
> Refactor DistributionConfig to ease the addition of new configuration
> ---------------------------------------------------------------------
>
> Key: GEODE-913
> URL: https://issues.apache.org/jira/browse/GEODE-913
> Project: Geode
> Issue Type: Improvement
> Components: management
> Reporter: Jinmei Liao
> Assignee: Jinmei Liao
>
> Current DistributionConfigImpl has numerous getter/setting/checkModifiable/isModifiable for every attribute. This make adding new attribute hard to follow. Explore ways to refactor this and add unit tests
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)